[Bug 51294] New: Unknown evaluation order in winefile/winefile.c

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51294

Bug ID: 51294
           Summary: Unknown evaluation order in winefile/winefile.c
           Product: Wine
           Version: 6.11
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

https://github.com/wine-mirror/wine/blob/e909986e6ea5ecd49b2b847f321ad89b2ae...

```

load_string(g_pos_names[col++], ARRAY_SIZE(g_pos_names[col]),
IDS_COL_NAME);
    load_string(g_pos_names[col++], ARRAY_SIZE(g_pos_names[col]),
IDS_COL_SIZE);
    load_string(g_pos_names[col++], ARRAY_SIZE(g_pos_names[col]),
IDS_COL_CDATE);
    load_string(g_pos_names[col++], ARRAY_SIZE(g_pos_names[col]),
IDS_COL_ADATE);
    load_string(g_pos_names[col++], ARRAY_SIZE(g_pos_names[col]),
IDS_COL_MDATE);
    load_string(g_pos_names[col++], ARRAY_SIZE(g_pos_names[col]), IDS_COL_IDX);
    load_string(g_pos_names[col++], ARRAY_SIZE(g_pos_names[col]),
IDS_COL_LINKS);
    load_string(g_pos_names[col++], ARRAY_SIZE(g_pos_names[col]),
IDS_COL_ATTR);
    load_string(g_pos_names[col++], ARRAY_SIZE(g_pos_names[col]), IDS_COL_SEC);
```

col is used and incremented in same line, so it may work different on different
platforms

[Bug 51294] Unknown evaluation order in winefile/winefile.c

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=51294

Andrew Nguyen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Andrew Nguyen  ---
There is no problem with the code snippet that I see. The
ARRAY_SIZE(g_pos_names[col]) expressions would expand to
(sizeof(g_pos_names[col]) / sizeof((g_pos_names[col])[0])), and sizeof is
evaluated based only on the type of the supplied expressions, so there is no
"access" of the col variable involved there.

[Bug 51294] Unknown evaluation order in winefile/winefile.c

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=51294

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Ken Sharp  ---
Closing bugs marked as invalid.