[Bug 17010] New: Interface not supported in mshtml

http://bugs.winehq.org/show_bug.cgi?id=17010

Summary: Interface not supported in mshtml
           Product: Wine
           Version: 1.1.13
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: mshtml
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

( Discussion initially started at http://forum.winehq.org/viewtopic.php?t=3541
)
Trying to use "Impôt Expert", a canadian tax software (in French), version
2008.1201.

Tried with Wine 1.0.1, as packaged by Debian Team.

Installer works, basic forms too, but after entering tax payer ID, application
crash.  Last info on console is 
fixme:mshtml:HTMLDocument_QueryInterface
(0x19f410)->({df0b3d60-548f-101b-8e65-08002b2bd119} 0x33c740) interface not
supported
followed by a message about unhandled exception (sorry, no verbatim info
available).  I'm assuming the software isn't programmed to trap the
E_NOINTERFACE value returned by HTMLDocument_QueryInterface in htmldoc.c

Tried with Wine 1.1.3 from http://winehq.org/download/deblenny
Same result, except that the unhandled exception message is gone.

I tried rebuilding and patching, without success.  Apparently, UUID
df0b3d60-548f-101b-8e65-08002b2bd119 is already handled as ISupportErrorInfo in
wine, but just not implemented in mshtml.

After reading http://msdn.microsoft.com/en-us/library/ms714399(VS.85).aspx I
tried patching HTMLDocument_QueryInterface to return S_FALSE instead of
E_NOINTERFACE (increadibly ugly, but just to peek).  In that case, Wine crash
with a
wine: Unhandled page fault on read access to 0x00000000 at address 0x4eb79d
(thread 002a), starting debugger...

I'd think that there is no way but to really implement the interface.

Let me know what else I can provide.  I'm able to test patches, but as this is
on a P3 with 256MB RAM, it's somewhat painful.

[Bug 17010] Interface not supported in mshtml

http://bugs.winehq.org/show_bug.cgi?id=17010

--- Comment #1 from Nikolay Sivov   2009-01-18 17:09:31 ---
Created an attachment (id=18815)
 --> (http://bugs.winehq.org/attachment.cgi?id=18815)
implemented ISupportErrorInfo

Hi Jean.

Please try again with this patch applied. I hope it's enough for this
interface.

P.S. Not posted to wine-patches...waiting feedback.

[Bug 17010] Interface not supported in mshtml

http://bugs.winehq.org/show_bug.cgi?id=17010

--- Comment #2 from Jean-Marc Ranger   2009-01-18 18:56:20 ---
Created an attachment (id=18816)
 --> (http://bugs.winehq.org/attachment.cgi?id=18816)
Result when patch 18815 is applied

Hello Nikolay,

Thanks a lot for this fast reply.

Result:  half and half.  Possibly fixed, but I'd say we bumped another one
right after.  Please see the attached log - his English is better than mine...

Regards,

JMRanger

[Bug 17010] Interface not supported in mshtml

http://bugs.winehq.org/show_bug.cgi?id=17010

--- Comment #3 from Jean-Marc Ranger   2009-01-18 18:57:19 ---
Created an attachment (id=18817)
 --> (http://bugs.winehq.org/attachment.cgi?id=18817)
Result when patch 18815 is applied (run with WINEDEBUG +=mshtml)

[Bug 17010] Interface not supported in mshtml

http://bugs.winehq.org/show_bug.cgi?id=17010

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Nikolay Sivov   2009-01-19 02:19:58 ---
(In reply to comment #3)
> Created an attachment (id=18817)

--> (http://bugs.winehq.org/attachment.cgi?id=18817) [details]
> Result when patch 18815 is applied (run with WINEDEBUG +=mshtml)

Thanks for testing. I'll try to post this patch. These gecko 0.9.0 errors
always look suspicious for me..but I'm not sure. Let's wait for mshtml
developer, I don't know its guts well.

[Bug 17010] Interface not supported in mshtml

http://bugs.winehq.org/show_bug.cgi?id=17010

--- Comment #5 from Alistair Leslie-Hughes   2009-01-19 04:37:01 ---
Created an attachment (id=18823)
 --> (http://bugs.winehq.org/attachment.cgi?id=18823)
Implement IHTMLDocument3_getElementsByTagName

The issue appear to be here.
fixme:mshtml:HTMLDocument3_getElementsByTagName (0x1b5558)->(L"IMG" 0x32ede4)

Try the attached patch.

[Bug 17010] Interface not supported in mshtml

http://bugs.winehq.org/show_bug.cgi?id=17010

--- Comment #6 from Jean-Marc Ranger   2009-01-19 06:47:28 ---
Problem solved !

Some comments, though:
- My test was performed with both patches applied.  Let me know if you'd like
me to only try with the second.
- I'm not sure to understand the second patch.  Not that it matters, but there
are still numerous instances of fixme:mshtml:HTMLDocument3_getElementsByTagName
in the log.  I can't tell whether this is significant - again, let me know what
input you need,if any.

Thanks to both of you.

JMRanger

[Bug 17010] Interface not supported in mshtml

http://bugs.winehq.org/show_bug.cgi?id=17010

--- Comment #7 from Nikolay Sivov   2009-01-19 07:52:22 ---
(In reply to comment #6)
> Problem solved !
>
> Some comments, though:
> - My test was performed with both patches applied.  Let me know if you'd like
>
> me to only try with the second.

Congrats. Yes, try please only with a second one. May be mine isn't necessary
here.

[Bug 17010] Interface not supported in mshtml

http://bugs.winehq.org/show_bug.cgi?id=17010

--- Comment #8 from Nikolay Sivov   2009-01-19 09:11:26 ---
(In reply to comment #7)
> (In reply to comment #6)
> > Problem solved !
> >
> > Some comments, though:
> > - My test was performed with both patches applied.  Let me know if you'd like
> >
> > me to only try with the second.
>
> Congrats. Yes, try please only with a second one. May be mine isn't necessary
> here.

Could ignore this cause my patch is committed just now.

[Bug 17010] Interface not supported in mshtml

http://bugs.winehq.org/show_bug.cgi?id=17010

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Alistair Leslie-Hughes   2009-01-23 05:55:41 ---
A fix has been committed.
http://source.winehq.org/git/wine.git/?a=commit;h=a44ff54d814d4c54bebcf88144...

[Bug 17010] Interface not supported in mshtml

http://bugs.winehq.org/show_bug.cgi?id=17010

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard   2009-01-30 11:05:04 ---
Closing bugs fixed in 1.1.14.