[Bug 38662] New: Windows-compliant CLI/.NET image loading procedure requires mscoree._CorValidateImage implementation for Wine-Mono

https://bugs.winehq.org/show_bug.cgi?id=38662

Bug ID: 38662
           Summary: Windows-compliant CLI/.NET image loading procedure
                    requires mscoree._CorValidateImage implementation for
                    Wine-Mono
           Product: Wine
           Version: 1.7.44
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: mscoree
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hello folks,

required for bug 38661 in case Wine-Mono is used (default).
You don't need this when MS .NET Framework is present in prefix.

Patch with semi-impl by Michael available in Wine-Staging:

https://github.com/wine-compholio/wine-staging/tree/master/patches/mscoree-C...

I did some further research and found interesting discussions about the details
here:

Discussion between Kornél Pál (Mono) and Vincent Povirk (Wine-Mono):

http://lists.ximian.com/pipermail/mono-devel-list/2011-March/037051.html
("mixed-mode assemblies in wine")

Discussion between Kornél Pál (Mono) and Microsoft Developers:

http://www.pcreview.co.uk/threads/using-the-loader-with-a-custom-runtime.369...
("Using the loader with a custom runtime")

Mono source:

https://github.com/mono/mono/blob/master/mono/metadata/coree.c#L218

https://github.com/mono/mono/commit/b06a638552f95acbadb35b63d4c70095aac8f64e
("Mono runtime: Add support for mixed-mode assemblies")

https://github.com/mono/mono/commit/9b509fafb17957ebdbefb92125b8e77d749c475a
("Implement support for mixed-mode assemblies on Windows x64 as well.")

https://github.com/mono/mono/commit/a758271d3dfa30383cec8c40c19fc69a67fdb37c
("Some 64-bit IL only images have entry point...")

$ sha1sum still---coronoid.zip 
3ab7239a42be3135fff996a77b6f4e3b34c73295  still---coronoid.zip

$ du -sh still---coronoid.zip 
56M    still---coronoid.zip

$ wine --version
wine-1.7.44

Regards

[Bug 38662] Windows-compliant CLI/.NET image loading procedure requires mscoree._CorValidateImage implementation for Wine-Mono

https://bugs.winehq.org/show_bug.cgi?id=38662

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |ftp://ftp.scene.org/pub/par
                   |                            |ties/2015/nvscene15/demo_pc
                   |                            |/still---coronoid.zip
           Hardware|x86                         |x86-64

[Bug 38662] Windows-compliant CLI/.NET image loading procedure requires mscoree._CorValidateImage implementation for Wine-Mono

https://bugs.winehq.org/show_bug.cgi?id=38662

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 38662] Windows-compliant CLI/.NET image loading procedure requires mscoree._CorValidateImage implementation for Wine-Mono

https://bugs.winehq.org/show_bug.cgi?id=38662

Michael Müller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |STAGED
    Staged patchset|                            |https://github.com/wine-com
                   |                            |pholio/wine-staging/tree/ma
                   |                            |ster/patches/mscoree-CorVal
                   |                            |idateImage

[Bug 38662] Windows-compliant CLI/.NET image loading procedure requires mscoree._CorValidateImage implementation for Wine-Mono

https://bugs.winehq.org/show_bug.cgi?id=38662

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 38662] Windows-compliant CLI/ .NET image loading procedure requires mscoree._CorValidateImage implementation for Wine-Mono

https://bugs.winehq.org/show_bug.cgi?id=38662

--- Comment #1 from Anastasius Focht  ---
Hello folks,

revisiting, obviously still present.

https://source.winehq.org/git/wine.git/blob/f9181daa1ddc2c10d3b6ddd4610bc142...

--- snip ---
 260 HRESULT WINAPI _CorValidateImage(PVOID* imageBase, LPCWSTR imageName)
 261 {
 262     TRACE("(%p, %s): stub\n", imageBase, debugstr_w(imageName));
 263     return E_FAIL;
 264 }
--- snip ---

$ wine --version
wine-3.1

Regards

[Bug 38662] Windows-compliant CLI/ .NET image loading procedure requires mscoree._CorValidateImage implementation for Wine-Mono

https://bugs.winehq.org/show_bug.cgi?id=38662

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Staged patchset|https://github.com/wine-com |https://github.com/wine-sta
                   |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast
                   |ster/patches/mscoree-CorVal |er/patches/mscoree-CorValid
                   |idateImage                  |ateImage

[Bug 38662] Windows-compliant CLI/.NET image loading procedure requires mscoree._CorValidateImage implementation for Wine-Mono

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38662

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|ftp://ftp.scene.org/pub/par |https://web.archive.org/web
                   |ties/2015/nvscene15/demo_pc |/20180812044952/http://arch
                   |/still---coronoid.zip       |ive.scene.org/pub/parties/2
                   |                            |015/nvscene15/demo_pc/still
                   |                            |---coronoid.zip

[Bug 38662] Windows-compliant CLI/.NET image loading procedure requires mscoree._CorValidateImage implementation for Wine-Mono

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38662

Zeb Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Zeb Figura  ---
This was broadly implemented in
https://source.winehq.org/git/wine.git/commitdiff/52e09e823e2a2b65f1f993145c0a65ab1d84713d,
plus later fixes like
https://source.winehq.org/git/wine.git/commitdiff/926dd780697852b375ec0a193c762e7723a3f5e6.

These things may be supposed to be done in _CorValidateImage(), but do we care?

[Bug 38662] Windows-compliant CLI/.NET image loading procedure requires mscoree._CorValidateImage implementation for Wine-Mono

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38662

Esme Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]