[Bug 21906] New: setupapi copyfiles action target must default to LDID_WIN (win9x) or LDID_SYS (NT) when neither DestinationDirs nor DefaultDestDir is given

http://bugs.winehq.org/show_bug.cgi?id=21906

Summary: setupapi copyfiles action target must default to
                    LDID_WIN (win9x) or LDID_SYS (NT) when neither
                    DestinationDirs nor DefaultDestDir is given
           Product: Wine
           Version: 1.1.39
          Platform: x86
               URL: http://visiteinteractive.free.fr/VM_java/msjavx86.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: setupapi
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Hello,

with bug 18097 fixed (extrac32.exe tool), the msjavx86.exe installer still
fails.

WINEDEBUG=+tid,+seh,+relay,+setupapi wine ./msjavx86.exe &> log.txt

Use the "vminst.log" file in system32 to quickly determine which part failed.

--- snip ---
=== INF Invocation ==========================================

Type : RunSetupCommand
INF  : C:\windows\temp\IXP000.TMP\java.inf

00000000 : WFCClean.RunNow
00000000 : CleanUp
00000000 : BaseInstallation.NT5
00000000 : BaseInstallation.RegNow
00000000 : IEOptions.Register
00000000 : IEOptions.X86.Register
00000000 : BaseInstallation.ClassFiles
80004005 : BasePkgMgr.Install.Execute
...
--- snip ---

java.inf -> "BasePkgMgr.Install.Execute" part failed.

--- snip ---
[BasePkgMgr.Install.Execute]
ComponentName=Java
RunPreSetupCommands=BASEINST.ExecPkgMgr
--- snip ---

--- snip ---
[BASEINST.ExecPkgMgr]
rundll32 %11%\msjava.dll,JavaPkgMgr_Install
%10%\Java\classes\classes.zip,1,5,00,%VERNUM%,4,286,%10%\java\classes\classes.cer
rundll32 %11%\msjava.dll,JavaPkgMgr_Install
%10%\Java\trustlib\tclasses.zip,1,5,00,%VERNUM%,6,286,%10%\java\trustlib\tclasses.cer
rundll32 %11%\msjava.dll,JavaPkgMgr_Install
%10%\Java\classes\msjdbc.zip,1,5,00,%VERNUM%,4,286,%10%\java\classes\msjdbc.cer
%11%\jdbgmgr.exe -regserver
--- snip ---

The self-register call fails because there is no target file ("%11%\jdbgmgr.exe
-regserver"):

--- snip ---
001d:Call KERNEL32.CreateProcessW(00000000,0033d22c
L"C:\windows\system32\jdbgmgr.exe
-regserver",00000000,00000000,00000000,04000200,00000000,00152a50
L"C:\windows\temp\IXP000.TMP",0033d18c,0033d1d0) ret=62fee93c
001d:Ret  KERNEL32.CreateProcessW() retval=00000000 ret=62fee93c
--- snip ---

Go back to .inf to look up named sections for the file:

--- snip ---
[BASEINST.SysFilesNoReg]
jdbgmgr.exe,,,33
javart.dll,,,33
msjdbc10.dll,,,33
zonedoff.reg,,,33
zonedon.reg,,,33
...
[BASEINST.SysFilesNoReg.NT5]
clspack.exe,,,33
javart.dll,,,33
jdbgmgr.exe,,,33
jview.exe,,,33
msjdbc10.dll,,,33
wjview.exe,,,33
zonedoff.reg,,,33
zonedon.reg,,,33
--- snip ---

The copy files action is listed here:

--- snip ---
[BaseInstallation]
ComponentName=Java
CheckAdminRights=1
CopyFiles=BASEINST.SysFilesRegister,BASEINST.SysFilesNoReg,BASEINST.WinFiles,BASEINST.INF
AddReg=BASEINST.AddReg

[BaseInstallation.NT5]
ComponentName=Java
CheckAdminRights=1
CopyFiles=BASEINST.SysFilesRegister,BASEINST.SysFilesNoReg.NT5,BASEINST.INF
AddReg=BASEINST.AddReg
--- snip ---

The culprit (BASEINST.SysFilesNoReg.NT5) is here:

--- snip ---
...
001d:trace:setupapi:SetupGetStringFieldW context 0x1526a8/0x1526a8/6/2 index 2
returning L"BASEINST.SysFilesNoReg.NT5"
001d:trace:setupapi:SetupQueueCopySectionW hinf=0x1526a8/0x1526a8
section=L"BASEINST.SysFilesNoReg.NT5" root=L"C:\windows\temp\IXP000.TMP"
001d:Call KERNEL32.SetLastError(00000000) ret=5092b82c
001d:Ret  KERNEL32.SetLastError() retval=00000000 ret=5092b82c
001d:trace:setupapi:SetupFindFirstLineW
(0x1526a8,L"BASEINST.SysFilesNoReg.NT5",(null)): returning 62/0
001d:trace:setupapi:SetupFindNextMatchLineW
(0x1526a8,L"DestinationDirs",L"BASEINST.SysFilesNoReg.NT5"): not found
001d:Call KERNEL32.SetLastError(e0000102) ret=5092bed6
001d:Ret  KERNEL32.SetLastError() retval=e0000102 ret=5092bed6
001d:trace:setupapi:SetupFindNextMatchLineW
(0x1526a8,L"DestinationDirs",L"DefaultDestDir"): not found
001d:Call KERNEL32.SetLastError(e0000102) ret=5092bed6
001d:Ret  KERNEL32.SetLastError() retval=e0000102 ret=5092bed6
001d:Call KERNEL32.SetLastError(00000000) ret=5092c4be
001d:Ret  KERNEL32.SetLastError() retval=00000000 ret=5092c4be
001d:trace:setupapi:SetupGetStringFieldW context 0x1526a8/0x1526a8/6/2 index 3
returning L"BASEINST.INF"
...
--- snip ---

"BASEINST.SysFilesNoReg.NT5" is skipped because there is no "DestinationDirs"
for this named section present (unlike the others BASEINST.SysFilesRegister and
BASEINST.INF):

--- snip ---
[DestinationDirs]
PRECLEAN.RegSvr=11
BASEINST.ClassFiles=10,Java\Classes
BASEINST.TClassFiles=10,Java\TrustLib
BASEINST.SysFilesRegister=11
BASEINST.SysFilesNoReg=11
BASEINST.WinFiles=10
BASEINST.INF=17
--- snip ---

"[DestinationDirs]" -> "DefaultDestDir" is also missing. Because of this the
file is never copied.

http://msdn.microsoft.com/en-us/library/ms794560.aspx (INF CopyFiles Directive)

--- quote ---
If a named section referenced by a CopyFiles directive has a corresponding
entry in the DestinationDirs section of the same INF, that entry explicitly
specifies the target destination directory into which all files that are listed
in the named section are copied. If the named section is not listed in the
DestinationDirs section, Setup uses the DefaultDestDir in the INF file.
...
--- quote ---

And what if no "DefaultDestDir" is given?

I searched a bit and found this:
http://technet.microsoft.com/en-us/library/cc768164.aspx (Appendix C - Windows
98 INF Files)

--- quote ---
The optional DefaultDestDir entry provides a default destination for any
Copyfile entries that use the direct copy notation (@filename) or any
[File-List] section not specified in the [DestinationDirs] section. If
DefaultDestDir is not given, the default directory is set to LDID_WIN.
--- quote ---

LDID_WIN might apply to Win9X but not to Windows NT.
In many .INF files for win32/NT you will find:

--- snip ---
[DestinationDirs]
...
DefaultDestDir = 11 ; LDID_SYS
--- snip ---

So the default for non-existing "DefaultDestDir" on NT is LDID_SYS (as the .inf
references the file(s) as "%11%<executable>")

You may want to fix dlls/setupapi/queue.c:get_destination_dir().

With this bug is fixed, the installer almost cleanly installs except for bug 
18098 (urlmon.AsyncInstallDistributionUnit not implemented).

Regards

[Bug 21906] setupapi copyfiles action target must default to LDID_WIN (win9x) or LDID_SYS (NT) when neither DestinationDirs nor DefaultDestDir is given

http://bugs.winehq.org/show_bug.cgi?id=21906

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, Installer

[Bug 21906] setupapi copyfiles action target must default to LDID_WIN (win9x) or LDID_SYS (NT) when neither DestinationDirs nor DefaultDestDir is given

http://bugs.winehq.org/show_bug.cgi?id=21906

--- Comment #1 from Hans Leidekker   2010-03-02 02:12:15 ---
Created an attachment (id=26568)
 --> (http://bugs.winehq.org/attachment.cgi?id=26568)
setupapi: Destination directory defaults to system directory.

How about this patch?

[Bug 21906] setupapi copyfiles action target must default to LDID_WIN (win9x) or LDID_SYS (NT) when neither DestinationDirs nor DefaultDestDir is given

http://bugs.winehq.org/show_bug.cgi?id=21906

--- Comment #2 from Anastasius Focht   2010-03-02 05:35:35 ---
Hello,

--- quote ---
How about this patch?
--- quote ---

sure it lets the installer succeed - as expected ;-)

"c:\windows\vminst.log":

--- snip ---
...
=== INF Invocation ==========================================

Type : RunSetupCommand
INF  : C:\users\focht\Temp\IXP000.TMP\java.inf

00000000 : WFCClean.RunNow
00000000 : CleanUp
00000000 : BaseInstallation.NT5
00000000 : BaseInstallation.RegNow
00000000 : IEOptions.Register
00000000 : IEOptions.X86.Register
00000000 : BaseInstallation.ClassFiles
00000000 : BasePkgMgr.Install.Execute
00000000 : X86Installation.ClassFiles
00000000 : X86Installation.PkgMgr.Execute
00000000 : X86Installation
00000000 : X86Installation.RegNow
00000000 : WFCInstallation.CopyFiles
00000000 : WFCInstallation.PkgMgr.Execute
00000000 : WFCInstallation.RegisterNow
00000000 : CAB.AddUninstallKey
00000000 : NT5.MSXML.MoveFile
00000000 : IE40.MSXML.PkgMgr.RunNow
...
--- snip ---

(00000000 = HRESULT -> S_OK)

Regards

[Bug 21906] setupapi copyfiles action target must default to LDID_WIN (win9x) or LDID_SYS (NT) when neither DestinationDirs nor DefaultDestDir is given

http://bugs.winehq.org/show_bug.cgi?id=21906

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |21911

[Bug 21906] setupapi copyfiles action target must default to LDID_WIN (win9x) or LDID_SYS (NT) when neither DestinationDirs nor DefaultDestDir is given

http://bugs.winehq.org/show_bug.cgi?id=21906

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Austin English   2010-03-03 11:41:56 ---
Patch committed:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=1b8ba2537111f0d691d259...

Thanks Anastasius/Hans!

[Bug 21906] setupapi copyfiles action target must default to LDID_WIN (win9x) or LDID_SYS (NT) when neither DestinationDirs nor DefaultDestDir is given

http://bugs.winehq.org/show_bug.cgi?id=21906

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard   2010-03-05 12:43:38 ---
Closing bugs fixed in 1.1.40.

[Bug 21906] setupapi copyfiles action target must default to LDID_WIN (win9x) or LDID_SYS (NT) when neither DestinationDirs nor DefaultDestDir is given

http://bugs.winehq.org/show_bug.cgi?id=21906

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |1b8ba2537111f0d691d2592bb4f
                   |                            |fb6bc4fe4f20e

--- Comment #5 from Anastasius Focht  2011-10-11 15:08:45 CDT ---
Hello,

filling/correcting fields ...

Regards

[Bug 21906] setupapi copyfiles action target must default to LDID_WIN (win9x) or LDID_SYS (NT) when neither DestinationDirs nor DefaultDestDir is given

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=21906

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://visiteinteractive.fr |https://web.archive.org/web
                   |ee.fr/VM_java/msjavx86.exe  |/20060916120700/http://visi
                   |                            |teinteractive.free.fr/VM_ja
                   |                            |va/msjavx86.exe