[Bug 54917] New: Keyboard input issues in NFS Underground since wine-8.5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54917

Bug ID: 54917
           Summary: Keyboard input issues in NFS Underground since
                    wine-8.5
           Product: Wine
           Version: 8.7
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: dinput
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
      Distribution: ArchLinux

Created attachment 74431
  --> https://bugs.winehq.org/attachment.cgi?id=74431
NFS Underground +dinput log on wine-8.4

Hello,

So NFS Underground (and other NFS games from the same era) have keyboard input
issues since wine-8.5 (which rewrote a lot of dinput code)

When you first open the game in wine-8.5, you'll see that the mappings are
completely different (if you set ones previously)

Also there's a good chance when you set a mapping that it will disappear the
next time you load the game

Or the mappings that managed to be saved may not actually work in-game for some
weird reason

If you switch to wine-staging the problems get worse (the arrow keys just stop
working in the menu)

I haven't tried to bisect yet though (I'm a bit too lazy), but I'll provide
both wine-8.4 and 8.7 logs with WINEDEBUG=+dinput set

Note: The 8.7 log will be added in a comment (Bugzilla limitations?)

[Bug 54917] Keyboard input issues in NFS Underground since wine-8.5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54917

--- Comment #1 from [e-mail] ---
Created attachment 74432
  --> https://bugs.winehq.org/attachment.cgi?id=74432
NFS Underground +dinput log on wine-8.4

[Bug 54917] Keyboard input issues in NFS Underground since wine-8.5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54917

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #74432|NFS Underground +dinput log |NFS Underground +dinput log
        description|on wine-8.4                 |on wine-8.7

[Bug 54917] Keyboard input issues in NFS Underground since wine-8.5

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54917

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 54917] Need For Speed Underground has keyboard input issues

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54917

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Keyboard input issues in    |Need For Speed Underground
                   |NFS Underground since       |has keyboard input issues
                   |wine-8.5                    |
            Version|8.7                         |8.5

[Bug 54917] Need For Speed Underground has keyboard input issues

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54917

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |1e594b1c0fd23c1aedc13b3c2d8
                   |                            |c91c1fc00f8ee

[Bug 54917] Need For Speed Underground has keyboard input issues

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54917

--- Comment #2 from [e-mail] ---
1e594b1c0fd23c1aedc13b3c2d8c91c1fc00f8ee seems to be the problematic commit

[Bug 54917] Need For Speed Underground has keyboard input issues

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54917

--- Comment #3 from Rémi Bernon  ---
I have opened https://gitlab.winehq.org/wine/wine/-/merge_requests/2861 which
should fix the regression. Note that Windows has removed support for saving and
loading of action maps, so this is a Wine-specific feature.

[Bug 54917] Need For Speed Underground has keyboard input issues

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54917

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |cb7bb2284c37d0dbd58bfe72594
                   |                            |fabb7ab398e05

--- Comment #4 from Rémi Bernon  ---
Should be fixed after cb7bb2284c37d0dbd58bfe72594fabb7ab398e05, although it
might require the mapping in the registry to be wiped out as it was previously
possible to have a duplicate mapping for a given key, and that would cause any
update to the mapping to fail.

[Bug 54917] Need For Speed Underground has keyboard input issues

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54917

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 8.9.

[Bug 54917] Need For Speed Underground has keyboard input issues

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=54917

mirh  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from mirh  ---
Vista just stopped to ship dimap.dll, which did break the mapper, but
everything else is still there AFAIU.

Even then, when you set here a bottle version to be XP, this would be kinda
expected feature (not just something extra for quality of life).