[Bug 17107] New: compiler warnings in server/fd.c on NetBSD

http://bugs.winehq.org/show_bug.cgi?id=17107

Summary: compiler warnings in server/fd.c on NetBSD
           Product: Wine
           Version: 1.1.13
          Platform: PC
        OS/Version: NetBSD
            Status: NEW
          Keywords: download, source
          Severity: enhancement
          Priority: P2
         Component: wineserver
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

fd.c: In function 'set_fd_epoll_events':
fd.c:580: warning: assignment makes integer from pointer without a cast
fd.c:581: warning: assignment makes integer from pointer without a cast

Only appears on NetBSD, but not OpenBSD/FreeBSD. Vincent Povirk helped me
investigate on IRC, and looks like the problem is that on FreeBSD, in
/usr/include/sys/event.h you've got:
struct kevent {
        uintptr_t       ident;          /* identifier for this event */
        short           filter;         /* filter for event */
        u_short         flags;
        u_int           fflags;
        intptr_t        data;
        void            *udata;         /* opaque user data identifier */
};

But on NetBSD:

struct kevent {
        uintptr_t       ident;          /* identifier for this event */ 
        uint32_t        filter;         /* filter for event */
        uint32_t        flags;          /* action flags for kqueue */
        uint32_t        fflags;         /* filter flag value */ 
        int64_t         data;           /* filter data value */
        intptr_t        udata;          /* opaque user data identifier */
};

Note the difference in udata 'void *' vs 'intptr_t'.

Relevant lines from the code:
    EV_SET( &ev[0], fd->unix_fd, EVFILT_READ, 0, NOTE_LOWAT, 1, (void *)user );
    EV_SET( &ev[1], fd->unix_fd, EVFILT_WRITE, 0, NOTE_LOWAT, 1, (void *)user
);

removing (void *) or changing it to intptr_t fixes the warning, but doesn't
seem a proper fix. Probably needs an ifdef or typedef, but I'll leave that for
someone else to decide.

[Bug 17107] compiler warnings in server/fd.c on NetBSD

http://bugs.winehq.org/show_bug.cgi?id=17107

--- Comment #1 from Austin English   2009-05-28 22:12:24 ---
Still present in git.

[Bug 17107] compiler warnings in server/fd.c on NetBSD

http://bugs.winehq.org/show_bug.cgi?id=17107

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from André H.  2011-10-16 10:31:40 CDT ---
http://www.winehq.org/pipermail/wine-patches/2011-October/107923.html

[Bug 17107] compiler warnings in server/fd.c on NetBSD

http://bugs.winehq.org/show_bug.cgi?id=17107

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]

--- Comment #3 from Jerome Leclanche  2011-11-07 15:19:49 CST ---
Patch was not committed (pending).

[Bug 17107] compiler warnings in server/fd.c on NetBSD

http://bugs.winehq.org/show_bug.cgi?id=17107

--- Comment #4 from André H.  2013-06-04 15:52:51 CDT ---
(In reply to comment #3)
> Patch was not committed (pending).

yeah, this needs a better solution, but NetBSD isn't really supported atm
anyway

[Bug 17107] compiler warnings in server/fd.c on NetBSD

https://bugs.winehq.org/show_bug.cgi?id=17107

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from joaopa  ---
Does the bug still occur with current wine (3.21)?