[Bug 22457] New: Release 1.1.43 broke some toolbar icons

http://bugs.winehq.org/show_bug.cgi?id=22457

Summary: Release 1.1.43 broke some toolbar icons
           Product: Wine
           Version: 1.1.43
          Platform: x86
               URL: http://www.securenetterm.com
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The current 1.1.43 version displays disabled icons on a toolbar incorrect.  The
icon is completely black instead of being grayed out.  Looks terrible.

[Bug 22457] Release 1.1.43 broke some toolbar icons

http://bugs.winehq.org/show_bug.cgi?id=22457

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Wylda   2010-04-22 08:39:22 ---

I think there are some bug reports about this already filled in. Try to use
search function or perform regression test.

[Bug 22457] Release 1.1.43 broke some toolbar icons

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #2 from Kenneth Robinette   2010-04-22 09:05:01 ---
I did do a search, and just did another one and did not see another problem
report.  I you know of one, please provide the bug number!!!!!!!!!!!!!!!!!!!!

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Release 1.1.43 broke some   |Disabled toolbar icons are
                   |toolbar icons               |black

--- Comment #3 from Dmitry Timoshkov   2010-04-22 09:07:40 ---
What application is that? Please test with current git, the problem may be
fixed
there already.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #4 from Wylda   2010-04-22 09:10:20 ---
(In reply to comment #2)
> I did do a search, and just did another one and did not see another problem
> report.  I you know of one, please provide the bug number!!!!!!!!!!!!!!!!!!!!

Why should i? I don't have a problem :-)

Not being amateur, i'll take the regression test. In the mean time, you take
your pills, please. :)

I don't want to make you heart attack, so i won't ask which application has
that problem and will test with SecureNetTerm.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #5 from Kenneth Robinette   2010-04-22 09:17:03 ---
Don't worry about it.  We will just drop all support for WINE.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #6 from Wylda   2010-04-22 09:19:07 ---
(In reply to comment #5)
> Don't worry about it.  We will just drop all support for WINE.

I told you, I really do not care. Even kill your self... World won't stop.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Ben Klein  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Ben Klein   2010-04-22 09:37:32 ---
(In reply to comment #6)
> (In reply to comment #5)
> > Don't worry about it.  We will just drop all support for WINE.
>
> I told you, I really do not care. Even kill your self... World won't stop.

That's not called for. No quantity of excess exclamation marks warrants such a
statement.

(In reply to comment #2)
> I did do a search, and just did another one and did not see another problem
> report.

A search for "black toolbar" yields hundreds of results. There are certainly
several bugs relating to corrupted toolbar icons. As it is, Kenneth, you
haven't given any information that's really helpful, like steps to reproduce
(including what application it affects).

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #8 from Wylda   2010-04-22 09:44:23 ---

You are right, that was too much. Sorry.

Anyway, unable to reproduce any icon problem with netterm.exe. Maybe i picked
up wrong application.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #9 from Austin English   2010-04-22 10:59:58 ---
If this is a regression, please run a regression test:
http://wiki.winehq.org/RegressionTesting

(after testing it git, of course).

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #10 from Wylda   2010-04-22 12:38:46 ---
(In reply to comment #2)
> I you know of one, please provide the bug number!!!!!!!!!!!!!!!!!!!!

One just flew in front of my nose... bug 22449 "CDBurnerXP Pro 3's program icon
is displayed incorrectly"

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #11 from Vitaliy Margolen   2010-04-22 22:14:30 ---
With the lack of any additional information marking duplicate.

You are welcome to reopen if problem still exist with latest Wine version.
Don't forget to provide exact application and steps to reproduce the problem.

*** This bug has been marked as a duplicate of bug 22449 ***

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Vitaliy Margolen   2010-04-22 22:14:40 ---
Closing duplicate.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #13 from Kenneth Robinette   2010-04-23 07:04:35 ---
Bug still exists in 1.4.3 and in latest git.  Problem DOES NOT exist in 1.4.2
and prior versions.  Does not happen on Microsoft based system.

Can reproduce with Codejock (http://www.codejock.com/) OutlookBarU.exe sample 
and several other of the codejock samples.  This application(s) was chosen as
an example because source is available.  To duplicate, start program and look
at the disabled icons on the toolbar and or menus.  The problem also appears to
be related to the application theme.  In the OutlookBarU.exe sample, it happens
when the Office 2003 and Office XP theme is selected, but not the Office 2000
theme.

Although the problem appears to be related or affected by the application
theme, this is not the same as the Wine theme.  The problem still happens if
the Wine desktop theme is disabled or a valid theme is selected.

Problem not related to toolbar, just the disabled icons on the toolbar. 
Problem can also be seen with disabled icons within menus.

Problem 22449, related to CDBurnerXP 3.0.116, displayed its program icon
incorrectly in the title bar and taskbar. Areas that should be transparent are
black, and the rest of the icon is transparent.

That is not what I see with bug 22457.  In 22457, it appears that with disabled
icons, the non-transparent portions of the icon is displaying as black.  The
transparent area is displayed correctly.  The problem is also related to the
application theme.  For example, with a disabled paste icon, the clipboard and
paper image is solid black.  Also, bug 22457 is marked as resolved.  However if
it is desired to close this bug report and merge with whatever, no problem.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #14 from Wylda   2010-04-23 07:54:06 ---

Much better...

1. Confirming, please consider DUPLICATE->NEW and KEYWORDS: +REGRESSION

2. I did a regression test between 1.1.42 and 1.1.43:

commit c29cf0591976f96c3adb30c3c3b6db59f4983251
Author: Roderick Colenbrander 
Date:   Tue Apr 6 19:07:25 2010 +0200

winex11: Add support for 32-bit DDBs.

:040000 040000 73b8486e86ccd609ea2f0c8cf0c920b6ec3783dd
04bcf74196ee257fa4b8391041c627b89e6cbffe M      dlls

3. There is another bug report suffering from this commit, see bug 21822.

4. Revert of this patch on top of wine-1.1.43-249-g033bb8a makes that problem
go away.

5. Adding author of this patch to CC.

--private keyword: bisected

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #15 from A Wine user   2010-04-23 08:04:22 ---
(In reply to comment #14)
> - There is another bug report suffering from this commit, see bug 21822.

Bug 21822 wasn't caused by that commit, it was mostly fixed by it (but not
quite). The only other regression I know of from the same commit is bug 22360
(fixed already).

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #16 from Wylda   2010-04-23 08:10:54 ---
Created an attachment (id=27519)
 --> (http://bugs.winehq.org/attachment.cgi?id=27519)
Screenshot from Controls.OutlookBar.exe
> Bug 21822 wasn't caused by that commit, it was mostly fixed by it (but not
> quite).

Hmmm.... you are right.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Kenneth Robinette  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |RESOLVED
         Resolution|DUPLICATE                   |FIXED

--- Comment #17 from Kenneth Robinette   2010-04-23 08:30:19 ---
(In reply to comment #16)
> Created an attachment (id=27519)

--> (http://bugs.winehq.org/attachment.cgi?id=27519) [details]
> Screenshot from Controls.OutlookBar.exe
> > Bug 21822 wasn't caused by that commit, it was mostly fixed by it (but not
> > quite).
>
> Hmmm.... you are right.

I have confirmed that reverting patch c29cf0591976f96c3adb30c3c3b6db59f4983251
resolves the problem reported in 22457.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #18 from Wylda   2010-04-23 08:34:49 ---
(In reply to comment #17)
> I have confirmed that reverting patch c29cf0591976f96c3adb30c3c3b6db59f4983251
> resolves the problem reported in 22457.

But it's not FIXED (the status), it's still waiting for the fix, so status
should be NEW till some patch is accepted.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Kenneth Robinette  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

--- Comment #19 from Kenneth Robinette   2010-04-23 08:48:53 ---
Thanks Wylda.  I changed status to "Verified" since the option of "New" is not
available in the Status dropdown box.  I left the secondary states as fixed
since the other options available in the dropdown box does not make sense.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|VERIFIED                    |UNCONFIRMED
         Resolution|FIXED                       |

--- Comment #20 from Vitaliy Margolen   2010-04-23 08:57:18 ---
Reopening

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #21 from Vitaliy Margolen   2010-04-23 08:57:27 ---
And confirming.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #22 from Wylda   2010-04-23 08:58:51 ---

I'm not Mr. Wine, so i do not have the right to change the status of the bugs.
Wait a while and some will come and change that. Marking it VERIFIED made this
bug unique (there is only one bug with this status --yours ;)

Wait even a bit longer and fix hopefully comes too.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

dueller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

dueller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]      |

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #23 from Kenneth Robinette   2010-05-14 09:51:07 ---
Created an attachment (id=27955)
 --> (http://bugs.winehq.org/attachment.cgi?id=27955)
Application to show disabled icon problem

Unzip attachment to CommandBarIcons.exe.  This application will show the
disabled icon problem where disabled icons are displayed as black blobs.  Note
that patch c29cf0591976f96c3adb30c3c3b6db59f4983251 is the source of this
problem.  If the patch is removed from the current git, the problem goes away.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #24 from Wylda   2010-05-14 09:59:05 ---

Would be good, to properly enter keywords, i.e.: regression, download

and point the URL to the download of test application, which shows that
clearly.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #25 from Roderick Colenbrander   2010-05-19 06:04:24 ---
Can you recheck on current GIT? I think AJ fixed this issue (I guess it is
something alpha related).

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #26 from Kenneth Robinette   2010-05-19 07:24:10 ---
(In reply to comment #25)
> Can you recheck on current GIT? I think AJ fixed this issue (I guess it is
> something alpha related).

I just checked with:

$ wine --version
wine-1.1.44-290-g7d3cb53

and the problem appears to be fixed.  The sample application I submitted on
5-14-2010 as an attachment now runs as it should.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #27 from Nikolay Sivov   2010-05-19 07:26:30 ---
(In reply to comment #26)
> and the problem appears to be fixed.  The sample application I submitted on
> 5-14-2010 as an attachment now runs as it should.

Fixed.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

--- Comment #28 from Wylda   2010-05-19 15:15:30 ---

(In reply to comment #25)
> Can you recheck on current GIT? I think AJ fixed this issue (I guess it is
> something alpha related).

Confirming, FIXED in wine-1.1.44-322-g5cc00e8.

Particular commit (wine-1.1.44-270-gea596f8):
http://source.winehq.org/git/wine.git/?a=commit;h=ea596f8a5f7d732bb56b5921ce...

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |winex11.drv

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #29 from Alexandre Julliard   2010-05-21 14:40:01 ---
Closing bugs fixed in 1.2-rc1.

[Bug 22457] Disabled toolbar icons are black

http://bugs.winehq.org/show_bug.cgi?id=22457

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |ea596f8a5f7d732bb56b5921ceb
                   |                            |964137df0b930
    Regression SHA1|                            |c29cf0591976f96c3adb30c3c3b
                   |                            |6db59f4983251