[Bug 22548] New: Mass Effect 2: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

Summary: Mass Effect 2: Banding in lighting effects
           Product: Wine
           Version: 1.1.43
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=27656)
 --> (http://bugs.winehq.org/attachment.cgi?id=27656)
Shows banding effect

Lighting effects in Mass Effect 2 result in ugly banding. Example image
attached. Please inform about needed logs. Only possibly related (though
unlikely) fixme poping up on console is fixme:d3d_shader:print_glsl_info_log   
 warning: no vertex attribute is explicitly assigned to vertex attribute zero

[Bug 22548] Mass Effect 2: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

Andras Kovacs  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Andras Kovacs   2010-05-05 03:58:01 ---
All unreal 3 engine games affected by this (e.g. UT3)

[Bug 22548] Mass Effect 2: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

blaise  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from blaise   2010-05-17 17:30:28 ---
*If you expereince low-resolution blocky lighting and shadows 
initially, open ~/BioWare/Mass Effect 2/BIOGame/Config/GamerSettings.ini and
add

[TextureLODSettings]
TEXTUREGROUP_LightAndShadowMap=(MinLODSize=256,MaxLODSize=4096,LODBias=1)
or
[TextureLODSettings]
TEXTUREGROUP_LightAndShadowMap=(MinLODSize=256,MaxLODSize=4096,LODBias=0)

http://appdb.winehq.org/objectManager.php?sClass=version&iId=19125

It has to do with the way they did the the Unreal engine setting ini's not a
wine bug.

[Bug 22548] Mass Effect 2: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

--- Comment #3 from blaise   2010-06-03 22:49:57 ---
Or add/change in the GamerSettings.ini

[SystemSettings]
DepthOfField=False

which I just remembered. UT3-type DOF is/was always funky.

[Bug 22548] Mass Effect 2: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Austin English   2010-06-16 23:07:48 ---
*** Bug 23186 has been marked as a duplicate of this bug. ***

[Bug 22548] Mass Effect 2: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #5 from Austin English   2010-06-16 23:08:41 ---
Confirming. There are comparison screenshots and a savegame at a point with a
nice example of this on bug 23186.

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Mass Effect 2: Banding in   |Mass Effect 2/Singularity:
                   |lighting effects            |Banding in lighting effects

--- Comment #6 from Austin English   2010-07-03 01:04:47 ---
Also affects Singularity.

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

--- Comment #7 from Austin English   2010-07-03 01:08:45 ---
Created an attachment (id=29305)
 --> (http://bugs.winehq.org/attachment.cgi?id=29305)
singularity screenshot

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

--- Comment #8 from Austin English   2010-07-03 01:29:27 ---
Disabling 'Depth of Field' in the video options fixes Singularity as well
(there is no ini, it's setting is in the registry).

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

--- Comment #9 from Austin English   2010-07-10 02:33:04 ---
Also affects Transformers: War for Cybertron.

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

Evan Goers  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from Evan Goers   2010-07-10 04:41:50 ---
This likely affects all UE3 games that use the Depth-Of-Field available in the
engine.

However, this doesn't affect Mass Effect(1), which suggests that only the more
recent UE3 engine games are affected.

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

H3g3m0n  █▓▒☢☣☠⚛▒▓█  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from H3g3m0n  █▓▒☢☣☠⚛▒▓█  2011-01-09 00:25:49 CST ---
*** Bug 25721 has been marked as a duplicate of this bug. ***

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

--- Comment #12 from H3g3m0n  █▓▒☢☣☠⚛▒▓█  2011-01-09 00:26:18 CST ---
I have noticed this in both "Mirror's Edge" and "The Ball".

I am running on a Nvidia GTX260, with the official proprietary 260.19.06
drivers.
Ubuntu 10.10 x86_64

In Mirror's Edge it happens when you look into a dark area after looking at a
bright one for a while (or maybe it's when you stare at different colours such
as bright red followed by a dark area). There is supposed to be a kind of blur
effect that fades fairly quickly. Screen shots from the 'prologue' level after
the jump gap onto pipes and enter the door.

Wine: http://i.imgur.com/SjREv.jpg
Windows 7 comparison: http://i.imgur.com/sLFZF.jpg (It's a bit hard to make out
on the screenshot, but there is a subtle soft blur effect that fades away quite
quickly).

In "The Ball" it's noticeable a bit on the title screen, but when underwater it
becomes most obvious. Screenshots from the 2nd level.
Windows 7 Underwater: http://imgur.com/vEPs6.jpg
Wine Underwater: http://i.imgur.com/ep0pY.jpg
Windows 7 Temple: http://i.imgur.com/Itnk8.jpg
Wine Temple: http://i.imgur.com/h1qAS.jpg

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

Jonathan Strander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #13 from Jonathan Strander  2011-06-11 13:39:55 CDT ---
Tested in ME2 with Wine 1.3.22 and this bug is still present.

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from Dan Kegel  2011-07-08 17:14:50 CDT ---
Please test with
http://www.winehq.org/pipermail/wine-patches/2011-July/104152.html
This got rid of the banding in Mass Effect 2 Demo for me.

(When you test, please report whether frame rate is affected, it
seemed to be the first time I ran it, but my system was probably just busy.)

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

--- Comment #15 from André H.  2011-07-08 17:44:02 CDT ---
(In reply to comment #14)
> Please test with
> http://www.winehq.org/pipermail/wine-patches/2011-July/104152.html
> This got rid of the banding in Mass Effect 2 Demo for me.
>
> (When you test, please report whether frame rate is affected, it
> seemed to be the first time I ran it, but my system was probably just busy.)

tested with UT3 and it works, can't say that the framerate was affected, but i
had some seconds of black screen when getting into menu or game.
(maybe match_broken_rgba16 is to much?)

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

DL  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from DL  2011-07-08 22:24:13 CDT ---
I tried the patch with Mirror's Edge and The Last Remnant, and did not notice
any performance decrease (beyond the usual wine performance hit).

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #17 from Austin English  2011-07-11 13:32:57 CDT ---
http://source.winehq.org/git/wine.git/commitdiff/6c5e109af7184ee557aa24c676c...

wooooooooooooooooooooo!

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

http://bugs.winehq.org/show_bug.cgi?id=22548

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #18 from Alexandre Julliard  2011-07-22 12:43:19 CDT ---
Closing bugs fixed in 1.3.25.

[Bug 22548] Mass Effect 2/Singularity: Banding in lighting effects

https://bugs.winehq.org/show_bug.cgi?id=22548

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |6c5e109af7184ee557aa24c676c
                   |                            |c78f3e92e6782