[Bug 55777] New: user32:win - test_GetWindowModuleFileName() sometimes unexpectedly gets a filename on Windows 7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55777

Bug ID: 55777
           Summary: user32:win - test_GetWindowModuleFileName() sometimes
                    unexpectedly gets a filename on Windows 7
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]

user32:win - test_GetWindowModuleFileName() sometimes unexpectedly gets a
filename on Windows 7:

win.c:8792: Test failed: expected 0, got 47

See https://test.winehq.org/data/patterns.html#user32:win

There are two known instances so far:
* 2023-07-24 win7_newtb-w7u-es -> got 47
* 2023-10-11 win7_newtb-w7u-de -> got 47

By chance I managed to reproduce the issue with extra information:

win.c:8800: Test failed: expected 0, got 41
'C:\Users\Public\Documents\user32_test.exe'
win.c:8801: Test failed: expected ERROR_MOD_NOT_FOUND, got 0

So for once, instead of failing to find the module corresponding to the
systray, GetWindowModuleFileName() attributed it to the test executable. That
or hwnd did not in fact correspond to the systray but was not NULL either
(otherwise we would have gotten ERROR_INVALID_WINDOW_HANDLE).

[Bug 55777] user32:win - test_GetWindowModuleFileName() sometimes unexpectedly gets a filename on Windows 7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55777

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase

[Bug 55777] user32:win - test_GetWindowModuleFileName() sometimes unexpectedly gets a filename on Windows 7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55777

--- Comment #1 from François Gouget  ---
I submitted MR!4084 to get more information about these failures.

[Bug 55777] user32:win - test_GetWindowModuleFileName() sometimes unexpectedly gets a filename on Windows 7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55777

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e9f6ff8cd401c8e2cf3c12e155a
                   |                            |8ea33c97abcd3
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from François Gouget  ---
This is fixed:

commit e9f6ff8cd401c8e2cf3c12e155a8ea33c97abcd3
Author:     François Gouget 
AuthorDate: Fri Oct 13 17:53:59 2023 +0200

user32/tests: Don't test GetWindowModuleFileName() on windows belonging to
another process.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55777

From MR!4084:
Alexandre Julliard said:
> That's most likely because the systray window module happens to match
> an existing module in the current process.
> I don't think it makes sense to test GetWindowModuleFileName on windows
> belonging to a different process.

[Bug 55777] user32:win - test_GetWindowModuleFileName() sometimes unexpectedly gets a filename on Windows 7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=55777

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 8.19.