[Bug 21480] New: dash is not recognized as a valid column name

http://bugs.winehq.org/show_bug.cgi?id=21480

Summary: dash is not recognized as a valid column name
           Product: Wine
           Version: 1.1.37
          Platform: x86
               URL: http://www.microsoft.com/office/2010/en/default.aspx
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msi
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The Office 2010 (beta) installer has a table with dashes in the column name and
the query fails to parse in wine.

--snip--
trace:msi:MsiDatabaseOpenViewW L"SELECT ACID, Version, PL, PHN, OOB, PPDLIC,
RAC-Private, RAC-Public FROM LicenseSets"
0x42ee2f8
trace:msi:MsiDatabaseOpenViewW L"SELECT ACID, Version, PL, PHN, OOB, PPDLIC,
RAC-Private, RAC-Public FROM LicenseSets"
0x42ee2f8
trace:msi:MSI_DatabaseOpenViewW L"SELECT ACID, Version, PL, PHN, OOB, PPDLIC,
RAC-Private, RAC-Public FROM LicenseSets"
 0x42edd78
trace:msi:MSI_ParseSQL Parse returned 1
trace:msi:msiobj_release object 0x4973888 destroyed
trace:msi:MsiCloseHandle 5
trace:msi:MsiCloseHandle handle 5 destroyed
trace:msidb:SELECT_delete 0x4b6d898
trace:msidb:TABLE_delete 0x4b6d630
trace:msi:msiobj_release object 0x4b14778 destroyed
trace:msidb:MsiCreateRecord 1
trace:msidb:MSI_CreateRecord 1
trace:msi:alloc_msihandle 0x4b14778 -> 5
trace:msidb:MsiRecordSetStringW 5 0 L"PrepareCAInstallLicenses:  Error: Type:
MsiDatabaseOpenViewW call failed.. MsiAPI
CallFailure ErrorCode: 1615(0x64f). "
--snip--

Sorry, no debug log (its 3 gigs raw), but the download is free (for now) and
the bug can easily be verified.

Making - a valid idchar in dlls/msi/tokenize.c (add 1 in position 0x2D) lets
the installer continue.

[Bug 21480] dash is not recognized as a valid column name

http://bugs.winehq.org/show_bug.cgi?id=21480

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, Installer

[Bug 21480] dash is not recognized as a valid column name

http://bugs.winehq.org/show_bug.cgi?id=21480

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |[e-mail]
         Resolution|                            |FIXED

--- Comment #1 from Hans Leidekker   2010-02-21 06:46:45 ---
This should be fixed by commit f80f1cc2db46e113bff1b132bfc008c2c52fa8b4.

[Bug 21480] dash is not recognized as a valid column name

http://bugs.winehq.org/show_bug.cgi?id=21480

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard   2010-03-05 12:43:19 ---
Closing bugs fixed in 1.1.40.

[Bug 21480] dash is not recognized as a valid column name

http://bugs.winehq.org/show_bug.cgi?id=21480

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |f80f1cc2db46e113bff1b132bfc
                   |                            |008c2c52fa8b4