[Bug 14790] New: after full tilt poker upgrade, client crashes randomly

List overview All Threads

newer

older

[Bug 14908] New: listview items...

[Bug 14725] New: unimplemented...

wine-bugs＠winehq.org

7 Aug 2008 7 Aug '08

4:50 p.m.

http://bugs.winehq.org/show_bug.cgi?id=14790

Summary: after full tilt poker upgrade, client crashes randomly Product: Wine Version: 1.1.2 Platform: PC URL: http://www.fulltiltpoker.com OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown AssignedTo: wine-bugs@winehq.org ReportedBy: wtipton@hmc.edu

Created an attachment (id=15336) --> (http://bugs.winehq.org/attachment.cgi?id=15336) DEBUG=+warn

After an automatic update to the Full Tilt Poker client, it no longer works with wine. The program usually starts up as normal, but crashes, seemingly randomly, after a minute or so, rendering the application useless. A log is attached...

-- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email Do not reply to this email, post in Bugzilla using the above URL to reply. ------- You are receiving this mail because: ------- You are watching all bug changes.

Show replies by date

wine-bugs＠winehq.org

7 Aug 7 Aug

6:35 p.m.

New subject: [Bug 14790] after full tilt poker upgrade, client crashes randomly

http://bugs.winehq.org/show_bug.cgi?id=14790

Lei Zhang thestig@google.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Component|-unknown |comctl32

--- Comment #1 from Lei Zhang thestig@google.com 2008-08-07 13:35:39 --- Looks like there's some problem with tooltips. It probably crashed when you moused over something. Can you compile Wine with debugging symbols so we can see where you crashed in the backtrace log?

wine-bugs＠winehq.org

8:30 p.m.

New subject: [Bug 14790] after full tilt poker upgrade, client crashes randomly

http://bugs.winehq.org/show_bug.cgi?id=14790

--- Comment #2 from Will Tipton wtipton@hmc.edu 2008-08-07 15:30:17 --- Created an attachment (id=15338) --> (http://bugs.winehq.org/attachment.cgi?id=15338) DEBUG=+warn,+tooltips w/ debugging symbols

wine-bugs＠winehq.org

8:49 p.m.

New subject: [Bug 14790] after full tilt poker upgrade, client crashes randomly

http://bugs.winehq.org/show_bug.cgi?id=14790

--- Comment #3 from Will Tipton wtipton@hmc.edu 2008-08-07 15:49:30 --- Thanks for your quick response. It appears that infoPtr->tools[nTool].lpszText == NULL in dlls/comctl32/tooltips.c:TOOLTIPS_GetTextW (line 1563), causing the call to strcpyW to fail. Of course I have no idea if this is indicative of a larger underlying problem, but tossing in a quick

if (infoPtr->tools[nTool].lpszText == NULL) return 0;

seems to make it work.

wine-bugs＠winehq.org

11 Aug 11 Aug

8:22 a.m.

New subject: [Bug 14790] after full tilt poker upgrade, client crashes randomly

http://bugs.winehq.org/show_bug.cgi?id=14790

Tom Grim elven.thief@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |elven.thief@gmail.com

--- Comment #4 from Tom Grim elven.thief@gmail.com 2008-08-11 03:22:30 --- I did some debugging and tracing on my own after I found myself affected by this bug and can offer a few more tidbits.

Non-Technical details:

The crash consistently happens if you mouse over the players names in a lobby window for a table. Hovering over their name is supposed to give you a tooltip that has their username, home country, chip stack (if the game has started) and any notes that you may have created about that user.

The easiest way to avoid this crash, without fixing the code is to simply not drag your mouse over the user list in a table lobby.

Technical Details:

The crash is happening at line 1563 of TOOLTIPS_GetTextW - it's attempting to copy a unicode string from a null pointer.

How did it get this null pointer? It appears that the tooltip attached to the HWND has no string or no size for that matter.

I modified my copy of TOOLTIPS_AddToolW to figure out what was going on and got this:

trace:tooltips:TOOLTIPS_WindowProc hwnd=0x100fe msg=432 wparam=0 lParam=a1cf80 trace:tooltips:TOOLTIPS_AddToolW add tool (0x100fe) 0x100fa 1064! trace:tooltips:TOOLTIPS_AddToolW The number of Tools of HWND is 1 trace:tooltips:TOOLTIPS_AddToolW lpToolInfo->lpszText = (null) trace:tooltips:TOOLTIPS_AddToolW lpToolInfo->Rect position: 0,0 - 0,0 trace:tooltips:TOOLTIPS_AddToolW add string id 0 trace:tooltips:TOOLTIPS_AddToolW subclassing installed!

Note the "add string id 0" instead of "add text" trace.

The story appears to be that the Full Tilt people are reusing a TOOLINFO structure for the entire player list. When you hover over a players name, it then resizes the tooltip and updates the text to match what I detailed far above. The first time that the tooltip is created, it has absolutely no information, so they load it with null values and zeros.

At some point in their code, they send a TTM_GETTEXTW message when they're about to update the tooltip's dimensions, location, and text. After a small mouse move, I guess they check to see if the tooltip needs moved or the text changed.

Unforunately, on the first iteration of this process, the original TOOLINFO structure with a null string pointer gets called upon and causes the crash.

It appears that Will's quick fix above is the correct fix"

Will's quick fix above appears to be as correct as possible, given that it appears to be "legal" for a tooltip with a

wine-bugs＠winehq.org

8:24 a.m.

New subject: [Bug 14790] after full tilt poker upgrade, client crashes randomly

http://bugs.winehq.org/show_bug.cgi?id=14790

--- Comment #5 from Tom Grim elven.thief@gmail.com 2008-08-11 03:24:15 --- Ignore my last sentence. I didn't catch it below the text box - it should have been deleted.