[Bug 50624] New: Waves Central 12.0.5 fails to start: __call__ pywintypes.error: (1336, 'AddAccesAllowedAce', 'Invalid ACL.')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50624

Bug ID: 50624
           Summary: Waves Central 12.0.5 fails to start: __call__
                    pywintypes.error: (1336, 'AddAccesAllowedAce',
                    'Invalid ACL.')
           Product: Wine
           Version: 6.1
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 69318
  --> https://bugs.winehq.org/attachment.cgi?id=69318
hack

After installing it throws up a message : "Central has encountered a system
permissions issue" 
Below part of the console output

File "pybatch\fileSystemBatchCommands.py", line 646, in __call__
pywintypes.error: (1336, 'AddAccesAllowedAce', 'Invalid ACL.')
[1536] Failed to execute script instl

The attached hack makes the error go away and let`s me reach the login-screen.
Maybe the hack is wrong, i don`t know how to test, but it looks like the error
is coming from the code line

if (!RtlFirstFreeAce(pAcl, &pAceHeader) return STATUS_INVALID_ACL;

because when I change it to return STATUS_INVALID_PARAMATER it stops with:

File "pybatch\fileSystemBatchCommands.py", line 646, in __call__
pywintypes.error: (87, 'AddAccesAllowedAce', 'Invalid parameter.')

After changing it to STATUS_ALLOTTED_SPACE_EXCEEDED the issue is gone, and i
get to the loginscreen

I don`t know how to test returncode, hopefully someone familiar with this piece
of code can pick this up

[Bug 50624] Waves Central 12.0.5 fails to start: __call__ pywintypes.error: (1336, 'AddAccesAllowedAce', 'Invalid ACL.')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50624

--- Comment #1 from Louis Lenders  ---
Created attachment 69572
  --> https://bugs.winehq.org/attachment.cgi?id=69572
little test

This bug is fixed now in Staging. Thanks Alistair.

For completeness I attach little test based on cygwin`s sec_helper.cc for this
bugreport

[Bug 50624] Waves Central 12.0.5 fails to start: __call__ pywintypes.error: (1336, 'AddAccesAllowedAce', 'Invalid ACL.')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50624

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Staged patchset|                            |https://github.com/wine-sta
                   |                            |ging/wine-staging/tree/mast
                   |                            |er/patches/ntdll-RtlFirstFr
                   |                            |eeAce
             Status|NEW                         |STAGED

[Bug 50624] Waves Central 12.0.5 fails to start: __call__ pywintypes.error: (1336, 'AddAccesAllowedAce', 'Invalid ACL.')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50624

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, source, testcase
                 CC|                            |[e-mail]

[Bug 50624] Waves Central 12.0.5 fails to start: __call__ pywintypes.error: (1336, 'AddAccesAllowedAce', 'Invalid ACL.')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50624

--- Comment #2 from Gijs Vermeulen  ---
The staging patchset was upstreamed as:
https://gitlab.winehq.org/wine/wine/-/commit/0cbfd7ab4cd1b4102bfd6204ff4ed64cca8f5b55
https://gitlab.winehq.org/wine/wine/-/commit/0cc26c121831be32bb20092398668f4dfd732327
https://gitlab.winehq.org/wine/wine/-/commit/d70273363be2e2abc5d5af17341a7e6a31156abb

Louis, is this bug fixed now?

[Bug 50624] Waves Central 12.0.5 fails to start: __call__ pywintypes.error: (1336, 'AddAccesAllowedAce', 'Invalid ACL.')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50624

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|STAGED                      |RESOLVED
      Fixed by SHA1|                            |0cc26c121831be32bb200923986
                   |                            |68f4dfd732327

--- Comment #3 from Louis Lenders  ---
(In reply to Gijs Vermeulen from comment #2)
> The staging patchset was upstreamed as:
> https://gitlab.winehq.org/wine/wine/-/commit/
> 0cbfd7ab4cd1b4102bfd6204ff4ed64cca8f5b55
> https://gitlab.winehq.org/wine/wine/-/commit/
> 0cc26c121831be32bb20092398668f4dfd732327
> https://gitlab.winehq.org/wine/wine/-/commit/
> d70273363be2e2abc5d5af17341a7e6a31156abb
>
> Louis, is this bug fixed now?

Yes it`s fixed, tested with Waves Central 13.2.4

Thanks Alistair!

[Bug 50624] Waves Central 12.0.5 fails to start: __call__ pywintypes.error: (1336, 'AddAccesAllowedAce', 'Invalid ACL.')

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50624

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 7.14.