[Bug 56503] New: CryptStringToBinary doesn't adds CR before pad bytes in some cases

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56503

Bug ID: 56503
           Summary: CryptStringToBinary doesn't adds CR before pad bytes
                    in some cases
           Product: Wine
           Version: 9.5
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: crypt32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 76262
  --> https://bugs.winehq.org/attachment.cgi?id=76262
Test program

Both CryptStringToBinaryA and CryptStringToBinaryW don't add CR before pad
bytes in some cases.

Attached the test program.

```
$ x86_64-w64-mingw32-gcc certcat.c -lcrypt32 -o certcat
```

```
$ wine certcat.exe << EOF
> -----BEGIN CERTIFICATE-----

MIICbTCCAhqgAwIBAgIUM7hPfBQsHsiH5ZqG0PbFdVoW4ZwwCgYIKoUDBwEBAwIw
gYwxCzAJBgNVBAYTAlJVMSgwJgYDVQQKDB/QmtC+0LQg0JHQtdC30L7Qv9Cw0YHQ
vdC+0YHRgtC4MRcwFQYDVQQLDA7Qo9GH0LXQsdC90YvQuTEtMCsGA1UEAwwk0KPQ
piDQmtC+0LQg0JHQtdC30L7Qv9Cw0YHQvdC+0YHRgtC4MQswCQYDVQRIDAJjYTAe
Fw0yNDAzMTQwODA0MjFaFw0yNTAzMTQwODA0MjFaMGkxCzAJBgNVBAYTAlJVMRMw
EQYDVQQKEwphZG1pbjUgb3JnMQ8wDQYDVQQDEwZhZG1pbjUxHjAcBgkqhkiG9w0B
CQEWD2FkbWluNUBtYWlsLmNvbTEUMBIGA1UEDRMLYWRtaW41IGRlc2MwZjAfBggq
hQMHAQEBATATBgcqhQMCAiQABggqhQMHAQECAgNDAARAr29PncgHl5lwdTnodkAV
di1Y9L1fMK/aPhlHgQhZkUjEo/tN4jV7t8oXC5HvuIdEXg5zKBJXJy5r3Ty4oESy
9KNvMG0wDAYDVR0TAQH/BAIwADATBgNVHSUEDDAKBggrBgEFBQcDAjAZBgNVHREE
EjAQhg5jNHJvbGU6Ly9hZG1pbjAOBgNVHQ8BAf8EBAMCA+gwHQYDVR0OBBYEFA3/
ThaxrrOT/f2YUOelXyTWuhS2MAoGCCqFAwcBAQMCA0EAlXXYTPuyscXa/yfJnctk
JymI0uyTaXVDmiPrVax/yuF+NNp15KsxMa5P1ckG5iUBopZDyoPjoePQcZkRhhQJ
1w==
-----END CERTIFICATE-----
EOF
-----BEGIN CERTIFICATE-----
MIICbTCCAhqgAwIBAgIUM7hPfBQsHsiH5ZqG0PbFdVoW4ZwwCgYIKoUDBwEBAwIw
gYwxCzAJBgNVBAYTAlJVMSgwJgYDVQQKDB/QmtC+0LQg0JHQtdC30L7Qv9Cw0YHQ
vdC+0YHRgtC4MRcwFQYDVQQLDA7Qo9GH0LXQsdC90YvQuTEtMCsGA1UEAwwk0KPQ
piDQmtC+0LQg0JHQtdC30L7Qv9Cw0YHQvdC+0YHRgtC4MQswCQYDVQRIDAJjYTAe
Fw0yNDAzMTQwODA0MjFaFw0yNTAzMTQwODA0MjFaMGkxCzAJBgNVBAYTAlJVMRMw
EQYDVQQKEwphZG1pbjUgb3JnMQ8wDQYDVQQDEwZhZG1pbjUxHjAcBgkqhkiG9w0B
CQEWD2FkbWluNUBtYWlsLmNvbTEUMBIGA1UEDRMLYWRtaW41IGRlc2MwZjAfBggq
hQMHAQEBATATBgcqhQMCAiQABggqhQMHAQECAgNDAARAr29PncgHl5lwdTnodkAV
di1Y9L1fMK/aPhlHgQhZkUjEo/tN4jV7t8oXC5HvuIdEXg5zKBJXJy5r3Ty4oESy
9KNvMG0wDAYDVR0TAQH/BAIwADATBgNVHSUEDDAKBggrBgEFBQcDAjAZBgNVHREE
EjAQhg5jNHJvbGU6Ly9hZG1pbjAOBgNVHQ8BAf8EBAMCA+gwHQYDVR0OBBYEFA3/
ThaxrrOT/f2YUOelXyTWuhS2MAoGCCqFAwcBAQMCA0EAlXXYTPuyscXa/yfJnctk
JymI0uyTaXVDmiPrVax/yuF+NNp15KsxMa5P1ckG5iUBopZDyoPjoePQcZkRhhQJ1w==
-----END CERTIFICATE-----
```

[Bug 56503] CryptStringToBinary doesn't adds CR before pad bytes in some cases

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56503

--- Comment #1 from Nikolay Sivov  ---
Does it work with current master? There was a fix recently for something
similar
https://source.winehq.org/git/wine.git/commit/624e87a7252abd1f03598c68edc56e....

[Bug 56503] CryptStringToBinary doesn't adds CR before pad bytes in some cases

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56503

--- Comment #2 from Nikolay Sivov  ---
I checked myself, looks like this is the commit that fixed it. Please retest.

[Bug 56503] CryptStringToBinary doesn't adds CR before pad bytes in some cases

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56503

--- Comment #3 from Dmitry Klionsky  ---
It's fixed indeed! Thanks!

[Bug 56503] CryptStringToBinary doesn't adds CR before pad bytes in some cases

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56503

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |624e87a7252abd1f03598c68edc
                   |                            |56e6815af1ef2
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Nikolay Sivov  ---
Marking fixed then, thanks.

[Bug 56503] CryptStringToBinary doesn't adds CR before pad bytes in some cases

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56503

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 9.6.

[Bug 56503] CryptStringToBinary doesn't adds CR before pad bytes in some cases

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56503

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |9.0.x

[Bug 56503] CryptStringToBinary doesn't adds CR before pad bytes in some cases

[WineHQ Bugzilla]

http://bugs.winehq.org/show_bug.cgi?id=56503

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|9.0.x                       |---

--- Comment #6 from Michael Stefaniuc  ---
Removing the 9.0.x milestone from bug fixes included in 9.0.1.