[Bug 8692] Unable to open properties dialog for a shell namespace

http://bugs.winehq.org/show_bug.cgi?id=8692

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                URL|                            |http://www.haage-partner.de
                   |                            |/download.php?file=dopus9
           Keywords|hardware                    |download
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1
           Severity|minor                       |normal

--- Comment #14 from Anastasius Focht  2012-04-07 08:31:27 CDT ---
Hello,

another long-timer here that ought to be fixed ...
The infrastructure to have this work is indeed present in Wine.

"Directory Opus 9" download:
http://www.haage-partner.de/download.php?file=dopus9

"Amiga Explorer" download:
http://dl.cloanto.net/pub/amigaforever/aesetup_x86.msi

The "Amiga Explorer" shell extension is registered and loaded properly but when
you click its namespace "properties" it shows:

--- snip ---
...
002d:trace:shell:ItemMenu_GetCommandString (0x19687b0)->(7013 flags=4 (nil)
name=0xb8fdd6c len=400)
002d:trace:shell:ItemMenu_GetCommandString -- (0x19687b0)->(name=a∩Å)
002d:trace:shell:ItemMenu_InvokeCommand (0x19687b0)->(invcom=0xb8fd9bc
verb=0x7013 wnd=0x30306)
002d:fixme:shell:ItemMenu_InvokeCommand Unhandled Verb 7012l
002d:trace:shell:ContextMenu_Release (0x19687b0)->(0) 
--- snip ---

Source:
http://source.winehq.org/git/wine.git/blob/72a7c34109b9e30cbef4a53a0eb81725d...

--- snip ---
 402 
 403 static HRESULT WINAPI ItemMenu_InvokeCommand(
 404         IContextMenu3 *iface,
 405         LPCMINVOKECOMMANDINFO lpcmi)
 406 {
 407     ContextMenu *This = impl_from_IContextMenu3(iface);
 408 
 409     if (lpcmi->cbSize != sizeof(CMINVOKECOMMANDINFO))
 410         FIXME("Is an EX structure\n");
 411 
 412     TRACE("(%p)->(invcom=%p verb=%p wnd=%p)\n",This,lpcmi,lpcmi->lpVerb,
lpcmi->hwnd);
 413 
 414     if( HIWORD(lpcmi->lpVerb)==0 && LOWORD(lpcmi->lpVerb) >
FCIDM_SHVIEWLAST)
 415     {
 416         TRACE("Invalid Verb %x\n",LOWORD(lpcmi->lpVerb));
 417         return E_INVALIDARG;
 418     }
 419 
 420     if (HIWORD(lpcmi->lpVerb) == 0)
 421     {
 422         switch(LOWORD(lpcmi->lpVerb - This->verb_offset))
 423         {
...
 464         case FCIDM_SHVIEW_PROPERTIES:
 465             TRACE("Verb FCIDM_SHVIEW_PROPERTIES\n");
 466             DoOpenProperties(This, lpcmi->hwnd);
 467             break;
 468         default:
 469             FIXME("Unhandled Verb
%xl\n",LOWORD(lpcmi->lpVerb)-This->verb_offset);
 470             return E_INVALIDARG;
 471         }
 472     }
...
 464         case FCIDM_SHVIEW_PROPERTIES:
 465             TRACE("Verb FCIDM_SHVIEW_PROPERTIES\n");
 466             DoOpenProperties(This, lpcmi->hwnd);
 467             break;
 468         default:
 469             FIXME("Unhandled Verb
%xl\n",LOWORD(lpcmi->lpVerb)-This->verb_offset);
 470             return E_INVALIDARG;
 471         }
 472     }
--- snip ---

FCIDM_SHVIEW_PROPERTIES (0x7013) should be handled here but with verb_offset
(1) it tries to handle 0x7012.

With a proper fix the "Amiga Explorer" shell extension "properties" page is
shown and you can configure various settings (tcp/ip connection).

$ sha1sum DOpus9Install-Deutsch.exe 
77bd4b8baa2d97e9fe21829f0afaf706a58a0d9f  DOpus9Install-Deutsch.exe

$ sha1sum aesetup_x86.msi 
482ffcb9b4442902fd34bbb39a573ea836b5066c  aesetup_x86.msi

$ wine --version
wine-1.5.1-197-g73e7346

Regards