[Bug 39557] New: Dead code in IsDialogMessageW

https://bugs.winehq.org/show_bug.cgi?id=39557

Bug ID: 39557
           Summary: Dead code in IsDialogMessageW
           Product: Wine
           Version: 1.7.54
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

IsDialogMessageW sets dlgCode to 0, then under VK_UP checks if (!(dlgCode &
DLGC_WANTARROWS)). This if statement can never be true.

https://source.winehq.org/git/wine.git/blob/cbaab82d086e36dacaa22c6adf80f911...

[Bug 39557] Dead code in IsDialogMessageW

https://bugs.winehq.org/show_bug.cgi?id=39557

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source
                 CC|                            |[e-mail]

[Bug 39557] Dead code in IsDialogMessageW

https://bugs.winehq.org/show_bug.cgi?id=39557

Carlo Bramini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Carlo Bramini  ---
In my opinion, 'dlgCode' is initialized on top of WM_KEYDOWN, before entering
in the switch() statement related to virtual keys detection.
If I have understood right, this bug is invalid and it should be closed.

[Bug 39557] Dead code in IsDialogMessageW

https://bugs.winehq.org/show_bug.cgi?id=39557

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Alex Henrie  ---
You're right; I misread the code. As of
https://source.winehq.org/git/wine.git/commitdiff/d9c8effbf3555f37bfbb3866b7...
dlgCode is no longer initialized twice, so it's less confusing now.

[Bug 39557] Dead code in IsDialogMessageW

https://bugs.winehq.org/show_bug.cgi?id=39557

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alistair Leslie-Hughes  ---
Closing Invalid.