[Bug 35964] New: gdip_format_string can segfault if format is NULL

http://bugs.winehq.org/show_bug.cgi?id=35964

Bug ID: 35964
           Summary: gdip_format_string can segfault if format is NULL
           Product: Wine
           Version: 1.7.16
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: gdiplus
          Assignee: [e-mail]
          Reporter: [e-mail]

Created attachment 48062
  --> http://bugs.winehq.org/attachment.cgi?id=48062
patch to fix the issue

The parameter format to gdip_format_string can be NULL, but at one point its
attr member is checked without checking it is non-NULL, causing a segfault.
Patch attached.

[Bug 35964] gdip_format_string can segfault if format is NULL

http://bugs.winehq.org/show_bug.cgi?id=35964

--- Comment #1 from Vincent Povirk  ---
Patches aren't picked up from bugzilla. See
http://wiki.winehq.org/SubmittingPatches

[Bug 35964] gdip_format_string can segfault if format is NULL

http://bugs.winehq.org/show_bug.cgi?id=35964

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 35964] gdip_format_string can segfault if format is NULL

https://bugs.winehq.org/show_bug.cgi?id=35964

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Sebastian Lackner  ---
Does this problem still occur? I would assume that its fixed by
http://source.winehq.org/git/wine.git/commit/4def66c11c92fc229cb7e47781dbdad....

[Bug 35964] gdip_format_string can segfault if format is NULL

https://bugs.winehq.org/show_bug.cgi?id=35964

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 35964] gdip_format_string can segfault if format is NULL

https://bugs.winehq.org/show_bug.cgi?id=35964

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |4def66c11c92fc229cb7e47781d
                   |                            |bdadb3c8344ed
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Anastasius Focht  ---
Hello folks,

resolving 'fixed' by commit
https://source.winehq.org/git/wine.git/commitdiff/4def66c11c92fc229cb7e47781...
here unless proven otherwise.

Thanks Vincent

Regards

[Bug 35964] gdip_format_string can segfault if format is NULL

https://bugs.winehq.org/show_bug.cgi?id=35964

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.53.