[Bug 16335] New: winex11.drv/xrender: format not a string literal and no format arguments

http://bugs.winehq.org/show_bug.cgi?id=16335

Summary: winex11.drv/xrender: format not a string literal and no
                    format arguments
           Product: Wine
           Version: 1.1.9
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Keywords: download, patch, source
          Severity: minor
          Priority: P2
         Component: build-env
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=17640)
 --> (http://bugs.winehq.org/attachment.cgi?id=17640)
patch

gcc -c -I. -I. -I../../include -I../../include  -D__WINESRC__  -D_REENTRANT
-fPIC -Wall -pipe -fno-strength-reduce -fno-strict-aliasing
-Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith 
-Werror  -o xrender.o xrender.c
cc1: warnings being treated as errors
xrender.c: In function ‘UploadGlyph’:
xrender.c:750: error: format not a string literal and no format arguments
xrender.c:766: error: format not a string literal and no format arguments
make[2]: *** [xrender.o] Error 1
make[2]: Leaving directory `/home/austin/wine-git/dlls/winex11.drv'
make[1]: *** [winex11.drv] Error 2
make[1]: Leaving directory `/home/austin/wine-git/dlls'
make: *** [dlls] Error 2

Attached patch fixes the issue, but may not be a proper fix.

Only occurs on gcc 4.3+

[Bug 16335] winex11.drv/xrender: format not a string literal and no format arguments

http://bugs.winehq.org/show_bug.cgi?id=16335

--- Comment #1 from Vitaliy Margolen   2008-12-04 20:27:00 ---
The patch is wrong. If you really want to "fix" it that way, the format goes
first:
TRACE("%s", output);

[Bug 16335] winex11.drv/xrender: format not a string literal and no format arguments

http://bugs.winehq.org/show_bug.cgi?id=16335

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Austin English   2008-12-05 12:09:37 ---
Fixed, thanks Vincent!

[Bug 16335] winex11.drv/xrender: format not a string literal and no format arguments

http://bugs.winehq.org/show_bug.cgi?id=16335

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard   2008-12-20 09:06:08 ---
Closing bugs fixed in 1.1.11.