[Bug 56162] New: Alekhine's Gun crashes with 'Assertion failed: node->type == HLSL_IR_CONSTANT'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56162

Bug ID: 56162
           Summary: Alekhine's Gun crashes with 'Assertion failed:
                    node->type == HLSL_IR_CONSTANT'
           Product: vkd3d
           Version: 1.10
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P2
         Component: hlsl
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

04f0:trace:d3dcompiler:D3DCompile data 01513768, data_size 1656, filename
(null), defines 00BD6478, include 00BBFB68, entrypoint "PS", target "ps_2_a",
sflags 0, eflags 0, shader 00D3FBAC, error_messages 00D3FBB0.
04f0:trace:d3dcompiler:D3DCompile2 data 01513768, data_size 1656, filename
(null), macros 00BD6478, include 00BBFB68, entry_point "PS", profile "ps_2_a",
flags 0, effect_flags 0, secondary_flags 0, secondary_data 00000000,
secondary_data_size 0, shader_blob 00D3FBAC, messages_blob 00D3FBB0.
04f0:err:msvcrt:_wassert (L"node->type ==
HLSL_IR_CONSTANT",L"../vkd3d/libs/vkd3d-shader/hlsl.h",922)
04f0:fixme:msvcrt:__clean_type_info_names_internal (1001F054) stub
Assertion failed: node->type == HLSL_IR_CONSTANT, file
../vkd3d/libs/vkd3d-shader/hlsl.h, line 922

Works with native d3dcompiler_47

1.10-118-ge3fb4e7e

[Bug 56162] Alekhine's Gun crashes with 'Assertion failed: node->type == HLSL_IR_CONSTANT'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56162

--- Comment #1 from Nikolay Sivov  ---
Could you please attach the shader?

[Bug 56162] Alekhine's Gun crashes with 'Assertion failed: node->type == HLSL_IR_CONSTANT'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56162

--- Comment #2 from Andrey Gusev  ---
Created attachment 75867
  --> https://bugs.winehq.org/attachment.cgi?id=75867
shader

[Bug 56162] Alekhine's Gun crashes with 'Assertion failed: node->type == HLSL_IR_CONSTANT'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56162

--- Comment #3 from Nikolay Sivov  ---
Created attachment 75868
  --> https://bugs.winehq.org/attachment.cgi?id=75868
backtrace

Attaching backtrace I get locally (it's slightly off with current master). Will
attach a shader too for testing.

[Bug 56162] Alekhine's Gun crashes with 'Assertion failed: node->type == HLSL_IR_CONSTANT'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56162

--- Comment #4 from Nikolay Sivov  ---
Created attachment 75869
  --> https://bugs.winehq.org/attachment.cgi?id=75869
shader

This source was modified to match what application is using for defines. See
commented out ifdef at the beginning.

Francisco, could you take a look? I think you were the last to touch this part
of deref handling.

[Bug 56162] Alekhine's Gun crashes with 'Assertion failed: node->type == HLSL_IR_CONSTANT'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56162

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 56162] Alekhine's Gun crashes with 'Assertion failed: node->type == HLSL_IR_CONSTANT'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56162

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #5 from Nikolay Sivov  ---
I got curious and did a bisect between 1.9 and 1.10:

61a17643a2b27336f997a34642c853b6c3b44f52 is the first bad commit
commit 61a17643a2b27336f997a34642c853b6c3b44f52
Author: Francisco Casas 
Date:   Tue Oct 3 16:47:13 2023 -0300

vkd3d-shader/hlsl: Split deref-offset into a node and a constant uint.

Before that it used to fail properly on unimplemented IR_LOOP for SM1, now it
asserts.

[Bug 56162] Alekhine's Gun crashes with 'Assertion failed: node->type == HLSL_IR_CONSTANT'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56162

Andrey Gusev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Andrey Gusev  ---
Fixed by
https://source.winehq.org/git/vkd3d.git/commit/43ff28b00b2be949cb9f5cb31d28a...

[Bug 56162] Alekhine's Gun crashes with 'Assertion failed: node->type == HLSL_IR_CONSTANT'

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56162

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Nikolay Sivov  ---
Closing bugs fixed in 1.11.