[Bug 23814] New: Enterprise Architect crashes on start in RegisterDragDrop()

http://bugs.winehq.org/show_bug.cgi?id=23814

Summary: Enterprise Architect crashes on start in
                    RegisterDragDrop()
           Product: Wine
           Version: 1.2
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: ole32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
            Blocks: 22860

Created an attachment (id=29877)
 --> (http://bugs.winehq.org/attachment.cgi?id=29877)
log

Application fails to start after this commit:

commit 6d1ef3a6a64f0fabf05ce1bba5f0ec4373684786
Author: Huw Davies 
Date:   Thu Jul 22 13:37:19 2010 +0100

ole32: Implement cross-process drag and drop.

Reverting helps. Attached a +ole,+tid log, please let me know if another one
needed.

[Bug 23814] Enterprise Architect crashes on start in RegisterDragDrop()

http://bugs.winehq.org/show_bug.cgi?id=23814

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://www.sparxsystems.com
                   |                            |.au/bin/easetup.exe

[Bug 23814] Enterprise Architect crashes on start in RegisterDragDrop()

http://bugs.winehq.org/show_bug.cgi?id=23814

--- Comment #1 from Huw Davies   2010-07-28 05:44:51 ---
Created an attachment (id=29881)
 --> (http://bugs.winehq.org/attachment.cgi?id=29881)
Try passing a real IUnknown to CoMarshalInterface

[Bug 23814] Enterprise Architect crashes on start in RegisterDragDrop()

http://bugs.winehq.org/show_bug.cgi?id=23814

--- Comment #2 from Huw Davies   2010-07-28 05:45:30 ---
Please try the attached patch.

[Bug 23814] Enterprise Architect crashes on start in RegisterDragDrop()

http://bugs.winehq.org/show_bug.cgi?id=23814

--- Comment #3 from Nikolay Sivov   2010-07-28 05:56:26 ---
It's fine, thanks. Starts normally with it. Probably it's better to create a
stream after successful QueryInterface to avoid extra release/return.

[Bug 23814] Enterprise Architect crashes on start in RegisterDragDrop()

http://bugs.winehq.org/show_bug.cgi?id=23814

--- Comment #4 from Huw Davies   2010-07-28 06:23:27 ---
Great, thanks for testing.

If I swap the order around then I'd have to release unk if the stream creation
fails, so it's pretty much the same deal.

[Bug 23814] Enterprise Architect crashes on start in RegisterDragDrop()

http://bugs.winehq.org/show_bug.cgi?id=23814

--- Comment #5 from Nikolay Sivov   2010-07-28 06:26:34 ---
(In reply to comment #4)
> If I swap the order around then I'd have to release unk if the stream creation
> fails, so it's pretty much the same deal.

Yeah, sorry. This weather's making a jelly from my brain.

[Bug 23814] Enterprise Architect crashes on start in RegisterDragDrop()

http://bugs.winehq.org/show_bug.cgi?id=23814

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Nikolay Sivov   2010-07-28 10:53:59 ---
Fixed by commit 127260bb628d029c7608e96013bcec207e635249.

[Bug 23814] Enterprise Architect crashes on start in RegisterDragDrop()

http://bugs.winehq.org/show_bug.cgi?id=23814

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard   2010-07-30 12:59:53 ---
Closing bugs fixed in 1.3.0.

[Bug 23814] Enterprise Architect 8.0 crashes on start in RegisterDragDrop()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=23814

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |6d1ef3a6a64f0fabf05ce1bba5f
                   |                            |0ec4373684786
                URL|http://www.sparxsystems.com |https://web.archive.org/web
                   |.au/bin/easetup.exe         |/20101128052357/http://www.
                   |                            |sparxsystems.com.au/bin/eas
                   |                            |etup.exe
      Fixed by SHA1|                            |127260bb628d029c7608e96013b
                   |                            |cec207e635249
            Summary|Enterprise Architect        |Enterprise Architect 8.0
                   |crashes on start in         |crashes on start in
                   |RegisterDragDrop()          |RegisterDragDrop()
                 CC|                            |[e-mail]