https://bugs.winehq.org/show_bug.cgi?id=48972
Bug ID: 48972 Summary: Bugs found by static analyzers Product: Wine Version: 5.6 Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: mikrutrafal54@gmail.com Distribution: ---
Errors found by Cppcheck(unpack and open index.html) - https://gitlab.com/qarmin/wine/-/jobs/513792350/artifacts/download Sonarcloud - https://sonarcloud.io/project/issues?id=qarmin_wine&resolved=false&t...
1. !canonicalized_len should be instead !canonicalized https://github.com/wine-mirror/wine/blob/59987bc9ecdd0dbafd768a95c21a14884bc... should look like https://github.com/wine-mirror/wine/blob/59987bc9ecdd0dbafd768a95c21a14884bc...
2. Should be probably `iter && iter->parent` https://github.com/wine-mirror/wine/blob/59987bc9ecdd0dbafd768a95c21a14884bc...
3. Strange subtracting from itself(but it may want to save style of code) https://github.com/wine-mirror/wine/blob/59987bc9ecdd0dbafd768a95c21a14884bc...
4. pIt may be null in 228 but it is used in 227 https://github.com/wine-mirror/wine/blob/59987bc9ecdd0dbafd768a95c21a14884bc... also here https://github.com/wine-mirror/wine/blob/59987bc9ecdd0dbafd768a95c21a14884bc...
5. jsdisp->ctx == ctx so it can't be jsdisp->ctx != ctx
https://github.com/wine-mirror/wine/blob/59987bc9ecdd0dbafd768a95c21a14884bc...
6. code > 0xffff is always true - probably code > 0 should look like code < 0 https://github.com/wine-mirror/wine/blob/59987bc9ecdd0dbafd768a95c21a14884bc...
https://bugs.winehq.org/show_bug.cgi?id=48972
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dark.shadow4@web.de
--- Comment #1 from Fabian Maurer dark.shadow4@web.de --- Thanks for reporting those, please report each of those issues that you found as separate bugs. That way we can address them one-by-one.
https://bugs.winehq.org/show_bug.cgi?id=48972
Robert Wilhelm sloper42@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sloper42@yahoo.com
--- Comment #2 from Robert Wilhelm sloper42@yahoo.com --- 6. is fixed with commit https://source.winehq.org/git/wine.git/commitdiff/7d48c52816e170eb44dcb64a23... and released in wine-5.18. See https://bugs.winehq.org/show_bug.cgi?id=49172
https://bugs.winehq.org/show_bug.cgi?id=48972
--- Comment #3 from Robert Wilhelm sloper42@yahoo.com --- 1. was fixed by 3cbd9cda195be6afc4290202b6676417812e536b 2. was fixed by d202e4a3864c1f15730e3e3c63e2928e6171c2cb
https://bugs.winehq.org/show_bug.cgi?id=48972
--- Comment #4 from Robert Wilhelm sloper42@yahoo.com --- 4. was fixed by d045eae8b7383fdccfd870bad4c70892b2518e50 and f04976e01da864249884350fec55657cbb39c23e.
https://bugs.winehq.org/show_bug.cgi?id=48972
Robert Wilhelm sloper42@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED
--- Comment #5 from Robert Wilhelm sloper42@yahoo.com --- 3. is intended 5. is fixed in current tree.
Therefore this bug report can be closed.
https://bugs.winehq.org/show_bug.cgi?id=48972
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 9.0-rc1.
-
WineHQ Bugzilla