[Bug 38688] New: Icon overlays not drawn in some cases

https://bugs.winehq.org/show_bug.cgi?id=38688

Bug ID: 38688
           Summary: Icon overlays not drawn in some cases
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

ImageList_DrawIndirect does not draw overlay icons in three cases where the
function is taking a shortcut with "goto end;".

This was tested with ReactOS\base\applications\mscutils\devmgmt_new on ReactOS
which is using comctl32 from wine.

Test results:

in 32bit color no overlay icons are not shown at all.

if (!bMask && (has_alpha || (fState & ILS_ALPHA)))
...
if (bIsTransparent)
 bResult = alpha_blend_image ...
 goto end;

in 16bit Color mode the overlay icons are drawn, but only the part on which the
underlying icon is not transparent (wrong ROP code?)

I don't think this application will work on wine because it relies on setupapi
code which wine will probably does not have.

[Bug 38688] Icon overlays not drawn in some cases

https://bugs.winehq.org/show_bug.cgi?id=38688

--- Comment #1 from Christoph von Wittich  ---
Created attachment 51609
  --> https://bugs.winehq.org/attachment.cgi?id=51609
screenshot with 16 bit color

[Bug 38688] Icon overlays not drawn in some cases

https://bugs.winehq.org/show_bug.cgi?id=38688

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from [e-mail] ---
If you are aware of this issue so well are you able to write a patch for it?

[Bug 38688] Icon overlays not drawn in some cases

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=38688

Casenet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Casenet  ---
If you are aware of this issue so well are you able to write a patch for its
case? - https://casenet.us/

I don't think this application will work on wine because it relies on setupapi
code which wine will probably do not have.