[Bug 57259] New: Keepass 2 automatic update dialog is broken

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57259

Bug ID: 57259
           Summary: Keepass 2 automatic update dialog is broken
           Product: Wine
           Version: 9.18
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 77175
  --> https://bugs.winehq.org/attachment.cgi?id=77175
Screenshot Wine

See screenshots.

[Bug 57259] Keepass 2 automatic update dialog is broken

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57259

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |https://sourceforge.net/pro
                   |                            |jects/keepass/files/KeePass
                   |                            |%202.x/2.57/KeePass-2.57.zi
                   |                            |p/download

[Bug 57259] Keepass 2 automatic update dialog is broken

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57259

--- Comment #1 from Fabian Maurer  ---
Created attachment 77176
  --> https://bugs.winehq.org/attachment.cgi?id=77176
Screenshot Windows

[Bug 57259] Keepass 2 automatic update dialog is broken (uses Taskdialog)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57259

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Keepass 2 automatic update  |Keepass 2 automatic update
                   |dialog is broken            |dialog is broken (uses
                   |                            |Taskdialog)
          Component|-unknown                    |comctl32

--- Comment #2 from Fabian Maurer  ---
Problem is in the line
> taskdialog_get_button_size(dialog_info->command_links[i], dialog_width - x - h_spacing, &size);

It sends the message "BCM_GETIDEALSIZE" which goes down into
"default_window_proc", the message never being handled. So the value for cy
remains 0.

Also, for some reason the buttons don't render as long as they have the
"BS_COMMANDLINK" style.

Zhiyi: Since you made the taskdialog, would you mind taking a look?

[Bug 57259] Keepass 2 automatic update dialog is broken (uses Taskdialog)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57259

--- Comment #3 from Fabian Maurer  ---
I'm pretty sure, the underlying issue is that it uses the user32 button class
instead of the comctl32 button class. Don't know why that would be the case
though...

[Bug 57259] Keepass 2 automatic update dialog is broken (uses Taskdialog)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57259

--- Comment #4 from Zhiyi Zhang  ---
(In reply to Fabian Maurer from comment #3)
> I'm pretty sure, the underlying issue is that it uses the user32 button
> class instead of the comctl32 button class. Don't know why that would be the
> case though...

Probably because the application doesn't call InitCommonControls() so
comctl32.dll is never loaded and the lack of a manifest to enable comctl32.

[Bug 57259] Keepass 2 automatic update dialog is broken (uses Taskdialog)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57259

--- Comment #5 from Zhiyi Zhang  ---
(In reply to Fabian Maurer from comment #2)
> Problem is in the line
> > taskdialog_get_button_size(dialog_info->command_links[i], dialog_width - x - h_spacing, &size);
>
> It sends the message "BCM_GETIDEALSIZE" which goes down into
> "default_window_proc", the message never being handled. So the value for cy
> remains 0.
>
> Also, for some reason the buttons don't render as long as they have the
> "BS_COMMANDLINK" style.
>
> Zhiyi: Since you made the taskdialog, would you mind taking a look?

No problem. I will take a look when I have time.

[Bug 57259] Keepass 2 automatic update dialog is broken (uses Taskdialog)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57259

--- Comment #6 from Nikolay Sivov  ---
This is working correctly if you have .NET installed. With wine-mono is does
miss those buttons. I don't know if there is an easy way to test wine-mono on
Windows, but this is not necessarily a comctl32 issue.

[Bug 57259] Keepass 2 automatic update dialog is broken (uses Taskdialog) EnableVisualStyles() from WinForms evidently doesn't work

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57259

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Keepass 2 automatic update  |Keepass 2 automatic update
                   |dialog is broken (uses      |dialog is broken (uses
                   |Taskdialog)                 |Taskdialog)
                   |                            |EnableVisualStyles() from
                   |                            |WinForms evidently doesn't
                   |                            |work
          Component|comctl32                    |mscoree

[Bug 57259] Keepass 2 automatic update dialog is broken (uses Taskdialog) EnableVisualStyles() from WinForms evidently doesn't work

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57259

Esme Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source
                 CC|                            |[e-mail]