[Bug 13311] New: winetest always fails on shell32:shelllink, but "make test " doesn't

http://bugs.winehq.org/show_bug.cgi?id=13311

Summary: winetest always fails on shell32:shelllink, but "make
                    test" doesn't
           Product: Wine
           Version: CVS/GIT
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: testcases
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Every recent report at http://test.winehq.org
says shell32:shelllink fails, yet "make test" doesn't
show it failing for me.  Is there some timing issue
in winetest?

[Bug 13311] winetest always fails on shell32:shelllink, but "make test" doesn't

http://bugs.winehq.org/show_bug.cgi?id=13311

Paul Vriens  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 13311] winetest always fails on shell32:shelllink, but "make test" doesn't

http://bugs.winehq.org/show_bug.cgi?id=13311

--- Comment #1 from Dan Kegel   2008-05-19 13:29:02 ---
Paul Vriens wrote in wine-devel:

I had a look at this one.

The problem as far as I can see lies with the fact that when we run 'make
shelllink.ok' we eventually end up in UNIXFS_build_shitemid (shfldr_unixfs.c)
where the trace shows:

trace:shell:UNIXFS_build_shitemid
(pszUnixPath="/wine/wine-git/dlls/shell32/tests/shell32_test.exe",
pIDL=0x12793a)

This shell32_test.exe doesn't exist (it's shell32_test.exe.so).

So when you do (in the test directory):

ln -s shell32_test.exe.so shell32_test.exe
rm shelllink.ok
make shelllink.ok

You will see the exact same errors as with winetest.

Winetest unpacks all it's executables in a temp directory and in this case (for
me on the last run) it's showing in the trace:

trace:shell:UNIXFS_build_shitemid
(pszUnixPath="/tmp/wctSkl1EH/shell32_test.exe", pIDL=0x127712)

And that file really exists.

So I guess this issue is with this piece of code in shfldr_unixfs.c:

509     /* We are only interested in regular files and directories. */
 510     if (stat(pszUnixPath, &fileStat)) return NULL;

Now we only need a solution :-)

[Bug 13311] winetest always fails on shell32:shelllink, but "make test" doesn't

http://bugs.winehq.org/show_bug.cgi?id=13311

--- Comment #2 from Paul Vriens   2008-05-19 14:34:15 ---
Patch sent to wine-patches:

http://www.winehq.org/pipermail/wine-patches/2008-May/054987.html

[Bug 13311] winetest always fails on shell32:shelllink, but "make test" doesn't

http://bugs.winehq.org/show_bug.cgi?id=13311

--- Comment #3 from Austin English   2008-05-19 15:19:39 ---
(In reply to comment #2)
> Patch sent to wine-patches:
>
> http://www.winehq.org/pipermail/wine-patches/2008-May/054987.html

Patch is empty.

[Bug 13311] winetest always fails on shell32:shelllink, but "make test" doesn't

http://bugs.winehq.org/show_bug.cgi?id=13311

--- Comment #4 from Paul Vriens   2008-05-20 00:51:37 ---
For some reason patches are split in two in the mailing list (only sometimes).
Try this one:

http://www.winehq.org/pipermail/wine-patches/2008-May/054988.html

[Bug 13311] winetest always fails on shell32:shelllink, but "make test" doesn't

http://bugs.winehq.org/show_bug.cgi?id=13311

--- Comment #5 from Paul Vriens   2008-05-20 01:00:08 ---
Patch is in GIT (modified version).

[Bug 13311] winetest always fails on shell32:shelllink, but "make test" doesn't

http://bugs.winehq.org/show_bug.cgi?id=13311

--- Comment #6 from Paul Vriens   2008-05-21 14:07:25 ---
Can't we close this one? The tests on test.winehq.org don't show any errors
anymore.

[Bug 13311] winetest always fails on shell32:shelllink, but "make test" doesn't

http://bugs.winehq.org/show_bug.cgi?id=13311

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Dan Kegel   2008-05-21 14:22:03 ---
Marking fixed; verified by running dotests.

[Bug 13311] winetest always fails on shell32:shelllink, but "make test" doesn't

http://bugs.winehq.org/show_bug.cgi?id=13311

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #8 from Alexandre Julliard   2008-05-23 10:37:56 ---
Closing bugs fixed in 1.0-rc2.

[Bug 13311] winetest always fails on shell32:shelllink, but "make test" doesn't

http://bugs.winehq.org/show_bug.cgi?id=13311

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified