[Bug 36594] New: valgrind shows uninitialized memory use in windowscodecs/tests/metadata.c

https://bugs.winehq.org/show_bug.cgi?id=36594

Bug ID: 36594
           Summary: valgrind shows uninitialized memory use in
                    windowscodecs/tests/metadata.c
           Product: Wine
           Version: 1.7.19
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: windowscodecs
          Assignee: [e-mail]
          Reporter: [e-mail]

==24667== Conditional jump or move depends on uninitialised value(s)
==24667==    at 0x4CD4D17: winetest_vok (test.h:333)
==24667==    by 0x4CD4E23: winetest_ok (test.h:357)
==24667==    by 0x4CBCD5A: compare_metadata (metadata.c:613)
==24667==    by 0x4CBD126: test_metadata_IFD (metadata.c:694)
==24667==    by 0x4CC3D9B: func_metadata (metadata.c:1784)
==24667==    by 0x4CD57DA: run_test (test.h:584)
==24667==    by 0x4CD5BC9: main (test.h:654)
==24667==  Uninitialised value was created by a client request
==24667==    at 0x7BC4C4D6: mark_block_uninitialized (heap.c:209)
==24667==    by 0x7BC4C641: initialize_block (heap.c:240)
==24667==    by 0x7BC50F4D: RtlAllocateHeap (heap.c:1717)
==24667==    by 0x4E5A55F: LoadIfdMetadata (metadatahandler.c:1129)
==24667==    by 0x4E580FE: MetadataHandler_LoadEx (metadatahandler.c:424)
==24667==    by 0x4CB9EE9: load_stream (wincodecsdk.h:1817)
==24667==    by 0x4CBD05B: test_metadata_IFD (metadata.c:688)
==24667==    by 0x4CC3D9B: func_metadata (metadata.c:1784)
==24667==    by 0x4CD57DA: run_test (test.h:584)
==24667==    by 0x4CD5BC9: main (test.h:654)
==24667==

[Bug 36594] valgrind shows uninitialized memory use in windowscodecs/tests/metadata.c

https://bugs.winehq.org/show_bug.cgi?id=36594

--- Comment #1 from Austin English  ---
Also:

==24667== Conditional jump or move depends on uninitialised value(s)
==24667==    at 0x4CD4C15: winetest_vok (test.h:311)
==24667==    by 0x4CD4E23: winetest_ok (test.h:357)
==24667==    by 0x4CBEFA5: test_metadata_png (metadata.c:940)
==24667==    by 0x4CC3DAA: func_metadata (metadata.c:1787)
==24667==    by 0x4CD57DA: run_test (test.h:584)
==24667==    by 0x4CD5BC9: main (test.h:654)
==24667==  Uninitialised value was created by a stack allocation
==24667==    at 0x4CBEA9E: test_metadata_png (metadata.c:887)
==24667==

[Bug 36594] valgrind shows uninitialized memory use in windowscodecs/tests/metadata.c

https://bugs.winehq.org/show_bug.cgi?id=36594

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 36594] valgrind shows uninitialized memory use in windowscodecs/tests/metadata.c

http://bugs.winehq.org/show_bug.cgi?id=36594

--- Comment #2 from Vincent Povirk  ---
The PNG one is a case where a winapi function is supposed to initialize the
value, but that function isn't implemented yet. We should have the test either
initialize it first, or only check if the function succeeds.

But I don't care much myself because we should just implement the function.

[Bug 36594] valgrind shows uninitialized memory use in windowscodecs/tests/metadata.c

https://bugs.winehq.org/show_bug.cgi?id=36594

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |ca5c0f6b14a7f5774589c4e0dba
                   |                            |602dcf94ca8de
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|---                         |FIXED

--- Comment #3 from Piotr Caban  ---
The valgrind errors are fixed now. Marking as fixed.

[Bug 36594] valgrind shows uninitialized memory use in windowscodecs/tests/metadata.c

https://bugs.winehq.org/show_bug.cgi?id=36594

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.38.