[Bug 27634] New: Freespace 2 does not display screen

http://bugs.winehq.org/show_bug.cgi?id=27634

Summary: Freespace 2 does not display screen
           Product: Wine
           Version: 1.3.23
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-ddraw
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=35329)
 --> (http://bugs.winehq.org/attachment.cgi?id=35329)
Terminal log in 1.3.22

Running the GOG version of Freespace 2 I get to the start screen and it shows
only the text on a black background (terminal log attached).
This screen worked fine in previous wine.
I did a regression test and got

3871329872afe3976e0b2b85330e3a7c47301658 is the first bad commit
commit 3871329872afe3976e0b2b85330e3a7c47301658
Author: Dylan Smith 
Date:   Mon May 23 17:58:36 2011 -0400

ddraw: Avoid clearing some memory unnecessarily.

:040000 040000 f5f1503293dbd4009bf74a1a305d891a52d52d56
94cfffda37433c4168334c01dfdce3f9f773d70d M    dlls

Can't get it to revert tho

[Bug 27634] Freespace 2 does not display screen

http://bugs.winehq.org/show_bug.cgi?id=27634

leighman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]

[Bug 27634] Freespace 2 does not display screen

http://bugs.winehq.org/show_bug.cgi?id=27634

--- Comment #1 from leighman  2011-06-28 05:33:10 CDT ---
A checkout of 3871329872afe3976e0b2b85330e3a7c47301658^ works correctly

[Bug 27634] Freespace 2 does not display screen

http://bugs.winehq.org/show_bug.cgi?id=27634

--- Comment #2 from Dylan Smith  2011-06-28 09:34:01 CDT ---
Created an attachment (id=35333)
 --> (http://bugs.winehq.org/attachment.cgi?id=35333)
ddraw: Attempt to revert change.

Could you see if the attached patch fixes the bug?

[Bug 27634] Freespace 2 does not display screen

http://bugs.winehq.org/show_bug.cgi?id=27634

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from GyB  2011-06-28 10:48:48 CDT ---
Can be reproduced with the demo, too.
http://www.fileplanet.com/126954/120000/fileinfo/Freespace-2-Demo-

Nvidia GeForce 250 / driver 275.09.07

[Bug 27634] Freespace 2 does not display screen

http://bugs.winehq.org/show_bug.cgi?id=27634

Dylan Smith  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #4 from Dylan Smith  2011-06-28 11:45:12 CDT ---
I can confirm the bug with the demo.  The application seems to use a large
dwSize value in DDCAPS, which isn't validated by ddraw.

Patch sent wine-patches that fixes the bug (tested against the demo):
http://www.winehq.org/pipermail/wine-patches/2011-June/103683.html

[Bug 27634] Freespace 2 does not display screen

http://bugs.winehq.org/show_bug.cgi?id=27634

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://www.fileplanet.com/1
                   |                            |26954/120000/fileinfo/Frees
                   |                            |pace-2-Demo
                 CC|                            |[e-mail]

[Bug 27634] Freespace 2 does not display screen

http://bugs.winehq.org/show_bug.cgi?id=27634

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Austin English  2011-06-28 18:53:28 CDT ---
Fixed by
http://source.winehq.org/git/wine.git/commitdiff/ced4c383241a1069eca094408d2...

[Bug 27634] Freespace 2 does not display screen

http://bugs.winehq.org/show_bug.cgi?id=27634

--- Comment #6 from leighman  2011-06-29 04:54:22 CDT ---
Thanks :D

[Bug 27634] Freespace 2 does not display screen

http://bugs.winehq.org/show_bug.cgi?id=27634

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2011-07-08 13:47:25 CDT ---
Closing bugs fixed in 1.3.24.

[Bug 27634] Freespace 2 does not display screen

http://bugs.winehq.org/show_bug.cgi?id=27634

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-ddraw               |directx-d3d

[Bug 27634] Freespace 2 does not display screen

http://bugs.winehq.org/show_bug.cgi?id=27634

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |ced4c383241a1069eca094408d2
                   |                            |88fbc3784c094
    Regression SHA1|                            |3871329872afe3976e0b2b85330
                   |                            |e3a7c47301658