[Bug 44294] New: Possible access to unintended macro in "wine/dlls/ comdlg32/fontdlg.c" line 592

https://bugs.winehq.org/show_bug.cgi?id=44294

Bug ID: 44294
           Summary: Possible access to unintended macro in
                    "wine/dlls/comdlg32/fontdlg.c" line 592
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comdlg32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

While experimenting with a CodeSonar plugin we develop, we noticed a
potential bug in file "wine/dlls/comdlg32/fontdlg.c" line 592, function
CFn_FitCharSet

SendDlgItemMessageW(hDlg, cmb5, CB_SETCURSEL, i, 0);
SendMessageW(hDlg, WM_COMMAND, MAKEWPARAM(cmb5, CBN_SELCHANGE),
     (LPARAM)GetDlgItem(hDlg,cmb2)); //HERE
return TRUE;

Is it correct to use cmb2 in that line? Or cmb5 should have been used instead?
Similar in line 599. Or, there might be some kind of relation between cmd5 and
cmd2 (that is not clear to me)?

Thanks,
Petru Florin Mihancea

[Bug 44294] Possible access to unintended macro in "wine/dlls/comdlg32/ fontdlg.c" line 592

https://bugs.winehq.org/show_bug.cgi?id=44294

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |77d65c39486ffc2b4c17aec958e
                   |                            |361b180a029a1
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Alexandre Julliard  ---
Yes that's a mistake, though it doesn't make any difference given how the code
uses it. Still, it's fixed by 77d65c39486ffc2b4c17aec958e361b180a029a1. Thanks!

[Bug 44294] Possible access to unintended macro in "wine/dlls/comdlg32/ fontdlg.c" line 592

https://bugs.winehq.org/show_bug.cgi?id=44294

--- Comment #2 from Petru-Florin Mihancea  ---
Could you please explain to us briefly why the expected behaviour is not
influenced by these mistakes :) ?

[Bug 44294] Possible access to unintended macro in "wine/dlls/comdlg32/ fontdlg.c" line 592

https://bugs.winehq.org/show_bug.cgi?id=44294

--- Comment #3 from Alexandre Julliard  ---
We don't use the lparam in the dialog procedure, and all notifications trigger
the same code path anyway.

[Bug 44294] Possible access to unintended macro in "wine/dlls/comdlg32/ fontdlg.c" line 592

https://bugs.winehq.org/show_bug.cgi?id=44294

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 3.1.