[Bug 17263] New: surpriiise! :) missing expectation of ERROR_MORE_DATA status code in rpcrt4_conn_np_read
http://bugs.winehq.org/show_bug.cgi?id=17263
Summary: surpriiise! :) missing expectation of ERROR_MORE_DATA status code in rpcrt4_conn_np_read Product: Wine Version: unspecified Platform: Other OS/Version: other Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: rpc AssignedTo: wine-bugs@winehq.org ReportedBy: lkcl@lkcl.net
Created an attachment (id=19252) --> (http://bugs.winehq.org/attachment.cgi?id=19252) allow ERROR_MORE_DATA status codes
oh look! when ReadFile starts returning ERROR_MORE_DATA status codes, guess what! rpcrt4_conn_np_read() fails because ERROR_MORE_DATA is an allowed / expected status code :)
it's likely that there are going to be more of these needed, sprinkled liberally throughout wine.
#17195 depends on this expected behaviour.
http://bugs.winehq.org/show_bug.cgi?id=17263
Luke Kenneth Casson Leighton lkcl@lkcl.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17195
http://bugs.winehq.org/show_bug.cgi?id=17263
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|surpriiise! :) missing |missing expectation of |expectation of |ERROR_MORE_DATA status code |ERROR_MORE_DATA status code |in rpcrt4_conn_np_read |in rpcrt4_conn_np_read |
http://bugs.winehq.org/show_bug.cgi?id=17263
--- Comment #1 from Luke Kenneth Casson Leighton lkcl@lkcl.net 2009-02-05 09:02:14 --- aww, okaay, let's have sensible bug titles ha ha :)
http://bugs.winehq.org/show_bug.cgi?id=17263
--- Comment #2 from Luke Kenneth Casson Leighton lkcl@lkcl.net 2009-02-06 04:48:49 --- [posted to wine-patches]
this is the first and most immediate of the uses of ReadFile on message-mode named pipes which needs attention. when ReadFile begins to [correctly] return ERROR_MORE_DATA on short reads, rpcrt4_conn_np_read() erroneously fails. this causes wine to immediately bomb out on the very first MSRPC interaction, which happens to be a svcctl operation on wine start-up.
there are _going_ to be more of these, and a thorough audit should be carried out of all uses of message-mode named pipes in wine to ensure that the status code ERROR_MORE_DATA is accepted.
http://bugs.winehq.org/show_bug.cgi?id=17263
Juan Lang juan_lang@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever Confirmed|0 |1
--- Comment #3 from Juan Lang juan_lang@yahoo.com 2009-02-06 17:30:44 --- I sent my shorter patch: http://www.winehq.org/pipermail/wine-patches/2009-February/069080.html
http://bugs.winehq.org/show_bug.cgi?id=17263
Juan Lang juan_lang@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #4 from Juan Lang juan_lang@yahoo.com 2009-02-09 11:39:34 --- This one's now fixed.
http://bugs.winehq.org/show_bug.cgi?id=17263
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #5 from Alexandre Julliard julliard@winehq.org 2009-02-13 11:11:30 --- Closing bugs fixed in 1.1.15.
-
wine-bugs＠winehq.org