[Bug 57179] New: Since Wine 7.5, file uploads in Hotline Client 1.2.3 hang after about 200 KB

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57179

Bug ID: 57179
           Summary: Since Wine 7.5, file uploads in Hotline Client 1.2.3
                    hang after about 200 KB
           Product: Wine
           Version: 9.17
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wineserver
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

I was uploading a file to a Hotline server from the Hotline client (1990s BBS
software used mostly on Macs) using recent versions of Wine, all the way up to
9.17 and noticed that uploads greater than about 200KB will not complete
successfully.

I found that this is working properly in wine 7.4 and earlier and I think I've
narrowed the cause down to the commit
https://gitlab.winehq.org/wine/wine/-/commit/1c6c90c7e1f1cd011e0ddb1dba47719...
. Though I'm not knowledgeable enough about wine's implementation to fix the
problem, I tested with the latest code in 64-bit mode, and if I just set
reply->nonblocking = FALSE at
https://gitlab.winehq.org/wine/wine/-/blob/6dfb84f5cbdf30c1dc0775fd4dae821ee...
the upload will succeed but obviously the client application UI will be
unresponsive while that happens.

The windows versions of the Hotline client and server are downloadable from
https://preterhuman.net/gethotlinekdx.php

[Bug 57179] Since Wine 7.5, file uploads in Hotline Client 1.2.3 hang after about 200 KB

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57179

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |1c6c90c7e1f1cd011e0ddb1dba4
                   |                            |7719d61d78fb2
                 CC|                            |[e-mail]

[Bug 57179] Since Wine 7.5, file uploads in Hotline Client 1.2.3 hang after about 200 KB

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57179

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]     |[e-mail]
                URL|                            |https://preterhuman.net/get
                   |                            |hotlinekdx.php
           Keywords|                            |download, regression

--- Comment #1 from Ken Sharp  ---
> server: Defer clearing events until async is completed in send_socket handler.

[Bug 57179] Since Wine 7.5, file uploads in Hotline Client 1.2.3 hang after about 200 KB

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57179

--- Comment #2 from [e-mail] ---
I tried https://gitlab.winehq.org/wine/wine/-/merge_requests/6490 and it fixes
the problem for me.

[Bug 57179] Since Wine 7.5, file uploads in Hotline Client 1.2.3 hang after about 200 KB

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57179

--- Comment #3 from Jinoh Kang  ---
That's interesting. Perhaps the event clear should happen as soon as we call
set_async_direct_result.

(In reply to winehq from comment #2)
> I tried https://gitlab.winehq.org/wine/wine/-/merge_requests/6490 and it
> fixes the problem for me.

If it works then that's a good news. I doubt it's the most reliable solution
for this bug, though.

[Bug 57179] Since Wine 7.5, file uploads in Hotline Client 1.2.3 hang after about 200 KB

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57179

--- Comment #4 from Jinoh Kang  ---
(In reply to winehq from comment #2)
> I tried https://gitlab.winehq.org/wine/wine/-/merge_requests/6490 and it
> fixes the problem for me.

This is merged. Should we mark this fixed then?

[Bug 57179] File uploads in Hotline Client 1.2.3 hang after about 200 KB

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57179

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
            Version|9.17                        |7.5
            Summary|Since Wine 7.5, file        |File uploads in Hotline
                   |uploads in Hotline Client   |Client 1.2.3 hang after
                   |1.2.3 hang after about 200  |about 200 KB
                   |KB                          |
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |535c8a84c1ec4391786d8be6f87
                   |                            |d683e20223b12

--- Comment #5 from Gijs Vermeulen  ---
Reported FIXED by merged PR #6490. Feel free to reopen if you can still
reproduce.

[Bug 57179] File uploads in Hotline Client 1.2.3 hang after about 200 KB

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=57179

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 10.0-rc6.