http://bugs.winehq.org/show_bug.cgi?id=14248
Summary: CTRL + Tab in Firefox is intepreted as CTRL + B (dogfood) Product: Wine Version: 1.1.0 Platform: PC URL: http://www.mozilla.com/en-US/firefox/ OS/Version: Linux Status: NEW Keywords: download Severity: minor Priority: P2 Component: winex11.drv AssignedTo: wine-bugs@winehq.org ReportedBy: austinenglish@gmail.com
Finally got through my 1609 page wikisurf, so now I've made Windows Firefox my default browser. Disappointingly, CTRL + Tab brings up the bookmark toolbar (same as CTRL + B). Interestingly, CTRL + Shift + Tab does nothing, instead of bringing up the bookmark library. Either way, very annoying, especially for tab whores such as myself.
http://bugs.winehq.org/show_bug.cgi?id=14248
--- Comment #1 from Lei Zhang thestig@google.com 2008-07-08 19:43:17 --- which version of firefox?
http://bugs.winehq.org/show_bug.cgi?id=14248
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|CTRL + Tab in Firefox is |CTRL + Tab in Firefox 3 is |intepreted as CTRL + B |intepreted as CTRL + B |(dogfood) |(dogfood)
--- Comment #2 from Austin English austinenglish@gmail.com 2008-07-09 04:48:54 --- (In reply to comment #1)
which version of firefox?
Firefox 3.0, en-us
http://bugs.winehq.org/show_bug.cgi?id=14248
Andre Wisplinghoff andre.wisplinghoff@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |andre.wisplinghoff@gmail.com
--- Comment #3 from Andre Wisplinghoff andre.wisplinghoff@gmail.com 2008-07-29 08:57:03 --- Wine's TranslateMessage function creates a WM_CHAR message with the same control key code as CTRL + I for CTRL + Tab at the moment (0x9). If a WM_CHAR message is send depends on what ToUnicode function returns. I've sent in a test and fix to make wine do the same as windows (tested on Vista).
This fixes firefox behaviour for me.
http://www.winehq.org/pipermail/wine-patches/2008-July/058745.html (Test) http://www.winehq.org/pipermail/wine-patches/2008-July/058746.html (Fix)
http://bugs.winehq.org/show_bug.cgi?id=14248
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch, testcase
--- Comment #4 from Austin English austinenglish@gmail.com 2008-08-04 10:40:13 --- (In reply to comment #3)
Wine's TranslateMessage function creates a WM_CHAR message with the same control key code as CTRL + I for CTRL + Tab at the moment (0x9). If a WM_CHAR message is send depends on what ToUnicode function returns. I've sent in a test and fix to make wine do the same as windows (tested on Vista).
This fixes firefox behaviour for me.
http://www.winehq.org/pipermail/wine-patches/2008-July/058745.html (Test) http://www.winehq.org/pipermail/wine-patches/2008-July/058746.html (Fix)
Patch works here as well. Might resubmit it to wine-patches and ask for comments, not sure why it wasn't accepted...
http://bugs.winehq.org/show_bug.cgi?id=14248
--- Comment #5 from Andre Wisplinghoff andre.wisplinghoff@gmail.com 2008-08-05 07:26:03 --- I got some feedback, wrapping was wrong with original patches. Paul Vriens had some suggestions, too. I implemented those now and resubmitted the two patches.
http://bugs.winehq.org/show_bug.cgi?id=14248
--- Comment #6 from Austin English austinenglish@gmail.com 2009-02-07 03:02:45 --- Still present in git.
http://bugs.winehq.org/show_bug.cgi?id=14248
Emil Andersson emil.jo.andersson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |emil.jo.andersson@gmail.com
--- Comment #7 from Emil Andersson emil.jo.andersson@gmail.com 2009-03-07 04:41:24 --- Until in stable and included in your distro of choice, you can use Ctrl+PgUp and Ctrl+PgDn to switch tabs (Ubuntu 8.10, Wine 1.0.1 and Firefox 3.0.7).
http://bugs.winehq.org/show_bug.cgi?id=14248
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de
--- Comment #8 from André H. nerv@dawncrow.de 2009-05-23 04:55:11 --- in my german firefox 3.5 beta 4 it shows up bookmark library, too. so patch might not be commited yet. Andre Wisplinghoff, if its ok i would have a look at it.
http://bugs.winehq.org/show_bug.cgi?id=14248
--- Comment #9 from Andre Wisplinghoff andre.wisplinghoff@gmail.com 2009-05-23 08:55:45 --- (In reply to comment #8)
in my german firefox 3.5 beta 4 it shows up bookmark library, too. so patch might not be commited yet. Andre Wisplinghoff, if its ok i would have a look at it.
Of course, have fun :)
http://bugs.winehq.org/show_bug.cgi?id=14248
--- Comment #10 from André H. nerv@dawncrow.de 2009-05-28 10:35:38 --- there was a commit today which fixed the ctrl+tab (forward). Andre Wisplinghoff, if you got time, just fresh up your code and try again. if its not commited, try asking julliard
http://bugs.winehq.org/show_bug.cgi?id=14248
--- Comment #11 from Andre Wisplinghoff andre.wisplinghoff@gmail.com 2009-05-28 12:23:01 --- sry, I am too busy at the moment. I'm also a bit disappointed that you often don't even get an short response why a patch isn't accepted after you've spent hours trying to make it work well.
http://bugs.winehq.org/show_bug.cgi?id=14248
--- Comment #12 from André H. nerv@dawncrow.de 2009-05-28 13:02:08 --- i understand you. so i will continue on it. even reusing your code?
http://bugs.winehq.org/show_bug.cgi?id=14248
--- Comment #13 from Andre Wisplinghoff andre.wisplinghoff@gmail.com 2009-05-28 18:57:24 --- yeah np you can use it if you want to.
http://bugs.winehq.org/show_bug.cgi?id=14248
Adys adys.wh+winehqdotorg@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh+winehqdotorg@gmail. | |com
--- Comment #14 from Adys adys.wh+winehqdotorg@gmail.com 2009-05-28 22:18:43 --- (In reply to comment #12)
i understand you. so i will continue on it. even reusing your code?
The patch was committed yesterday.
http://bugs.winehq.org/show_bug.cgi?id=14248
Dmitry Timoshkov dmitry@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #15 from Dmitry Timoshkov dmitry@codeweavers.com 2009-05-29 00:49:04 --- Should be fixed now.
http://bugs.winehq.org/show_bug.cgi?id=14248
--- Comment #16 from Austin English austinenglish@gmail.com 2009-05-29 01:06:31 --- (In reply to comment #15)
Should be fixed now.
Yes, it is. Though, CTRL+Shift+Tab is still broken.
http://bugs.winehq.org/show_bug.cgi?id=14248
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #17 from Alexandre Julliard julliard@winehq.org 2009-06-05 12:41:21 --- Closing bugs fixed in 1.1.23.
https://bugs.winehq.org/show_bug.cgi?id=14248
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |cc688148acef8d636bdaaa4e6ed | |e264657364c36
-
wine-bugs＠winehq.org