[Bug 12781] New: Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

Summary: Dungeon Siege graphics problems since removing the pixel
                    format limitation
           Product: Wine
           Version: 0.9.60
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: major
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Tested with most recent release as well as git version. As of wine 0.9.57,
Dungeon Siege does not display the main menu correctly (there's some shadow
effect which appears above all the buttons rather than below) and in game, all
the 3D elements are not properly clipped based on point of view.

This is directly related to the following patch which I used as git bisect to
narrow down to.

8293a9ead0ddbc40be62815f0f0823356665b3dc is first bad commit
commit 8293a9ead0ddbc40be62815f0f0823356665b3dc
Author: Roderick Colenbrander 
Date:   Fri Feb 22 20:40:00 2008 +0000

wgl: Remove the pixel format limitation.

:040000 040000 d94457c21cbd39fefc97b82da4d94349358ad70d
6f47946106e17f0167e5916e88baa2aefa282cc1 M      dlls

I am unsure as to whether this is a problem with Xorg 7.3 (server 1.4), my
Intel card using driver 2.2.1, the game itself, or wine.

I do know that I can play Neverwinter Nights natively (linux client) and it
uses OpenGL and 3D without any visual problems. As well, running Half-Life 1
via Steam.exe works and no issues in game. All using wine 0.9.60.

I am willing to try additional things to find the problem as the game is quite
unplayable since removing the pixel format limitation.

[Bug 12781] Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

--- Comment #1 from Roderick B. Greening   2008-04-24 17:53:51 ---
Created an attachment (id=12448)
 --> (http://bugs.winehq.org/attachment.cgi?id=12448)
Trace for wgl and ddraw

Attached log file was generated from wine-git using the wgl patch that removed
the pixel format limitation.

Hopefully it will help in tracking down the problem.

[Bug 12781] Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

Roderick B. Greening  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12448|text/plain                  |application/octet-stream
          mime type|                            |

[Bug 12781] Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

--- Comment #2 from Roderick Colenbrander   2008-04-25 01:07:12 ---
Try to make a similar log using a wine version without that patch and also
attach your glxinfo output.

[Bug 12781] Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

--- Comment #3 from Roderick B. Greening   2008-04-25 07:14:03 ---
Created an attachment (id=12460)
 --> (http://bugs.winehq.org/attachment.cgi?id=12460)
output of LIBGL_DEBUG=verbose glxinfo &> glxinfo.log

Attached a log of my glxinfo.

[Bug 12781] Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

--- Comment #4 from Roderick B. Greening   2008-04-25 07:57:33 ---
Created an attachment (id=12461)
 --> (http://bugs.winehq.org/attachment.cgi?id=12461)
Trace for wgl and ddraw using 0.9.56

Attached log file was generated from wine-0.9.56 before the 'remove pixel
format limitation' patch was added.

[Bug 12781] Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

--- Comment #5 from Roderick B. Greening   2008-04-25 08:12:56 ---
I just ran a quick diff between the logs searching for the major differences...
here's what I see as suspicious. In the pre-patch, it chooses pixel format 1 as
fmt_id 0x25 while in the patched, it chooses fmt_id 0x23.

This is the first indication of a change between the working and non-working
game.

Then there's this:

-trace:wgl:ConvertAttribWGLtoGLX pAttr[11] = GLX_BUFFER_SIZE: 24
+trace:wgl:ConvertAttribWGLtoGLX pAttr[11] = GLX_BUFFER_SIZE: 32

and this:

-trace:wgl:ConvertAttribWGLtoGLX pAttr[19] = GLX_ALPHA_SIZE: 0
+trace:wgl:ConvertAttribWGLtoGLX pAttr[19] = GLX_ALPHA_SIZE: 8

Which probably points to the alpha issues I am seeing (i.e. no proper clipping
or transparency alphas).

[Bug 12781] Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

--- Comment #6 from Roderick B. Greening   2008-04-25 09:18:40 ---
Here are the Direct3D registry keys if have set...

"DirectDrawRenderer"="opengl"
 "OffscreenRenderingMode"="backbuffer"
 "RenderTargetLockMode"="auto"
 "UseGLSL"="enabled"
 "VideoMemorySize"="256"

I have tried various other options with no success.

[Bug 12781] Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |normal
           Keywords|                            |regression

--- Comment #7 from Lei Zhang   2008-04-25 12:24:25 ---
severity is not major.

[Bug 12781] Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

--- Comment #8 from Roderick Colenbrander   2008-05-01 13:40:30 ---
It sounds like a flag isn't set properly in ddraw or so causing no alpha.
Before we had only a single format and we always asked to have alpha on it.

[Bug 12781] Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

--- Comment #9 from Roderick Colenbrander   2008-05-01 16:24:56 ---
It seems to lack depth, I'm figuring out what causes it now.

[Bug 12781] Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

--- Comment #10 from Roderick Colenbrander   2008-05-01 16:48:11 ---
I have submitted a patch to wine-patches, basically ddraw was asking for a
16-bit depth buffer (in AutoDepthStencilFormat) but WineD3D didn't use it
because ddraw wasn't setting EnableAutoDepthStencil to TRUE.

[Bug 12781] Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

Roderick Colenbrander  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #11 from Roderick Colenbrander   2008-05-02 07:18:49 ---
The patch is in git.

[Bug 12781] Dungeon Siege graphics problems since removing the pixel format limitation

http://bugs.winehq.org/show_bug.cgi?id=12781

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #12 from Alexandre Julliard   2008-05-02 12:38:08 ---
Closing bugs fixed in 0.9.61.