[Bug 15359] New: wcmd: msysgit does not work

http://bugs.winehq.org/show_bug.cgi?id=15359

Summary: wcmd: msysgit does not work
           Product: Wine
           Version: CVS/GIT
          Platform: Other
        OS/Version: other
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

I'm trying to use msysgit from here

http://msysgit.googlecode.com/files/Git-1.6.0.2-preview20080921.exe

it installs just fine, but git itself does not run:

Z:\home\kirr\tmp\trashme\msysgit>git
  fixme:cmd:WCMD_for /F needs to handle options
  Syntax error
  File not found

it seems it wants that /F to be implemented.

Thanks beforehand.

[Bug 15359] wcmd: msysgit does not work

http://bugs.winehq.org/show_bug.cgi?id=15359

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 15359] wcmd: msysgit does not work

http://bugs.winehq.org/show_bug.cgi?id=15359

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://msysgit.googlecode.co
                   |                            |m/files/Git-1.6.0.2-
                   |                            |preview20080921.exe
           Keywords|                            |source

--- Comment #1 from Lei Zhang   2008-09-28 15:17:28 ---
When you installed it, which option did you pick:

- use git bash only
- run git from the windows command prompt
- run git and includeunix tools from the windows command prompt

[Bug 15359] wcmd: msysgit does not work

http://bugs.winehq.org/show_bug.cgi?id=15359

--- Comment #2 from Lei Zhang   2008-09-28 15:20:26 ---
Also, what exact version of Wine are you using? It seems to work for me.

[Bug 15359] wcmd: msysgit does not work

http://bugs.winehq.org/show_bug.cgi?id=15359

--- Comment #3 from Kirill Smelkov   2008-09-29 09:09:41 ---
I use wine from git:

kirr@tugrik2:~/src/tools/wine/wine$ git describe 
wine-1.1.5-207-gc425c8a

kirr@tugrik2:~/src/tools/wine/wine$ git log -1 c425c8a
commit c425c8a406669fc203a8f77ca3be5216fa4e4160
Author: Andrey Turkin 
Date:   Tue Sep 23 21:12:19 2008 +0400

ntdll: Add stubbed implementations for NtQueryEaFile and NtSetEaFile.

and I choose:

- run git from the windows command prompt

and problem still persists.

[Bug 15359] wcmd: msysgit does not work

http://bugs.winehq.org/show_bug.cgi?id=15359

--- Comment #4 from Lei Zhang   2008-09-29 15:04:44 ---
This is what I got:

thestig@stumpy:~/.wine/drive_c/Program Files/Git/bin$ wine cmd
fixme:ntoskrnl:KeInitializeSpinLock 0x457a04
CMD Version 1.1.5

C:\Program Files\Git\bin>git
usage: git ...

The most commonly used git commands are:
   add        Add file contents to the index
...

[Bug 15359] wcmd: msysgit does not work

http://bugs.winehq.org/show_bug.cgi?id=15359

--- Comment #5 from Kirill Smelkov   2008-09-30 00:34:31 ---
That's because you've cd'ed to C:\Program Files\Git\bin -- so you run git.exe

try doing this:

kirr@tugrik2:~/tmp/trashme/msysgit$ LANG=C wine cmd
CMD Version 1.1.5

Z:\home\kirr\tmp\trashme\msysgit>c:
C:>git
fixme:cmd:WCMD_for /F needs to handle options
Syntax error
File not found

C:>cd Program\ Files
Path not found

C:>dir
Volume in drive C is 
Volume Serial Number is 0000-0000

Directory of C:\

9/29/2008   6:04 PM  <DIR>         Program Files
 9/29/2008   5:44 PM  <DIR>         windows
       0 files                        0 bytes
       2 directories     29,184,651,264 bytes free

C:>cd "Program Files"
C:\Program Files>cd Git\bin
C:\Program Files\Git\bin>git
usage: git [--version] [--exec-path[=GIT_EXEC_PATH]] [-p|--paginate|--no-pager]
[--bare] [--git-dir=GIT_DIR] [--work-tree=GIT_WORK_TREE] [--help] COMMAND
[ARGS]

The most commonly used git commands are:
   add        Add file contents to the index
   bisect     Find the change that introduced a bug by binary search
   branch     List, create, or delete branches
   checkout   Checkout a branch or paths to the working tree
   clone      Clone a repository into a new directory
   commit     Record changes to the repository
   diff       Show changes between commits, commit and working tree, etc
   fetch      Download objects and refs from another repository
   grep       Print lines matching a pattern
   init       Create an empty git repository or reinitialize an existing one
   log        Show commit logs
   merge      Join two or more development histories together
   mv         Move or rename a file, a directory, or a symlink
   pull       Fetch from and merge with another repository or a local branch
   push       Update remote refs along with associated objects
   rebase     Forward-port local commits to the updated upstream head
   reset      Reset current HEAD to the specified state
   rm         Remove files from the working tree and from the index
   show       Show various types of objects
   status     Show the working tree status
   tag        Create, list, delete or verify a tag object signed with GPG

See 'git help COMMAND' for more information on a specific command.

[Bug 15359] wcmd: msysgit does not work

http://bugs.winehq.org/show_bug.cgi?id=15359

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #6 from Lei Zhang   2008-09-30 14:07:10 ---
Ok, I see it now. Confirming, but I'll check on Windows and make sure it's not
a problem there.

[Bug 15359] wcmd: msysgit does not work

http://bugs.winehq.org/show_bug.cgi?id=15359

--- Comment #7 from Kirill Smelkov   2008-10-01 03:00:27 ---
Thanks for the confirmation.

I've checked it on Windows XP and git.bat works there.

[Bug 15359] wcmd: msysgit does not work

http://bugs.winehq.org/show_bug.cgi?id=15359

Lei Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |programs
            Version|CVS/GIT                     |1.1.5

--- Comment #8 from Lei Zhang   2008-10-01 13:15:12 ---
Looks like Wine's cmd needs a bit more work. Maybe Jason Edmeades can help you
out here.

[Bug 15359] wcmd: msysgit does not work (WCMD_for /F needs to handle options)

http://bugs.winehq.org/show_bug.cgi?id=15359

Kirill Smelkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|wcmd: msysgit does not work |wcmd: msysgit does not work
                   |                            |(WCMD_for /F needs to
                   |                            |handle options)

[Bug 15359] wcmd: msysgit does not work (WCMD_for /F needs to handle options)

http://bugs.winehq.org/show_bug.cgi?id=15359

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Dan Kegel   2009-08-18 15:21:51 ---
This also affects Firefox's build system.
http://kegel.com/wine/firefox-download-and-build.sh.txt
shows one way to build Firefox in Windows or Wine.
It currently fails while running guess-msvc.bat.
(Can't find it online, so I'll attach it.  Older version at
http://people.mozilla.com/~beltzner/guess-msvc-v2.bat )
It has sections like:

REG QUERY "%MSVC6KEY%" /v ProductDir >nul 2>nul
if "%VC6DIR%"=="" (
  IF %ERRORLEVEL% EQU 0 (
    FOR /F "tokens=2* delims=     " %%A IN ('REG QUERY "%MSVC6KEY%" /v
ProductDir') DO SET VC6DIR=%%B
  )
)

[Bug 15359] cmd's "for": msysgit does not work (WCMD_for /F needs to handle options)

http://bugs.winehq.org/show_bug.cgi?id=15359

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|wcmd: msysgit does not work |cmd's "for": msysgit does
                   |(WCMD_for /F needs to       |not work (WCMD_for /F needs
                   |handle options)             |to handle options)

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|cmd's "for": msysgit does   |cmd's "for" command doesn't
                   |not work (WCMD_for /F needs |handle /F.  Breaks msysgit,
                   |to handle options)          |firefox build.

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from [e-mail]  2009-08-20 13:32:59 ---
Blocks bug #14545 as well.

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |14545

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from André H.   2009-08-22 05:40:58 ---
the failing line in git.cmd is:

@for /F "delims=" %%I in ("%~dp0..") do @set git_install_root=%%~fI

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

--- Comment #12 from Dan Kegel   2009-12-17 03:47:53 ---
filed separate bugs for extra issues noted in comment #9 :
bug 21046 : cmd does not handle equ operator in 'if' command
bug 21047 : cmd does not handle for %%a in ('command')

hmm.  I bet we need a clean parser for cmd.

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

--- Comment #13 from Dan Kegel   2009-12-23 20:42:57 ---
For completeness, here's the text of git.cmd:

@set PLINK_PROTOCOL=ssh
@setlocal
@for /F "delims=" %%I in ("%~dp0..") do @set git_install_root=%%~fI
@set path=%git_install_root%\bin;%git_install_root%\mingw\bin;%PATH%
@if "%HOME%"=="" @set HOME=%USERPROFILE%
@if "%1"=="gui" @goto gui
:default
@git.exe %*
@exit /b %ErrorLevel%
:gui
@if "%2"=="citool" @goto default
@start wish.exe "%git_install_root%\libexec\git-core\git-gui" -- %2 %3 %4 %5 %6
%7 %8 %9

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

--- Comment #14 from Dan Kegel   2009-12-23 20:54:20 ---
It seems the command in #11 is an idiom for getting a fully qualified path
to the directory containing the current batch file:

for /F "delims=" %%I in ("%~dp0..") do set dir=%%~fI

delims= avoids breaking the path at a space
%~dp0.. = drive letter and path of the script followed by .. to get containing
dir
%%~fI = fully qualified name for %%I (this strips off the trailing ..)

leaves dir set to a nice absolute path to the batch file, useful for finding
neighboring scripts or data files.

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|programs                    |cmd

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

Jason Edmeades  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Jason Edmeades   2010-01-06 18:26:36 ---
Adding myself to the cmd bugs

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |27933

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Frédéric Delanoy  2011-08-26 15:27:31 CDT ---
Tests added for /F eol, delim ans skip options

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Frédéric Delanoy  2011-09-07 05:36:33 CDT ---
*** Bug 26595 has been marked as a duplicate of this bug. ***

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

johnaaronrose  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |john.aaron.rose@googlemail.
                   |                            |com

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

Jason Edmeades  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #18 from Jason Edmeades  2012-10-12 06:11:40 CDT ---
The original problem reported here is fixed, but for /f itself is still
hideously broken. The remaining issues need fixing but are really addressed
under 21047 (and the test suite has lots of todos). I plan on working through
them, but for the sake of accuracy, and only having one bug representing a
problem, resolving this bug fixed

Z:\media\sf_wine\downloads>git
fixme:cmd:WCMD_for /F needs to handle options
usage: git [--version] [--exec-path[=GIT_EXEC_PATH]] [-p|--paginate|--no-pager]
[--bare] [--git-dir=GIT_DIR] [--work-tree=GIT_WORK_TREE] [--help] COMMAND
[ARGS]
etc

(Note, no idea what fixed it though - could have been any number of things, so
leaving SHA1 field blank)

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

http://bugs.winehq.org/show_bug.cgi?id=15359

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Alexandre Julliard  2012-10-12 13:35:07 CDT ---
Closing bugs fixed in 1.5.15.

[Bug 15359] cmd's "for" command doesn't handle /F. Breaks msysgit, firefox build.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=15359
Bug 15359 depends on bug 27933, which changed state.

Bug 27933 Summary: Implement sort.exe command
https://bugs.winehq.org/show_bug.cgi?id=27933

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED