[Bug 50135] New: explorer.exe crashes when UseXRandR and UseXRandR are specified to be disabled in registry

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50135

Bug ID: 50135
           Summary: explorer.exe crashes when UseXRandR and UseXRandR are
                    specified to be disabled in registry
           Product: Wine
           Version: 5.14
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 9c99d9bceba34559a32f1e5906a6fcbcf91b0004
      Distribution: ArchLinux

How to reproduce:
1) Create a fresh new Wine prefix
2) Run the following commands to disable UseXRandR and UseXRandR in registry:

wine reg add "HKCU\Software\Wine\X11 Driver" /v "UseXVidMode" /t "REG_SZ" /d
"N" /f
wine reg add "HKCU\Software\Wine\X11 Driver" /v "UseXRandR" /t "REG_SZ" /d
"N" /f
3) Run any wine app, like "winecfg" for instance (you may need to shut down the
prefix first with "wineboot --kill --shutdown" for the bug to show up).
This occurs in versions of Wine from 5.14 to the latest one, 5.21.

The cause is the following commit:
9c99d9bceba34559a32f1e5906a6fcbcf91b0004 is the first bad commit
commit 9c99d9bceba34559a32f1e5906a6fcbcf91b0004
Author: Zhiyi Zhang 
Date:   Mon Jul 27 16:01:55 2020 +0800

winex11.drv: Migrate NoRes display settings handler to a new interface.

Reverting this commit and the next commit right after it
(b45c04f4c352ef81df5312684008839f4eeee03d - Remove the old display settings
handler interface.) against Wine-5.14 fixes the issue.

[Bug 50135] explorer.exe crashes when UseXRandR and UseXRandR are specified to be disabled in registry

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50135

Torge Matthies  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Torge Matthies  ---
Created attachment 68627
  --> https://bugs.winehq.org/attachment.cgi?id=68627
Proposed fix

The attached patch should fix the issue. The NoRes handler was not being
registered because it had a priority of zero.

[Bug 50135] explorer.exe crashes when UseXRandR and UseXRandR are specified to be disabled in registry

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50135

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from Zhiyi Zhang  ---
(In reply to Torge Matthies from comment #1)
> Created attachment 68627 [details]
> Proposed fix
>
> The attached patch should fix the issue. The NoRes handler was not being
> registered because it had a priority of zero.

Thanks for looking into this. I think it's better to adjust the priority of the
NoRes handler. I will send a fix.

[Bug 50135] explorer.exe crashes when UseXRandR and UseXRandR are specified to be disabled in registry

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50135

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Zhiyi Zhang  ---
*** Bug 49876 has been marked as a duplicate of this bug. ***

[Bug 50135] explorer.exe crashes when UseXRandR and UseXRandR are specified to be disabled in registry

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50135

--- Comment #4 from Zhiyi Zhang  ---
Created attachment 68629
  --> https://bugs.winehq.org/attachment.cgi?id=68629
fix

[Bug 50135] explorer.exe crashes when UseXRandR and UseXRandR are specified to be disabled in registry

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50135

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c4a15755de71e184b6f04d6c203
                   |                            |88fea309fde1e
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #5 from Zhiyi Zhang  ---
Fixed by c4a15755de71e184b6f04d6c20388fea309fde1e

[Bug 50135] explorer.exe crashes when UseXRandR and UseXVidMode are specified to be disabled in registry

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50135

Zhiyi Zhang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|explorer.exe crashes when   |explorer.exe crashes when
                   |UseXRandR and UseXRandR are |UseXRandR and UseXVidMode
                   |specified to be disabled in |are specified to be
                   |registry                    |disabled in registry

[Bug 50135] explorer.exe crashes when UseXRandR and UseXVidMode are specified to be disabled in registry

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50135

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 5.22.

[Bug 50135] explorer.exe crashes when UseXRandR and UseXVidMode are specified to be disabled in registry

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50135

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression