[Bug 41738] New: Cloning and releasing an IStream frees the HGLOBAL memory

https://bugs.winehq.org/show_bug.cgi?id=41738

Bug ID: 41738
           Summary: Cloning and releasing an IStream frees the HGLOBAL
                    memory
           Product: Wine
           Version: 1.9.23
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: ole32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ArchLinux

I have been experiencing crashes (using Wine 1.9.23, 32-bit, on 32-bit Arch
Linux with Linux kernel 4.8.8) in some of my apps. I have pinpointed the cause.

The issue can be reproduced this way:

1. Create a stream using CreateStreamOnHGlobal().
2. Make a clone of it using IStream::Clone() (HGLOBALStreamImpl_Clone).
3. Release the original stream.
4. Unfortunately, the global memory (HGLOBAL) is freed when just one stream is
released.
5. Trying to read the cloned stream via HGLOBALStreamImpl_Read fails, because
the memory has been already freed.

[Bug 41738] Cloning and releasing an IStream frees the HGLOBAL memory

https://bugs.winehq.org/show_bug.cgi?id=41738

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #1 from Dmitry Timoshkov  ---
Does the following patch set fix the problem?
https://github.com/wine-compholio/wine-staging/tree/master/patches/ole32-HGL...

[Bug 41738] Cloning and releasing an IStream frees the HGLOBAL memory

https://bugs.winehq.org/show_bug.cgi?id=41738

--- Comment #2 from [e-mail] ---
Yes, it does!
I have installed wine-staging 1.9.22 and now everything works fine.

[Bug 41738] Cloning and releasing an IStream frees the HGLOBAL memory

https://bugs.winehq.org/show_bug.cgi?id=41738

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

[Bug 41738] Cloning and releasing an IStream frees the HGLOBAL memory

https://bugs.winehq.org/show_bug.cgi?id=41738

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 41738] Cloning and releasing an IStream frees the HGLOBAL memory

https://bugs.winehq.org/show_bug.cgi?id=41738

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Staged patchset|                            |https://github.com/wine-com
                   |                            |pholio/wine-staging/tree/ma
                   |                            |ster/patches/ole32-HGLOBALS
                   |                            |tream
             Status|NEW                         |STAGED

--- Comment #3 from Bruno Jesus  ---
(In reply to Dmitry Timoshkov from comment #1)
> Does the following patch set fix the problem?
> https://github.com/wine-compholio/wine-staging/tree/master/patches/ole32-
> HGLOBALStream

(In reply to pgkos.bugzilla from comment #2)
> Yes, it does!
> I have installed wine-staging 1.9.22 and now everything works fine.

[Bug 41738] Cloning and releasing an IStream frees the HGLOBAL memory

https://bugs.winehq.org/show_bug.cgi?id=41738

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |erich.e.hoover@wine-staging
                   |                            |.com, [e-mail]

[Bug 41738] Cloning and releasing an IStream frees the HGLOBAL memory

https://bugs.winehq.org/show_bug.cgi?id=41738

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Staged patchset|https://github.com/wine-com |https://github.com/wine-sta
                   |pholio/wine-staging/tree/ma |ging/wine-staging/tree/mast
                   |ster/patches/ole32-HGLOBALS |er/patches/ole32-HGLOBALStr
                   |tream                       |eam

[Bug 41738] Cloning and releasing an IStream frees the HGLOBAL memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=41738

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|STAGED                      |RESOLVED
      Fixed by SHA1|                            |63dd8743352bdf7f1ae4f624477
                   |                            |0a45581806126

--- Comment #4 from Dmitry Timoshkov  ---
Committed as 63dd8743352bdf7f1ae4f6244770a45581806126.

[Bug 41738] Cloning and releasing an IStream frees the HGLOBAL memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=41738

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 5.15.