[Bug 19225] New: notepad: launching with a non-existent file does not have 'cancel' option (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19225

Summary: notepad: launching with a non-existent file does not
                    have 'cancel' option (appinstall)
           Product: Wine
           Version: 1.1.25
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Keywords: download, source
          Severity: minor
          Priority: P2
         Component: programs
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

On windows, try running:
'notepad foo.txt'

You'll get a dialog saying it doesn't exist, and offering to create it.
Options:
Yes - Creates and opens foo.txt
No - Opens notepad with an empty file
Cancel - Closes notepad, not creating any files.

On wine, you just get Yes/No.

Side note:
Choosing yes shouldn't automatically append .txt to it, e.g., running 'notepad
foo' and choosing yes should have notepad create a file named 'foo', not
'foo.txt'.

[Bug 19225] notepad: launching with a non-existent file does not have 'cancel' option (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19225

--- Comment #1 from Alexander Scott-Johns   2009-07-07 14:00:13 ---
Created an attachment (id=22243)
 --> (http://bugs.winehq.org/attachment.cgi?id=22243)
Patch that adds a Cancel button to messagebox which asks if you want to create
a new file.

This patch does not fix the .txt bug (I'm working on it).

[Bug 19225] notepad: launching with a non-existent file does not have 'cancel' option (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19225

--- Comment #2 from Alexander Scott-Johns   2009-07-07 15:00:12 ---
Created an attachment (id=22246)
 --> (http://bugs.winehq.org/attachment.cgi?id=22246)
Patch that prevents adding .txt to the filename, when opening non-existent
files with the commandline.

[Bug 19225] notepad: launching with a non-existent file does not have 'cancel' option (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19225

--- Comment #3 from Austin English   2009-07-07 16:14:04 ---
(In reply to comment #1)
> Created an attachment (id=22243)

--> (http://bugs.winehq.org/attachment.cgi?id=22243) [details]
> Patch that adds a Cancel button to messagebox which asks if you want to create
> a new file.
>
> This patch does not fix the .txt bug (I'm working on it).

Works great, thanks. Please submit.

[Bug 19225] notepad: launching with a non-existent file does not have 'cancel' option (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19225

--- Comment #4 from Austin English   2009-07-07 16:16:58 ---
(In reply to comment #2)
> Created an attachment (id=22246)

--> (http://bugs.winehq.org/attachment.cgi?id=22246) [details]
> Patch that prevents adding .txt to the filename, when opening non-existent
> files with the commandline.

Actually, looks like I misled you (sorry!). Seems XP does append .txt if the
filename doesn't have an extension. If it does have a non .txt extension, XP
preserves it (wine does the same).

There is a related bug though.

on windows:
notepad foobar.txt # choose yes, close. foobar.txt is created (empty text
file).

On wine:
notepad foobar.txt # choose yes, close. foobar.txt doesn't exist.

[Bug 19225] notepad: launching with a non-existent file does not have 'cancel' option (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19225

--- Comment #5 from Juan Lang   2009-07-07 19:01:15 ---
(In reply to comment #4)
> Actually, looks like I misled you (sorry!). Seems XP does append .txt if the
> filename doesn't have an extension. If it does have a non .txt extension, XP
> preserves it (wine does the same).

Does the behavior on Windows depend on the "hide extension" Explorer setting? 
I forget its exact name, but it's the one that hides file extensions for known
file types, and which is set by default on Windows.

[Bug 19225] notepad: launching with a non-existent file does not have 'cancel' option (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19225

Alexander Scott-Johns  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alexander.scott.johns+wineb
                   |                            |[e-mail]

--- Comment #6 from Alexander Scott-Johns   2009-07-07 19:46:48 ---
(In reply to comment #3)
> (In reply to comment #1)
> > Created an attachment (id=22243)

--> (http://bugs.winehq.org/attachment.cgi?id=22243) [details] [details]
> > Patch that adds a Cancel button to messagebox which asks if you want to create
> > a new file.
> >
> > This patch does not fix the .txt bug (I'm working on it).
>
> Works great, thanks. Please submit.

Patch submitted:
http://www.winehq.org/pipermail/wine-patches/2009-July/075565.html

[Bug 19225] notepad: launching with a non-existent file does not have 'cancel' option (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19225

--- Comment #7 from Austin English   2009-07-08 11:54:01 ---
(In reply to comment #5)
> (In reply to comment #4)
> > Actually, looks like I misled you (sorry!). Seems XP does append .txt if the
> > filename doesn't have an extension. If it does have a non .txt extension, XP
> > preserves it (wine does the same).
>
> Does the behavior on Windows depend on the "hide extension" Explorer setting? 
> I forget its exact name, but it's the one that hides file extensions for known
> file types, and which is set by default on Windows.

No, it doesn't. .txt is appended with/without that set (it's in
explorer/tools/folder options/view/Hide extensions for known file types.

Though, windows does adjust the title bar depending on if that's set, e.g.,
Hide extensions on:
notepad foobar # choose yes:
foobar - Notepad

Hide extensions off:
notepad foobar1 # choose yes:
foobar1.txt - Notepad

[Bug 19225] notepad: launching with a non-existent file does not have 'cancel' option (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19225

--- Comment #8 from Alexander Scott-Johns   2009-07-08 12:26:10 ---
(In reply to comment #7)
> (In reply to comment #5)

[snip]
> > Does the behavior on Windows depend on the "hide extension" Explorer setting? 
> > I forget its exact name, but it's the one that hides file extensions for known
> > file types, and which is set by default on Windows.
>
> No, it doesn't. .txt is appended with/without that set (it's in
> explorer/tools/folder options/view/Hide extensions for known file types.
>
> Though, windows does adjust the title bar depending on if that's set, e.g.,
> Hide extensions on:
> notepad foobar # choose yes:
> foobar - Notepad
>
> Hide extensions off:
> notepad foobar1 # choose yes:
> foobar1.txt - Notepad

If run on Windows, Wine Notepad should set the title bar like this too, as it
uses the GetFileTitleW function, which hides the extension (if needed), etc.

[Bug 19225] notepad: launching with a non-existent file does not have 'cancel' option (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19225

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Dmitry Timoshkov   2009-07-11 02:44:59 ---
Should be fixed by 0c82108a484b1df670b09714c33f10bd29d9c011

[Bug 19225] notepad: launching with a non-existent file does not have 'cancel' option (appinstall)

http://bugs.winehq.org/show_bug.cgi?id=19225

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard   2009-07-17 12:34:06 ---
Closing bugs fixed in 1.1.26.