[Bug 52381] New: wineg++: Compile error in tom.h

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52381

Bug ID: 52381
           Summary: wineg++: Compile error in tom.h
           Product: Wine
           Version: 6.19
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winelib
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Compiling an application based in winelib (copiled with wineg++), since Wine
6.19 causes a compile error at header "tom.h".

I've narrowed and minified the source file to generate the error.

-----------------------------

[sc@generic_linux1_64]/sc/tmp/wine$ cat compile_error.c 
#include <windows.h>
#include <tom.h>

int main()
{ return 0; }

[sc@generic_linux1_64]/sc/tmp/wine$ wine --version
wine-6.19

[sc@generic_linux1_64]/sc/tmp/wine$ winegcc compile_error.c

[sc@generic_linux1_64]/sc/tmp/wine$ wineg++ compile_error.c 
In file included from compile_error.c:2:
/opt/wine-devel/include/wine/windows/tom.h:1889:22: error: invalid use of
incomplete type ‘struct ITextSelection’
 1889 | ITextRange2 : public ITextSelection
      |                      ^~~~~~~~~~~~~~
In file included from compile_error.c:2:
/opt/wine-devel/include/wine/windows/tom.h:79:19: note: forward declaration of
‘struct ITextSelection’
   79 | typedef interface ITextSelection ITextSelection;
      |                   ^~~~~~~~~~~~~~
winegcc: /usr/bin/g++ failed

-----------------------------

While in Wine 6.18:

[sc@generic_linux1_64]/sc/tmp/wine$ wine --version
wine-6.18
[sc@generic_linux1_64]/sc/tmp/wine$ winegcc compile_error.c 
[sc@generic_linux1_64]/sc/tmp/wine$ wineg++ compile_error.c 
[sc@generic_linux1_64]/sc/tmp/wine$ cat compile_error.c 
#include <windows.h>
#include <tom.h>

int main()
{ return 0; }

-----------------------------

Probably the cause lies in this commit:
https://source.winehq.org/git/wine.git/commit/5a8dcb062793fbb68997e1b54ebc26...

[Bug 52381] wineg++: Compile error in tom.h

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52381

Marcos Gutiérrez Batz  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
       Distribution|---                         |Ubuntu
                 CC|                            |[e-mail]

[Bug 52381] wineg++: Compile error in tom.h

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52381

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression,
                   |                            |source

[Bug 52381] wineg++: Compile error in tom.h

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52381

--- Comment #1 from Marcos Gutiérrez Batz  ---
Created attachment 71599
  --> https://bugs.winehq.org/attachment.cgi?id=71599
Reorder tom.idl interfaces to prevent c++ compile error

To fix the issue, the only needed operation is to reorder the interfaces from
tom.idl making sure that an interface is inheriting a previously defined
interface

[Bug 52381] wineg++: Compile error in tom.h

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52381

--- Comment #2 from Marcos Gutiérrez Batz  ---
The submitted patch is based on the latest Wine 7.0-RC5

[Bug 52381] wineg++: Compile error in tom.h

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52381

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |5a8dcb062793fbb68997e1b54eb
                   |                            |c2666a2b2834d

[Bug 52381] wineg++: Compile error in tom.h

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52381

Zebediah Figura  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |048f5436fa447b325964c6d2247
                   |                            |a94eff521339c
         Resolution|---                         |FIXED
                 CC|                            |[e-mail]

--- Comment #3 from Zebediah Figura  ---
Should be fixed by
https://source.winehq.org/git/wine.git/commitdiff/048f5436fa447b325964c6d2247a94eff521339c.

[Bug 52381] wineg++: Compile error in tom.h

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=52381

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 7.0-rc6.