[Bug 17789] New: S and T with comma below accent translated to "?" in non-Unicode codepages

http://bugs.winehq.org/show_bug.cgi?id=17789

Summary: S and T with comma below accent translated to "?" in
                    non-Unicode codepages
           Product: Wine
           Version: unspecified
          Platform: All
               URL: http://source.winehq.org/git/wine.git/?a=commit;h=8e16e7
                    871063df35ca3a6de6fb165767c00bd087
        OS/Version: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Created an attachment (id=20015)
 --> (http://bugs.winehq.org/attachment.cgi?id=20015)
Screenshot after the commit

There is a regression introduced by
8e16e7871063df35ca3a6de6fb165767c00bd087 is first bad commit
commit 8e16e7871063df35ca3a6de6fb165767c00bd087
Author: Alexandre Julliard 
Date:   Mon Jan 19 19:57:59 2009 +0100

libwine: Re-generate the Windows codepage data using the bestfit files.

The șȘțȚ (s,S,t and T with comma below accent) are now translated to "?" in
non-Unicode codepages. Before those were converted to the base ASCII letter.
See attachments.

[Bug 17789] S and T with comma below accent translated to "?" in non-Unicode codepages

http://bugs.winehq.org/show_bug.cgi?id=17789

--- Comment #1 from Michael Stefaniuc   2009-03-18 17:16:51 ---
Created an attachment (id=20016)
 --> (http://bugs.winehq.org/attachment.cgi?id=20016)
Screenshot before the commit

[Bug 17789] S and T with comma below accent translated to "?" in non-Unicode codepages

http://bugs.winehq.org/show_bug.cgi?id=17789

--- Comment #2 from Michael Stefaniuc   2009-03-18 17:24:21 ---
As the mappings are generated from the Microsoft Bestfit Mappings on
unicode.org I have searched around to see how those get updated. It looks like
Microsoft won't do it if the below two links is to be trusted:
http://osdir.com/ml/ietf.charsets/2006-10/msg00076.html
http://blogs.msdn.com/shawnste/archive/2007/09/24/are-we-going-to-update-or-...

So it looks like we would have to provide our own bestfit extensions iff we
want to fix this problem.

[Bug 17789] S and T with comma below accent translated to "?" in non-Unicode codepages

http://bugs.winehq.org/show_bug.cgi?id=17789

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|All                         |Other

[Bug 17789] S and T with comma below accent translated to "?" in non-Unicode codepages

http://bugs.winehq.org/show_bug.cgi?id=17789

--- Comment #3 from Alexandre Julliard   2009-03-24 07:08:58 ---
I expect it would behave the same way on Windows. Do you have evidence to the
contrary?

[Bug 17789] S and T with comma below accent translated to "?" in non-Unicode codepages

http://bugs.winehq.org/show_bug.cgi?id=17789

--- Comment #4 from Michael Stefaniuc   2009-03-25 09:04:59 ---
That's what I suspect too but I cannot test it atm as I seem to cannot find the
Romanian MUI for Win2k3.

Anyway I need that on Linux to review the translations I'm doing. If Wine has
to follow the Windows way here too then I guess we can just close this bug. I
have worked around it on my private i18n branch. Actually it is even better now
as I'm translating the "comma below accent" characters to the corresponding
characters with "cedilla". The proper fix would be to find an unicode resource
viewer; though I couldn't find one to match ResHacker.

[Bug 17789] S and T with comma below accent translated to "?" in non-Unicode codepages

http://bugs.winehq.org/show_bug.cgi?id=17789

--- Comment #5 from Austin English   2009-09-22 14:00:55 ---
Is this still an issue in current (1.1.29 or newer) wine?

[Bug 17789] S and T with comma below accent translated to "?" in non-Unicode codepages

http://bugs.winehq.org/show_bug.cgi?id=17789

--- Comment #6 from Michael Stefaniuc   2009-09-22 16:21:43 ---
Of course; the bug is still there. I need to install XP with the Romanian lang
pack and see if that makes a difference. If not this bug is a WONTFIX as the
behavior would comply to Windows.

[Bug 17789] S and T with comma below accent translated to "?" in non-Unicode codepages

http://bugs.winehq.org/show_bug.cgi?id=17789

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://source.winehq.org/gi |
                   |t/wine.git/?a=commit;h=8e16 |
                   |e7871063df35ca3a6de6fb16576 |
                   |7c00bd087                   |

--- Comment #7 from Nikolay Sivov   2010-05-18 16:46:16 ---
(In reply to comment #6)
> Of course; the bug is still there. I need to install XP with the Romanian lang
> pack and see if that makes a difference. If not this bug is a WONTFIX as the
> behavior would comply to Windows.

Hi, Michael.

Did you test it?

[Bug 17789] S and T with comma below accent translated to "?" in non-Unicode codepages

http://bugs.winehq.org/show_bug.cgi?id=17789

--- Comment #8 from Michael Stefaniuc   2010-05-25 17:58:57 ---
Created an attachment (id=28286)
 --> (http://bugs.winehq.org/attachment.cgi?id=28286)
Patch with test

Test patch to show that șȘțȚ are lost in the W->A translation and show up only
as ????.

[Bug 17789] S and T with comma below accent translated to "?" in non-Unicode codepages

http://bugs.winehq.org/show_bug.cgi?id=17789

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID

--- Comment #9 from Michael Stefaniuc   2010-05-25 18:05:41 ---
I couldn't test it on a Windows version with a Romanian MUI installed. But I
did test the above patch on the WTB and it runs without errors (Job 2318). So
I'm marking this bug as invalid.

[Bug 17789] S and T with comma below accent translated to "?" in non-Unicode codepages

http://bugs.winehq.org/show_bug.cgi?id=17789

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Dmitry Timoshkov   2010-05-26 01:58:59 ---
Closing invalid.