[Bug 36421] New: valgrind shows some leaks in oledb32/tests/database.c

https://bugs.winehq.org/show_bug.cgi?id=36421

Bug ID: 36421
           Summary: valgrind shows some leaks in oledb32/tests/database.c
           Product: Wine
           Version: 1.7.18
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: oledb32
          Assignee: [e-mail]
          Reporter: [e-mail]

==25675== 12 bytes in 1 blocks are definitely lost in loss record 64 of 607
==25675==    at 0x7BC50A9B: RtlAllocateHeap (heap.c:255)
==25675==    by 0x64BD11D: datainit_GetDataSource (oledb_private.h:28)
==25675==    by 0x4D7DAC5: test_GetDataSource (msdasc.h:554)
==25675==    by 0x4D7DE83: func_database (database.c:110)
==25675==    by 0x4D80E18: run_test (test.h:584)
==25675==    by 0x4D81207: main (test.h:654)
==25675==

==25675== 28 bytes in 1 blocks are possibly lost in loss record 173 of 607
==25675==    at 0x7BC50A9B: RtlAllocateHeap (heap.c:255)
==25675==    by 0x531CBB8: apartment_getclassobject (compobj.c:526)
==25675==    by 0x531FFC6: get_inproc_class_object (compobj.c:2894)
==25675==    by 0x5322D2F: CoGetClassObject (compobj.c:3032)
==25675==    by 0x53234B7: CoCreateInstance (compobj.c:3197)
==25675==    by 0x4D7DE4D: func_database (database.c:100)
==25675==    by 0x4D80E18: run_test (test.h:584)
==25675==    by 0x4D81207: main (test.h:654)
==25675==

[Bug 36421] valgrind shows some leaks in oledb32/tests/database.c

https://bugs.winehq.org/show_bug.cgi?id=36421

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 36421] valgrind shows some leaks in oledb32/tests/database.c

https://bugs.winehq.org/show_bug.cgi?id=36421

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 36421] valgrind shows some leaks in oledb32/tests/database.c

https://bugs.winehq.org/show_bug.cgi?id=36421

--- Comment #1 from Alistair Leslie-Hughes  ---
dll/oledb32/datainit.c
datainit_GetDataSource
...
hr = IDBProperties_SetProperties(dbprops, 1, propset);

SetProperties fails here and hr is returned with an error code. The memory then
isn't cleaned up in the calling function.

Thanks Nikolay for the analysis.

[Bug 36421] valgrind shows some leaks in oledb32/tests/database.c

https://bugs.winehq.org/show_bug.cgi?id=36421

--- Comment #2 from Nikolay Sivov  ---
I'm going to rework this very soon, will keep that in mind.

[Bug 36421] valgrind shows some leaks in oledb32/tests/database.c

https://bugs.winehq.org/show_bug.cgi?id=36421

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Nikolay Sivov  ---
I don't see this anymore, probably fixed with
http://source.winehq.org/git/wine.git/commit/afa6cb528add488a416dbc0e7d80fd5...
or
http://source.winehq.org/git/wine.git/commit/795845ff3d1247f0d81628c0ce7d7e4....

[Bug 36421] valgrind shows some leaks in oledb32/tests/database.c

https://bugs.winehq.org/show_bug.cgi?id=36421

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.17.