[Bug 45726] New: Firefox 61.x crashes on unimplemented function KERNEL32.dll.GetApplicationRestartSettings

https://bugs.winehq.org/show_bug.cgi?id=45726

Bug ID: 45726
           Summary: Firefox 61.x crashes on unimplemented function
                    KERNEL32.dll.GetApplicationRestartSettings
           Product: Wine
           Version: 3.14
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: kernel32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Hello folks,

to track: https://www.winehq.org/pipermail/wine-devel/2018-August/131225.html

--- snip ---
$ pwd
/home/focht/.wine/drive_c/Program Files/Mozilla Firefox

$ wine ./firefox.exe
...
wine: Call from 0x7bc65834 to unimplemented function
KERNEL32.dll.GetApplicationRestartSettings, aborting
--- snip ---

MSDN:
https://docs.microsoft.com/en-us/windows/desktop/api/winbase/nf-winbase-geta...

$ sha1sum Firefox\ Setup\ 61.0.2.exe 
cbda1b0eaf06486ac0dc8cd29df386d75dc1107c  Firefox Setup 61.0.2.exe

$ du -sh Firefox\ Setup\ 61.0.2.exe 
35M    Firefox Setup 61.0.2.exe

$ wine --version
wine-3.14-161-g70fbfa2cb8

Regards

[Bug 45726] Firefox 61.x crashes on unimplemented function KERNEL32.dll.GetApplicationRestartSettings

https://bugs.winehq.org/show_bug.cgi?id=45726

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://filehippo.com/de/do
                   |                            |wnload_firefox/86978/
           Keywords|                            |download

[Bug 45726] Firefox 61.x crashes on unimplemented function KERNEL32.dll.GetApplicationRestartSettings

https://bugs.winehq.org/show_bug.cgi?id=45726

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch, source

[Bug 45726] Firefox 61.x crashes on unimplemented function KERNEL32.dll.GetApplicationRestartSettings

https://bugs.winehq.org/show_bug.cgi?id=45726

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |ad8f45095777839156168e80ff1
                   |                            |d8fba5cc265d4
             Status|NEW                         |RESOLVED

--- Comment #1 from Anastasius Focht  ---
Hello folks,

this is fixed by commit
https://source.winehq.org/git/wine.git/commitdiff/ad8f45095777839156168e80ff...

Thanks Louis

--- snip ---
$ pwd
/home/focht/.wine/drive_c/Program Files (x86)/Mozilla Firefox

$ file *.exe
crashreporter.exe:                PE32 executable (GUI) Intel 80386, for MS
Windows
firefox.exe:                      PE32 executable (GUI) Intel 80386, for MS
Windows
maintenanceservice.exe:           PE32 executable (GUI) Intel 80386, for MS
Windows
maintenanceservice_installer.exe: PE32 executable (GUI) Intel 80386, for MS
Windows, Nullsoft Installer self-extracting archive
minidump-analyzer.exe:            PE32 executable (console) Intel 80386, for MS
Windows
pingsender.exe:                   PE32 executable (console) Intel 80386, for MS
Windows
plugin-container.exe:             PE32 executable (GUI) Intel 80386, for MS
Windows
plugin-hang-ui.exe:               PE32 executable (console) Intel 80386, for MS
Windows
updater.exe:                      PE32 executable (GUI) Intel 80386, for MS
Windows

$ WINEDEBUG=+seh,+relay wine ./firefox.exe >>log.txt 2>&1
...
002b:Call ucrtbase.strncpy(0f7542e0,033a91c8
"toolkit.winRegisterApplicationRestart",00000025) ret=10002c46
002b:Ret  ucrtbase.strncpy() retval=0f7542e0 ret=10002c46
002b:Call
KERNEL32.GetApplicationRestartSettings(ffffffff,00000000,0033f44c,00000000)
ret=0150ec5a
002b:fixme:process:GetApplicationRestartSettings 0xffffffff, (nil), 0x33f44c,
(nil))
002b:Ret  KERNEL32.GetApplicationRestartSettings() retval=80004001 ret=0150ec5a 
...
--- snip ---

https://github.com/mozilla/gecko-dev/blob/master/widget/windows/nsWindow.cpp...

--- snip ---
const char16_t*
GetQuitType()
{
  if (Preferences::GetBool(PREF_WIN_REGISTER_APPLICATION_RESTART, false)) {
    DWORD cchCmdLine = 0;
    HRESULT rc =
      ::GetApplicationRestartSettings(::GetCurrentProcess(), nullptr,
&cchCmdLine, nullptr);
    if (rc == S_OK) {
      return u"os-restart";
    }
  }
  return nullptr;
}
--- snip ---

https://github.com/mozilla/gecko-dev/blob/403038737ba75af3842ba6b43b6e2fb47e...

--- snip ---
#define PREF_WIN_REGISTER_APPLICATION_RESTART
"toolkit.winRegisterApplicationRestart"
--- snip ---

$ wine --version
wine-3.14-323-g6edf38c205

Regards

[Bug 45726] Firefox 61.x crashes on unimplemented function KERNEL32.dll.GetApplicationRestartSettings

https://bugs.winehq.org/show_bug.cgi?id=45726

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard  ---
Closing bugs fixed in 3.15.

[Bug 45726] Firefox 61.x crashes on unimplemented function KERNEL32.dll.GetApplicationRestartSettings

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=45726

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://filehippo.com/de/do |https://web.archive.org/web
                   |wnload_firefox/86978/       |/20210320155903/https://ftp
                   |                            |.mozilla.org/pub/firefox/re
                   |                            |leases/61.0.2/win32/en-US/F
                   |                            |irefox%20Setup%2061.0.2.exe

--- Comment #3 from Anastasius Focht  ---
Hello folks,

adding stable download link via Internet Archive for documentation.

https://web.archive.org/web/20210320155903/https://ftp.mozilla.org/pub/firef...

$ sha1sum Firefox\ Setup\ 61.0.2.exe 
1b8510d37274db4e8ca51d623dac201f52f30515  Firefox Setup 61.0.2.exe

$ du -sh Firefox\ Setup\ 61.0.2.exe 
35M    Firefox Setup 61.0.2.exe

Posted checksum again because it differs from previous download:

https://filehippo.com/de/download_firefox/86978/

Regards