[Bug 56990] New: Implement "getdfDIJoystick"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56990

Bug ID: 56990
           Summary: Implement "getdfDIJoystick"
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 76823
  --> https://bugs.winehq.org/attachment.cgi?id=76823
"getdfDIJoystick" message

Hello.

I am using Wine from GloriousEggroll's Proton version 9.10.

Playing L.A. Noire (Rockstar Games game) with V-Patch modification. When the
game launches, a message box with "getdfDIJoystick" appears. Clicking OK makes
the game launch as normal.

I don't know what this is for, but I believe a dummy "getdfDIJoystick" could be
implemented so it "passes" the check.

This only happens via Wine/Proton, and does not happen in native Windows
(according to other users). I don't have a Windows machine to test.

I did not test this with "pure" Wine, but I believe this is a Wine issue rather
than a Proton issue.

I'll leave a screenshot attached.

INFORMATION/LINKS
OS: Fedora Linux 40
Game: https://store.steampowered.com/app/110800/LA_Noire/
Proton used:
https://github.com/GloriousEggroll/proton-ge-custom/releases/tag/GE-Proton9-...
V-Patch modification: https://github.com/VaanaCZ/LANVP

ADDITIONAL CONTEXT
The author of V-Patch is currently remaking the mod to use Ultimate ASI Loader
(see https://github.com/VaanaCZ/LANVP/issues/26), so the problem of
"getdfDIJoystick" should go away, but I think it would be nice to implement
this in Wine anyway (even if it is a dummy check).

WINEDLLOVERRIDES="dinput8=n,b" is necessary to make the patch work.

Thanks for your attention.

[Bug 56990] Implement "getdfDIJoystick"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56990

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
       Distribution|---                         |Fedora

[Bug 56990] Implement "getdfDIJoystick"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56990

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Fabian Maurer  ---
I tested WinXP/Win7 and dinput8 doesn't have "GetdfDIJoystick". Where is that
exported?

[Bug 56990] Implement "getdfDIJoystick"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56990

--- Comment #2 from Austin English  ---
(In reply to Fabian Maurer from comment #1)
> I tested WinXP/Win7 and dinput8 doesn't have "GetdfDIJoystick". Where is
> that exported?

https://github.com/VaanaCZ/LANVP/blob/1263de11b5dd88ffca241d509d6e91ef81b030...

Looks like it comes from native dinput8.

[Bug 56990] Implement "getdfDIJoystick"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56990

--- Comment #3 from [e-mail] ---
I honestly have no idea.

Here are some possibly relevant links from what I found on the internet:

https://github.com/search?q=repo%3Ageeky%2Fdinput8wrapper%20GetdfDIJoystick&...

https://github.com/search?q=repo%3AMangoFizz%2Fmoon%20GetdfDIJoystick&ty...

[Bug 56990] Implement "getdfDIJoystick"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56990

--- Comment #4 from Fabian Maurer  ---
As I said, I tested against XP/Win7 and dinput8 doesn't export that function.

[Bug 56990] Implement "getdfDIJoystick"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56990

--- Comment #5 from Nikolay Sivov  ---
Why are you looking for it on Windows? Isn't that some custom export that this
mod has? To me the issue is more likely that it loads wine's dinput8.dll
instead of its own.

[Bug 56990] L.A. Noire with V-Patch needs dinput8.GetdfDIJoystick

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56990

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Implement "getdfDIJoystick" |L.A. Noire with V-Patch
                   |                            |needs
                   |                            |dinput8.GetdfDIJoystick
     Ever confirmed|0                           |1
          Component|-unknown                    |dinput
             Status|UNCONFIRMED                 |NEW

--- Comment #6 from Fabian Maurer  ---
Okay I figured out the mystery - the function doesn't exist in XP/Win7, but it
exists on my Win11 machine. Really didn't expect that to be honest, but it was
actually added somewhere after Win7.

Marking confirmed and adjusting title.

[Bug 56990] L.A. Noire with V-Patch needs dinput8.GetdfDIJoystick

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56990

--- Comment #7 from EpicTux123  ---
Hello, just so you know:

V-Patch was updated today and this message is no longer present. It now uses an
ASI file with Ultimate ASI Loader instead of just "dinput8.dll" alone.

https://github.com/VaanaCZ/LANVP/releases/tag/v2.0

However, I still think we should implement "dinput8.GetdfDIJoystick", even if
it's a dummy thing, so I'm going to keep the issue open.