[Bug 18779] New: HttpAddRequestHeaders() doesn't handle whitespace correctly

http://bugs.winehq.org/show_bug.cgi?id=18779

Summary: HttpAddRequestHeaders() doesn't handle whitespace
                    correctly
           Product: Wine
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: wininet
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=21550)
 --> (http://bugs.winehq.org/attachment.cgi?id=21550)
Tests case for whitespace in HTTP headers

After some research for bug #17914 it seems that HttpAddRequestHeaders()
doesn't parse correctly headers regarding to whitespace. Some whitespaces are
not removed.

Additionnaly, I found that wininet.dll from IE8 doesn't allow retrieving some
headers with HttpQueryInfo() if they have whitespace in them, while wine does.

Here is a patch which add some tests for whitespace. Thoses new test works with
wininet.dll from IE8.

[Bug 18779] HttpAddRequestHeaders() doesn't handle whitespace correctly

http://bugs.winehq.org/show_bug.cgi?id=18779

--- Comment #1 from Austin English   2009-06-04 12:36:15 ---
Please send the patch to [e-mail]. Be sure to wrap failing test
in todo_wine.

[Bug 18779] HttpAddRequestHeaders() doesn't handle whitespace correctly

http://bugs.winehq.org/show_bug.cgi?id=18779

Paul Vriens  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Paul Vriens   2009-06-04 12:59:00 ---
Do these new tests also work on anything earlier then IE8?

[Bug 18779] HttpAddRequestHeaders() doesn't handle whitespace correctly

http://bugs.winehq.org/show_bug.cgi?id=18779

--- Comment #3 from Yann Droneaud   2009-06-05 03:21:08 ---
(In reply to comment #1)
> Please send the patch to [e-mail]. Be sure to wrap failing test
> in todo_wine.

I will provide a patch to wininet too, see bug #17914.

[Bug 18779] HttpAddRequestHeaders() doesn't handle whitespace correctly

http://bugs.winehq.org/show_bug.cgi?id=18779

--- Comment #4 from Yann Droneaud   2009-06-05 03:49:06 ---
(In reply to comment #2)
> Do these new tests also work on anything earlier then IE8?

Tested against wininet.dll version 7.00.5730.13 (IE8 ?) and 7.00.6000.16827
(IE7).
I'm now not sure this was IE8.

[Bug 18779] HttpAddRequestHeaders() doesn't handle whitespace correctly

http://bugs.winehq.org/show_bug.cgi?id=18779

--- Comment #5 from Paul Vriens   2009-06-05 03:57:41 ---
IE7 uses wininet 7.* and IE8 uses 8.* AFAIK (looking at my own boxes).

[Bug 18779] HttpAddRequestHeaders() doesn't handle whitespace correctly

http://bugs.winehq.org/show_bug.cgi?id=18779

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, patch, source
            Version|unspecified                 |1.1.22

[Bug 18779] HttpAddRequestHeaders() doesn't handle whitespace correctly

http://bugs.winehq.org/show_bug.cgi?id=18779

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Bruno Jesus  2011-11-19 17:34:13 CST ---
Friendly reminder of 2 years without posts.

[Bug 18779] HttpAddRequestHeaders() doesn't handle whitespace correctly

https://bugs.winehq.org/show_bug.cgi?id=18779

--- Comment #7 from [e-mail] ---
I rebased the patches, made a couple minor fixes and resent:
https://source.winehq.org/patches/data/104012

though if there's not an application that this bug is targeting, I'd say to
close it.

[Bug 18779] HttpAddRequestHeaders() doesn't handle whitespace correctly

https://bugs.winehq.org/show_bug.cgi?id=18779

--- Comment #8 from Bruno Jesus  ---
(In reply to Austin English from comment #7)
> I rebased the patches, made a couple minor fixes and resent:
> https://source.winehq.org/patches/data/104012
>
> though if there's not an application that this bug is targeting, I'd say to
> close it.

I can't find the patch in git. Seems it was not commited even if they were only
tests.

[Bug 18779] HttpAddRequestHeaders() doesn't handle whitespace correctly

https://bugs.winehq.org/show_bug.cgi?id=18779

--- Comment #9 from Bruno Jesus  ---
(In reply to Bruno Jesus from comment #8)
> (In reply to Austin English from comment #7)
> > I rebased the patches, made a couple minor fixes and resent:
> > https://source.winehq.org/patches/data/104012
> >
> > though if there's not an application that this bug is targeting, I'd say to
> > close it.
>
> I can't find the patch in git. Seems it was not commited even if they were
> only tests.

Austin, care to resend?

[Bug 18779] HttpAddRequestHeaders() doesn't handle whitespace correctly

https://bugs.winehq.org/show_bug.cgi?id=18779

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #10 from [e-mail] ---
(In reply to Bruno Jesus from comment #9)
> (In reply to Bruno Jesus from comment #8)
> > (In reply to Austin English from comment #7)
> > > I rebased the patches, made a couple minor fixes and resent:
> > > https://source.winehq.org/patches/data/104012
> > >
> > > though if there's not an application that this bug is targeting, I'd say to
> > > close it.
> >
> > I can't find the patch in git. Seems it was not commited even if they were
> > only tests.
>
> Austin, care to resend?

patching file dlls/wininet/tests/http.c
Hunk #1 succeeded at 1627 (offset 84 lines).
Hunk #2 succeeded at 1947 (offset 86 lines).

against wine-git

[Bug 18779] HttpAddRequestHeaders() doesn't handle whitespace correctly

https://bugs.winehq.org/show_bug.cgi?id=18779

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from [e-mail] ---
(In reply to super_man from comment #10)
> (In reply to Bruno Jesus from comment #9)
> > (In reply to Bruno Jesus from comment #8)
> > > (In reply to Austin English from comment #7)
> > > > I rebased the patches, made a couple minor fixes and resent:
> > > > https://source.winehq.org/patches/data/104012
> > > >
> > > > though if there's not an application that this bug is targeting, I'd say to
> > > > close it.
> > >
> > > I can't find the patch in git. Seems it was not commited even if they were
> > > only tests.
> >
> > Austin, care to resend?
>
> patching file dlls/wininet/tests/http.c
> Hunk #1 succeeded at 1627 (offset 84 lines).
> Hunk #2 succeeded at 1947 (offset 86 lines).
>
> against wine-git

patching file dlls/wininet/tests/http.c
Hunk #1 succeeded at 1652 (offset 109 lines).
Hunk #2 succeeded at 1972 (offset 111 lines).

against wine 2.8-git.