[Bug 2659] Shareaza 2.1 Does not start

[Wine Bugs]

http://bugs.winehq.org/show_bug.cgi?id=2659

------- Additional Comments From [e-mail]  2005-13-11 10:15 -------
> in case it doesn't get commited: here's a fix:
> http://www.winehq.org/hypermail/wine-patches/2005/07/att-0140/01-

patchcomctl32.diff

Shareaza still doesn't work with wine 0.9.1 -- with this fix, it does. (though 
apparently the file has changed since then, but it's still essentially the same
).

Here's an updated patch for current cvs:

Index: dlls/comctl32/header.c
===================================================================
RCS file: /home/wine/wine/dlls/comctl32/header.c,v
retrieving revision 1.87
diff -u -r1.87 header.c
--- dlls/comctl32/header.c      8 Nov 2005 12:52:35 -0000       1.87
+++ dlls/comctl32/header.c      13 Nov 2005 15:57:01 -0000
@@ -726,7 +726,10 @@
        return TRUE;

if ((nItem < 0) || (nItem >= (INT)infoPtr->uNumItem))
+    {
         lpItem = NULL;
+        return FALSE;
+    }
     else
         lpItem = &infoPtr->items[nItem];

(credit to the original author, my effort consisted of a ctrl-F to find where 
the place to put the 'return FALSE;' has moved :)

With the fix it works *quite* well (better than any native Linux p2p app, 
anyways ;), there's a total of two notable bugs:

- if you open a menu in the menubar and then move the mouse sideways to switch 
to a different menu, the old one doesn't go away (workaround: always close the 
previous menu before opening a new one)

- it seems it asks to overwrite a file every time a download completes, even if 
no such file was there before (workaround: say 'ok')