[Bug 41679] New: netconn_secure_connect: Add calling TRACE, add sock_send retcode to 'send failed' message

https://bugs.winehq.org/show_bug.cgi?id=41679

Bug ID: 41679
           Summary: netconn_secure_connect: Add calling TRACE, add
                    sock_send retcode to 'send failed' message
           Product: Wine
           Version: 1.9.22
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P2
         Component: winhttp
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

I've been playing around with winhttp, and offering following debugging aid ...

diff --git a/dlls/winhttp/net.c b/dlls/winhttp/net.c
index 7213dd9..82bd110 100644
--- a/dlls/winhttp/net.c
+++ b/dlls/winhttp/net.c
@@ -393,6 +393,7 @@

BOOL netconn_secure_connect( netconn_t *conn, WCHAR *hostname )
 {
+    TRACE("%p %s\n", conn, debugstr_w(hostname));
     SecBuffer out_buf = {0, SECBUFFER_TOKEN, NULL}, in_bufs[2] = {{0,
SECBUFFER_TOKEN}, {0, SECBUFFER_EMPTY}};
     SecBufferDesc out_desc = {SECBUFFER_VERSION, 1, &out_buf}, in_desc =
{SECBUFFER_VERSION, 2, in_bufs};
     BYTE *read_buf;
@@ -427,7 +428,7 @@

size = sock_send(conn->socket, out_buf.pvBuffer, out_buf.cbBuffer,
0);
             if(size != out_buf.cbBuffer) {
-                ERR("send failed\n");
+                ERR("send failed: %d!=%d: hostname=%s\n", size,
out_buf.cbBuffer, debugstr_w(hostname));
                 res = ERROR_WINHTTP_SECURE_CHANNEL_ERROR;
                 break;
             }

[Bug 41679] netconn_secure_connect: Add calling TRACE, add sock_send retcode to 'send failed' message

https://bugs.winehq.org/show_bug.cgi?id=41679

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from [e-mail] ---
You need to send your patch for review wine-devel. Patches aren't picked from
bugzilla.

https://wiki.winehq.org/Submitting_Patches

[Bug 41679] netconn_secure_connect: Add calling TRACE, add sock_send retcode to 'send failed' message

https://bugs.winehq.org/show_bug.cgi?id=41679

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |9b3b5fd0c0459ab91d715dab31c
                   |                            |9d270ffb4364a
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Hans Leidekker  ---
Fixed by 9b3b5fd0c0459ab91d715dab31c9d270ffb4364a. Errors from send and recv
are logged as warnings now. The hostname will be evident from a +winhttp trace.

[Bug 41679] netconn_secure_connect: Add calling TRACE, add sock_send retcode to 'send failed' message

https://bugs.winehq.org/show_bug.cgi?id=41679

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 3.18.