[Bug 14851] New: Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

Summary: Soulseek: can't connect to server
           Product: Wine
           Version: 1.1.2
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

The newest (157 NS 13c) and original (156c) soulseek file sharing applications
cannot connect to the soulseek server. According to a report in the AppDB this
worked in in Wine 0.9.39

You can download soulseek at http://slsknet.org/download.html

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

--- Comment #1 from Vitaliy Margolen   2008-08-13 08:47:22 ---
Please attach complete terminal output when running this applications (as a
text file).

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

--- Comment #2 from Brian   2008-08-13 15:49:22 ---
Created an attachment (id=15402)
 --> (http://bugs.winehq.org/attachment.cgi?id=15402)
Terminal output

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #3 from Austin English   2009-01-13 21:58:08 ---
Confirming in git.

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

Joe Mattiello  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Joe Mattiello   2009-03-30 18:41:20 ---
Working on a regression test between 0.9.39 and 0.9.40, didn't seem to work.
Didn't verify that 0.9.39 did in face work to begin with though.

What I know:

Current head - doesn't work.
0.9.38 - Crashes with Seg Fault during open. (maybe I should have make clean'd
first)
Crossover Office 6.2.1 Mac (Wine 0.9.34) does work.

Continuing on this...

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

--- Comment #5 from Joe Mattiello   2009-03-30 23:04:05 ---
After some more testing I've come to the conclusion regression testing may be
difficult with the systems I'm using (CentOS 5.2 (RHEL5) x86_64). Here's what
I've found, in the order I tested.

-- all Wine (git) defaults. Win2k
0.9.39 - Doesn't connect
0.9.34 - Does connect, promptly asks to install Gecko. Crashes if you don't
otherwise works fine if you let it.
0.9.37 - crashes on load (attached)
-- cleaned out .wine
0.9.36 - crashes on load
0.9.35 - crashes on load
0.9.34 - retest, works fine again
-- cleaned out .wine
-- change to win98
0.9.38 - Opens, doesn't connect (or ask to install gecko)
-- back to win2k
0.9.39 - same, opens, doesn't connect (or ask to install gecko)
-- back to 98
0.9.37 - retest - crashes on load (attached, more detailed trace in 98 mode)

So now I'm going to try to regression test between 0.9.38 and 0.9.34, but with
all the crashes in the builds in between I suspect it will be fruitless. :/

Asking some one else to try versions in the the middle.

--note:
Since this is my first time  using git, I'll also post my build commands to
make sure I was doing it right.

git reset --hard wine-0.9.xx
CC="gcc -m32" CFLAGS="-g -O0" ./configure --verbose && make -j9 depend && make
-j9 
/ Yes, it's an 8 core machine

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

--- Comment #6 from Joe Mattiello   2009-03-30 23:05:19 ---
Created an attachment (id=20217)
 --> (http://bugs.winehq.org/attachment.cgi?id=20217)
Log for crashes in #5

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

Joe Mattiello  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Joe Mattiello   2009-03-31 00:01:12 ---
Results of regression test between 0.9.38 and 0.9.34
=======
2a9dfe242b8d2b26c3498f27002c7190f1d7e77f is first bad commit
commit 2a9dfe242b8d2b26c3498f27002c7190f1d7e77f
Author: Alexandre Julliard 
Date:   Thu Apr 5 11:29:30 2007 +0200

ws2_32: Don't access the IO_STATUS_BLOCK until the I/O operation is
finished.

:040000 040000 d860d19991e8bab957cfae519873abe38a057558
fecf8de913eb48ffdd3eb4a689f6ddf217fedcf7 M      dlls
========

This regession ended in a between a build that would open and connect, and a
build that would crash on load. This ultimately does not answer the question as
to what is causing the connection problem, but I am unable to dissect the two
issues from each other.

The crashing bug is obviously fixed now, but the connection issue still not,
and these were the two closest running builds I could test on my setup.

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

--- Comment #8 from Austin English   2009-03-31 00:40:02 ---
(In reply to comment #7)
> Results of regression test between 0.9.38 and 0.9.34
>
> 2a9dfe242b8d2b26c3498f27002c7190f1d7e77f is first bad commit
> commit 2a9dfe242b8d2b26c3498f27002c7190f1d7e77f
> Author: Alexandre Julliard 
> Date:   Thu Apr 5 11:29:30 2007 +0200
> ws2_32: Don't access the IO_STATUS_BLOCK until the I/O operation is
>
> finished.
>
> :040000 040000 d860d19991e8bab957cfae519873abe38a057558
> fecf8de913eb48ffdd3eb4a689f6ddf217fedcf7 M      dlls
> ========

Try reverting the patch in git. Or build just before it:
$ git checkout 2a9dfe242b8d2b26c3498f27002c7190f1d7e77f ; patch -p1 -R
2a9dfe242b8d2b26c3498f27002c7190f1d7e77f
$ ./configure && make depend && make
> This regession ended in a between a build that would open and connect, and a
> build that would crash on load. This ultimately does not answer the question as
> to what is causing the connection problem, but I am unable to dissect the two
> issues from each other.

You can, it's just long and hard. You have to test for one regression at a
time.

http://wiki.winehq.org/ReverseRegressionTesting may help.

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

--- Comment #9 from Joe Mattiello   2009-03-31 14:36:56 ---
A reverse regression test between 0.9.37 (crash on load) and 0.9.38 (no crash,
but no connect) for the 'crash on open' bug yielded:

==========================================
dd8a736c3fc8ebcbbce1d4c548ac0e57d5c3feff is first bad commit
commit dd8a736c3fc8ebcbbce1d4c548ac0e57d5c3feff
Author: Rob Shearman 
Date:   Mon May 21 16:45:17 2007 +0100

ole32: The identity functions can be used from apartments other than the
one the proxy was unmarshaled into.

In this case, don't use the cached This->remunk and don't cache the
    unmarshaled object in This->remunk.

:040000 040000 5220efd5cf61185d34f51c92fb59de3f8ba431de
bba76338655538612a9f2aad75635a66a3fbdeb6 M      dlls
==========================================

git checkout dd8a736c3fc8ebcbbce1d4c548ac0e57d5c3feff

This yielded a build that would still crash on open.

Please advise.

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

--- Comment #10 from Austin English   2009-03-31 15:13:08 ---
(In reply to comment #9)
> A reverse regression test between 0.9.37 (crash on load) and 0.9.38 (no crash,
> but no connect) for the 'crash on open' bug yielded:
>
> ==========================================
> dd8a736c3fc8ebcbbce1d4c548ac0e57d5c3feff is first bad commit
> commit dd8a736c3fc8ebcbbce1d4c548ac0e57d5c3feff
> Author: Rob Shearman 
> Date:   Mon May 21 16:45:17 2007 +0100
> ole32: The identity functions can be used from apartments other than the
>
> one the proxy was unmarshaled into.
> In this case, don't use the cached This->remunk and don't cache the
> unmarshaled object in This->remunk.
>
> :040000 040000 5220efd5cf61185d34f51c92fb59de3f8ba431de
> bba76338655538612a9f2aad75635a66a3fbdeb6 M      dlls
> ==========================================
>
> git checkout dd8a736c3fc8ebcbbce1d4c548ac0e57d5c3feff
>
> This yielded a build that would still crash on open.
>
> Please advise.

Run two bisects, one to find the crash fix patch, one to find the no connect
regression.

Once you've identified the crash fix patch, apply it each time before testing
for no connect.

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

--- Comment #11 from Joe Mattiello   2009-03-31 15:27:23 ---
(In reply to comment #10)
> (In reply to comment #9)
> > A reverse regression test between 0.9.37 (crash on load) and 0.9.38 (no crash,
> > but no connect) for the 'crash on open' bug yielded:
> >
> > ==========================================
> > dd8a736c3fc8ebcbbce1d4c548ac0e57d5c3feff is first bad commit
> > commit dd8a736c3fc8ebcbbce1d4c548ac0e57d5c3feff
> > Author: Rob Shearman 
> > Date:   Mon May 21 16:45:17 2007 +0100
> > ole32: The identity functions can be used from apartments other than the
> >
> > one the proxy was unmarshaled into.
> > In this case, don't use the cached This->remunk and don't cache the
> > unmarshaled object in This->remunk.
> >
> > :040000 040000 5220efd5cf61185d34f51c92fb59de3f8ba431de
> > bba76338655538612a9f2aad75635a66a3fbdeb6 M      dlls
> > ==========================================
> >
> > git checkout dd8a736c3fc8ebcbbce1d4c548ac0e57d5c3feff
> >
> > This yielded a build that would still crash on open.
> >
> > Please advise.
>
> Run two bisects, one to find the crash fix patch, one to find the no connect
> regression.
>
> Once you've identified the crash fix patch, apply it each time before testing
> for no connect.

I thought I was doing the former. The crash was fixed between 0.9.37-38. So I
bisected and marked 38 as bad and 37 as good and rebuilt. Doing the normal,
bisect, build, compile pipeline from there, except marking a crash as 'good'
and successful open as 'bad'.

This is what brought me to dd8a736c3fc8ebcbbce1d4c548ac0e57d5c3feff. This
"should" be the patch that fixed it, or so I thought, alas checking out that
version still crashes.

I'm going to re-read the reverse regression article to see if I skipped
something. It could be that I am just not familiar with git and may have a
contaminated tree between tests.

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

MatDivaret  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from MatDivaret   2009-09-15 08:18:47 ---
I think this bug can be closed.
With wine 1.1.29, soulseek works fine (still some bugs but not this one it
seems)

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Dmitry Timoshkov   2009-09-15 09:16:09 ---
Reported fixed.

[Bug 14851] Soulseek: can't connect to server

http://bugs.winehq.org/show_bug.cgi?id=14851

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard   2009-09-25 12:24:35 ---
Closing bugs fixed in 1.1.30.