[Bug 26269] New: BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

Summary: BioShock 2: Loss of keyboard input on loading screen
           Product: Wine
           Version: 1.3.14
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-dinput
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=33488)
 --> (http://bugs.winehq.org/attachment.cgi?id=33488)
trace +keyboard

On the inital 'New Game' loading screen you cannot use the space bar to
continue.
Keyboard and mouse input is recognised correctly when adjusting settings in the
menus.

Wine version 1.3.14-git
Xserver v1.10.0

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

blaise  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33488|2bugs                       |2bugs.txt
           filename|                            |

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #1 from Vitaliy Margolen  2011-03-02 08:32:51 CST ---
Please attach +dinput debug.

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33488|application/octet-stream    |text/plain
          mime type|                            |

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #2 from blaise  2011-03-03 16:47:41 CST ---
If I failed to mention,I'm using the xliveless for Bioshock2 from here
http://timeslip.users.sourceforge.net/current/bioshock2-xlive.7z for Bio2 to
load properly. Looking around the Bioshock2 forums and doing google searches
this bug seems to be common place in windows also where you can't proceed after
it loads the level so it's probably not W.I.N.E. specific. 
attaching +dinput trace

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #3 from blaise  2011-03-03 16:48:24 CST ---
Created an attachment (id=33524)
 --> (http://bugs.winehq.org/attachment.cgi?id=33524)
+dinput trace

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

Bully Bull  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Bully Bull  2011-04-22 17:02:05 CDT ---
I have the DVD version of the game
and I can confirm the bug.
The game starts without any Problems.
In the menus the keyboard works.
(I can change the keyboard settings)
But when I start a new game and I
should press the space bar to continue
nothing happens.

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #5 from Dan Kegel  2011-05-31 18:28:56 CDT ---
I'm seeing this, too.
I don't think this is related to the problem people complain about in
windows, as there the crash happens *after* you press space; here
pressing space does nothing.

Setting XMODIFIERS to the empty string doesn't seem to help.

This is with xorg server 1.6.5.

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #6 from Dan Kegel  2011-05-31 19:25:15 CDT ---
Also happens on ubuntu 11.04, which uses xserver-xorg-1.7.6 or so.

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #7 from Dan Kegel  2011-05-31 19:58:17 CDT ---
Also, on Windows, clicking will skip past logo movies.
On Wine, it won't (but mouse input still works ok later in the menus)

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

Philipp L.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Philipp L.  2011-07-10 13:39:47 CDT ---
You can *bypass* this bug by installing the dinput8 override through
winetricks. This way, the loading screen also doesn't recognize any input,
however, for some reason, the game doesn't wait for input to start the game
then - it immediately starts the game when loading has finished.

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #9 from Bully Bull  2011-07-12 11:14:36 CDT ---
> Philipp L.

Have you the DVD or Steam Version?
When I copy dinput8.dll manually I have
no keyboard and no mouse in the menu!
With winetricks dinput8, keyboard and mouse
works fine but the game doesn't start
when loading has finished.

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #10 from Philipp L.  2011-07-12 12:44:45 CDT ---
I've got the DVD-version.
Maybe it also depends on some wine-settings - I use a virtual screen and I have
set the option for automatic mouse capture in fullscreen mode.
I had the bug again after updating to the latest wine release - however,
reinstalling d3dx9 and dinput8 with winetricks solved it again (even though the
dll-override was still set in winecfg).

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #11 from Bully Bull  2011-07-12 15:53:25 CDT ---
> I've got the DVD-version

Check! same here
> virtual screen

Nope! tested with fullscreen
      virtual screen change nothing
> set the option for automatic mouse capture in fullscreen mode

Check! same here (the good !?! old 6971 bug)
> d3dx9

Nope! Only d3dx9_36.dll installed (Bioshock 2 only need this file)
      winetricks d3dx9 change nothing
> dinput8

Check! same here (the game doesn't start automatically)

Linux Distro is Mageia 1

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #12 from blaise  2011-09-25 17:08:30 CDT ---
Got past the -space bar- problem finally after fiddling about a bit. Not sure
which step actually takes care of the problem.

renamed to .old everything except under /SharedBinks except Credits and
Waterfall
renamed to .old 2KG_logo_720P.bik and Logo.bik in BioShock
2/SP/Content/BinkMovies
Adjusted Space= in Application Data/Bioshock2/User.ini to read
Space=AcceptOrSelect for every instance.
Using the -nointro command line switches.
No need for the env XMODIFIERS="" switch.

When you load a new game or level it goes straight into the opening movie and
level without any -spacebar to continue- input.:) No problems with loading or
saving. Happy gaming!

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

blaise  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |WORKSFORME

--- Comment #13 from blaise  2011-09-25 19:53:49 CDT ---
doing the above changes makes it works for me.

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|WORKSFORME                  |

--- Comment #14 from Austin English  2011-09-25 23:26:33 CDT ---
(In reply to comment #13)
> doing the above changes makes it works for me.

There's still a bug in wine to fix.

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #15 from Bully Bull  2011-09-28 10:30:16 CDT ---
changing "Space=" in "Space=AcceptOrSelect"
works for me too

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from [e-mail] 2012-05-13 05:48:42 CDT ---
I'm seeing the same behaviour in 1.5.4 and 1.5.3.  The XMODIFIERS command has
no effect, neither does setting 'Space=AcceptOrSelect' in the User.ini, nor
setting the -nointro flag. Using WINEDEBUG=+keyboard,+key I can that X is
receiving the keyboard messages and interpreting them correctly.

What's really confusing though is that the keyboard works fine in the menu
system, but is only ignored during the loading screen.  Also it's not just the
spacebar, in the loading screen you can use the arrow keys to change the
helpful tip - these are also ignored.

I also tried doing the same for DefUser.ini, in case "my" User.ini wasn't being
loaded, but it had no effect.

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #17 from [e-mail] 2012-05-13 05:54:23 CDT ---
Forgot to mention that renaming the bink files had no effect, apart from the
tedious developer one not appearing.

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #18 from [e-mail] 2012-05-20 03:15:11 CDT ---
I'm seeing:

fixme:xinput:XInputSetState (0 0x26b41d0) Stub!

Printed when I enter the loading screen, would I be right in thinking it's
telling me that X input is being turned off?

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #19 from Austin English  2012-05-21 21:55:39 CDT ---
(In reply to comment #18)
> I'm seeing:
>
> fixme:xinput:XInputSetState (0 0x26b41d0) Stub!
>
> Printed when I enter the loading screen, would I be right in thinking it's
> telling me that X input is being turned off?

xinput = dll for xbox 360 controllers, not X.org's input.

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

Rion  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

http://bugs.winehq.org/show_bug.cgi?id=26269

Jay  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

https://bugs.winehq.org/show_bug.cgi?id=26269

Béla Gyebrószki  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #20 from Béla Gyebrószki  ---
Still present in wine-1.7.34-126-g0b811ee

Fedora 21
Xorg-1.16.2.901
XFCE 4.10

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

https://bugs.winehq.org/show_bug.cgi?id=26269

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #21 from joaopa  ---
Still a bu gin current wine?

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=26269

--- Comment #22 from joaopa  ---
Does the bug still occur with wine-5.14?

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=26269

Julian Rüger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=26269

soredake  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=26269

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #23 from Rémi Bernon  ---
Created attachment 69721
  --> https://bugs.winehq.org/attachment.cgi?id=69721
Patch fixing the issue

The game calls GetKeyState from a background thread to check for space key
being pressed, and it requires the thread keystate to be synchronized with the
desktop async keystate in that case as well.

I reworked the server-Key_State staging patch series (attached) to add more
tests and fix this issue too. I'm not sure if the original patch series was
fixing it or not, but it was failing a few of the tests I added anyway.

This updated patch should still address
https://bugs.winehq.org/show_bug.cgi?id=31899,
https://bugs.winehq.org/show_bug.cgi?id=35907, and hopefully
https://bugs.winehq.org/show_bug.cgi?id=45385 too.

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=26269

Neko-san  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 26269] BioShock 2: Loss of keyboard input on loading screen

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=26269

soredake  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|broaden_acid002@simplelogin |
                   |.com                        |