[Bug 35428] New: Screenshots get horribly broken and resized on upload

http://bugs.winehq.org/show_bug.cgi?id=35428

Bug ID: 35428
           Summary: Screenshots get horribly broken and resized on upload
           Product: WineHQ Apps Database
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: appdb-unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
    Classification: Unclassified

Created attachment 47281
  --> http://bugs.winehq.org/attachment.cgi?id=47281
Far 3 original screenshot

Consider this beautiful PNG screenshot.

Size: 106331 bytes
Format: PNG/lossless
Resolution: 1284x744@24bpp

What AppDB turns it to:

http://appdb.winehq.org/screenshots.php?iAppId=953&iVersionId=27377

Size: 196888 bytes (2 times more!)
Format: Bad resized PNG
Resolution: 1024×593@24bpp

This needs to be fixed. We live in the 21 century.

[Bug 35428] Screenshots get horribly broken and resized on upload

http://bugs.winehq.org/show_bug.cgi?id=35428

--- Comment #1 from Nikolay Sivov  ---
(In reply to comment #0)
> This needs to be fixed. We live in the 21 century.

Good point, actually.

[Bug 35428] Screenshots get horribly broken and resized on upload

https://bugs.winehq.org/show_bug.cgi?id=35428

Jeremy Newman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]
                 CC|                            |[e-mail]
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #2 from Jeremy Newman  ---
I'll look into this.

[Bug 35428] Screenshots get horribly broken and resized on upload

https://bugs.winehq.org/show_bug.cgi?id=35428

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from [e-mail] ---
I recently made a forum post about it and got pointed to this issue – the
screenshots are unfortunately always scaled down to 1024 width – now that I
know that, I always rescale them down to that resolution beforehand, so at
least I can choose the scaling method on my PC and since the file size limit is
only 600KB it often allows to upload in a higher quality.

Due to size restrictions I always uploaded JPGs instead of PNGs but at least it
seems that PNG is an accepted format that stays PNG after upload, but since
WineHQ adds its watermark (and scales down, unless you are aware of 1024 width
limitation), the image have to be processed anyway. For already scaled down
PNGs that should be lossless though if you optimized the image that gains will
be lost, but for JPG that can result in further quality lost.

Mobygames stopped adding watermarks on their images and even proceed to remove
them for existing images, so it's something to take into consideration,
especially since if WineHQ logo changes, the old images retain old screenshots.

Either way, for the time being it would be nice to at least add the information
about the 1024 width scaling – that way, knowing the resolution, uploader can
either run the applicationf or screenshot on a lower resolution beforehand, or
at least resize the image to more easily fit in the 600KB limit and/or choose
the preferred scaling method.

Linking my post for clarity as well
https://forum.winehq.org/viewtopic.php?f=11&t=29709&p=112880

[Bug 35428] Screenshots get horribly broken and resized on upload

https://bugs.winehq.org/show_bug.cgi?id=35428

tokktokk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 35428] Screenshots get horribly broken and resized on upload

https://bugs.winehq.org/show_bug.cgi?id=35428

--- Comment #4 from Artem S. Tashkinov  ---
(In reply to Jeremy Newman from comment #2)
> I'll look into this.

Any updates? This bug is now 5 years old.

[Bug 35428] Screenshots get horribly broken and resized on upload

https://bugs.winehq.org/show_bug.cgi?id=35428

--- Comment #5 from Jeremy Newman  ---
No update. This process of dynamically resizing shots on the fly is a serious
waste of server resources. My plan was to completely re-do the screenshot
system and convert all the shots over to using our static CDN to save on
bandwidth. But this is a fairly large rewrite and all the existing shots would
need to be converted.

I can try to at least do a quicker fix and patch the resizing code in the
meantime.

Also, I would love to get some more volunteers maintaining the AppDB code.

[Bug 35428] Screenshots get horribly broken and resized on upload

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=35428

--- Comment #6 from Jeremy Newman  ---
I wrote a patch for the AppDB that loads the images from our CDN. The original
image is used now and not dynamically resized on the fly.

Patch:
https://source.winehq.org/git/appdb.git/commitdiff/0f74052d3a7f447d79d17ef1f...

Note, images may still get resized to a maximum size on upload. I still need to
look into that. Might be better to just block images over a certain filesize
then resizing them.

[Bug 35428] Screenshots get horribly broken and resized on upload

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=35428

--- Comment #7 from Artem S. Tashkinov  ---
(In reply to Jeremy Newman from comment #6)
> I wrote a patch for the AppDB that loads the images from our CDN. The
> original image is used now and not dynamically resized on the fly.
>
> Patch:
> https://source.winehq.org/git/appdb.git/commitdiff/
> 0f74052d3a7f447d79d17ef1fcedcdd243d2f0fd
>
> Note, images may still get resized to a maximum size on upload. I still need
> to look into that. Might be better to just block images over a certain
> filesize then resizing them.

Thanks a ton!

It would be great if you added support for WEBP and JXL (Jpep XL) formats as
well. Lossless screenshots in either of two can be a lot smaller than in PNG.

Thanks a lot again.