[Bug 28794] New: user32:edit crashes on Mac

http://bugs.winehq.org/show_bug.cgi?id=28794

Bug #: 28794
           Summary: user32:edit crashes on Mac
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: user32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]
    Classification: Unclassified
   Regression SHA1: acaa0dc2dacb4d6e6f223213ce9a1e27b0b8e8ed

Ever since Aric got his "Uniscribe in the single line edit control" patch
committed, the test has been crashing like so on my system:

]] Backtrace:
]] =>0 0x44365100 _ScriptStringFree+0x98() in usp10 (0x0033f8a8)
]]   1 0x42ea238e _EDIT_InvalidateUniscribeData+0x22() in user32 (0x0033f8d8)
]]   2 0x42ea6127 _EDIT_EM_ReplaceSel+0x83a() in user32 (0x0033f998)
]]   3 0x42ead372 _EditWndProc_common+0x1130() in user32 (0x0033fa58)
]]   4 0x42f24e16 _EditWndProcA+0x46() in user32 (0x0033fa88)
]]   5 0x42f2193a _WINPROC_wrapper+0x19() in user32 (0x0033fac8)
]]   6 0x42f21a9b _call_window_proc+0xcc() in user32 (0x0033fb08)
]]   7 0x42f2460c _WINPROC_call_window+0x21e() in user32 (0x0033fb68)
]]   8 0x42edd0a3 _call_window_proc+0xbf() in user32 (0x0033fbc8)
]]   9 0x42edfbd1 _send_message+0x140() in user32 (0x0033fc38)
]]   10 0x42ee0262 _SendMessageA+0x64() in user32 (0x0033fc88)
]]   11 0x4064935f _test_edit_control_3+0x209() in user32_test (0x0033fd08)
]]   12 0x4065879a _func_edit+0x76() in user32_test (0x0033fd38)
]]   13 0x4070b5fc _run_test+0xaf() in user32_test (0x0033fd98)
]]   14 0x4070ba59 _main+0x24b() in user32_test (0x0033fe58)
]]   15 0x4070bafa ___wine_spec_exe_entry+0x7b() in user32_test (0x0033fe88)
]]   16 0x7b8583ac _call_process_entry+0xb() in kernel32 (0x0033fea8)
]]   17 0x7b858510 _start_process+0x161() in kernel32 (0x0033ff08)
]]   18 0x7bc7824c _call_thread_func+0xb() in ntdll (0x0033ff28)
]]   19 0x7bc78285 _call_thread_entry_point+0x2e() in ntdll (0x0033ffb8)
]]   20 0x7bc4904a _start_process+0x23() in ntdll (0x0033ffe8)

I'm sorry I don't have more information, but dbghelp doesn't support DWARF
symbols on Mac.

[Bug 28794] user32:edit crashes on Mac

http://bugs.winehq.org/show_bug.cgi?id=28794

Charles Davis  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression, source,
                   |                            |testcase

[Bug 28794] user32:edit crashes on Mac

http://bugs.winehq.org/show_bug.cgi?id=28794

--- Comment #1 from Aric Stewart  2011-10-18 14:08:39 CDT ---
Ever Since?  It has been about an hour. :)

if you reconfigure with CC="gcc -gstabs" ./configure you will get the symbols
in the backtrace and that will be really helpful.

[Bug 28794] user32:edit crashes on Mac

http://bugs.winehq.org/show_bug.cgi?id=28794

--- Comment #2 from Aric Stewart  2011-10-18 14:31:54 CDT ---
The edit test continues to work without issue on my Mac.

I am using Snow Leopard with a clean wine prefix.

[Bug 28794] user32:edit crashes on Mac

http://bugs.winehq.org/show_bug.cgi?id=28794

--- Comment #3 from Charles Davis  2011-10-18 15:20:05 CDT ---
Still crashes for me on Snow Leopard with a clean Wine prefix.

Here's a more detailed backtrace (with stabs debugging):
=>0 0x4a2c80b6 ScriptStringFree+0x86(pssa=)
[/Users/chip/wine-build/dlls/usp10/../../../wine-git/dlls/usp10/usp10.c:1590]
in usp10 (0x0032f808)
  1 0x46227697 EDIT_EM_ReplaceSel+0x856(es=0x145238, send_update=0x1,
honor_limit=0x1)
[/Users/chip/wine-build/dlls/user32/../../../wine-git/dlls/user32/edit.c:373]
in user32 (0x0032f8c8)
fixme:winedbg:print_value ---error
  2 0x4622bb03 EditWndProc_common+0x2482(hwnd=, msg=0xc2, wParam=0,
lParam=0x459d2fb3, unicode=0)
[/Users/chip/wine-build/dlls/user32/../../../wine-git/dlls/user32/edit.c:4565]
in user32 (0x0032f988)
fixme:winedbg:print_value ---error
  3 0x4628b74d EditWndProcA+0x4c(hwnd=, msg=0x4628b4ea, wParam=0x4627b22c,
lParam=0x1)
[/Users/chip/wine-build/dlls/user32/../../../wine-git/dlls/user32/winproc.c:1076]
in user32 (0x0032f9c8)
  4 0x4628b4ea WINPROC_wrapper+0x19() in user32 (0x0032fa08)
fixme:winedbg:print_value ---error
  5 0x4628be9e call_window_proc+0x5d(hwnd=, msg=0xc2, wp=0, lp=0x459d2fb3,
result=0x32faec, arg=0x4628b700)
[/Users/chip/wine-build/dlls/user32/../../../wine-git/dlls/user32/winproc.c:242]
in user32 (0x0032fa48)
fixme:winedbg:print_value ---error
  6 0x4628e87e WINPROC_call_window+0x12d(hwnd=, msg=0xc2, wParam=0,
lParam=0x459d2fb3, result=0x32faec, unicode=0, mapping=WMCHAR_MAP_SENDMESSAGE)
[/Users/chip/wine-build/dlls/user32/../../../wine-git/dlls/user32/winproc.c:908]
in user32 (0x0032fa98)
fixme:winedbg:print_value ---error
  7 0x4624f5b0 call_window_proc+0x8f(hwnd=, msg=0x5348, wparam=0x145238,
lparam=0x459d2fb3, unicode=0, same_thread=0x1, mapping=WMCHAR_MAP_SENDMESSAGE)
[/Users/chip/wine-build/dlls/user32/../../../wine-git/dlls/user32/message.c:2211]
in user32 (0x0032fb08)
fixme:winedbg:print_value ---error
  8 0x46255031 send_message+0x210(info=, unicode=0x1452e8)
[/Users/chip/wine-build/dlls/user32/../../../wine-git/dlls/user32/message.c:3084]
in user32 (0x0032fb88)
fixme:winedbg:print_value ---error
  9 0x462554e9 SendMessageA+0x58(hwnd=, msg=0x4592f42e, wparam=0x4592e9f1,
lparam=0x45922bf8)
[/Users/chip/wine-build/dlls/user32/../../../wine-git/dlls/user32/message.c:3286]
in user32 (0x0032fbc8)
  10 0x4592f42e func_edit+0xa4d()
[/Users/chip/wine-build/dlls/user32/tests/../../../../wine-git/dlls/user32/tests/edit.c:906]
in user32_test (0x0032fd48)
  11 0x459ca85e run_test+0x10d()
[/Users/chip/wine-build/dlls/user32/tests/../../../../wine-git/include/wine/test.h:556]
in user32_test (0x0032fdb8)
  12 0x459caace main+0x19d(argc=0x2, argv=0x110418)
[/Users/chip/wine-build/dlls/user32/tests/../../../../wine-git/include/wine/test.h:624]
in user32_test (0x0032fea8)
fixme:winedbg:print_value ---error
  13 0x459cb5e8 __wine_spec_exe_entry+0x37(peb=)
[/Users/chip/wine-build/dlls/winecrt0/../../../wine-git/dlls/winecrt0/exe_entry.c:36]
in user32_test (0x0032fec8)
  14 0x4404c7ec call_process_entry+0xb() in kernel32 (0x0032fee8)
  15 0x4404f617 start_process+0x66(peb=0x32ff48)
[/Users/chip/wine-build/dlls/kernel32/../../../wine-git/dlls/kernel32/process.c:1091]
in kernel32 (0x0032ff28)
  16 0x41864b3c call_thread_func+0xb() in ntdll (0x0032ff48)
fixme:winedbg:print_value ---error
  17 0x41865baa call_thread_entry_point+0x79(entry=, arg=0x7ffdf000)
[/Users/chip/wine-build/dlls/ntdll/../../../wine-git/dlls/ntdll/signal_i386.c:2499]
in ntdll (0x0032ffc8)
  18 0x4183e13e start_process+0x1d(kernel_start=0x4404f5b0)
[/Users/chip/wine-build/dlls/ntdll/../../../wine-git/dlls/ntdll/loader.c:2612]
in ntdll (0x0032ffe8)
make: *** [edit.ok] Error 5

[Bug 28794] user32:edit crashes on Mac

http://bugs.winehq.org/show_bug.cgi?id=28794

--- Comment #4 from Aric Stewart  2011-10-18 16:24:32 CDT ---
Very strange,

could you get me a +uniscribe,+edit log?

[Bug 28794] user32:edit crashes on Mac

http://bugs.winehq.org/show_bug.cgi?id=28794

--- Comment #5 from Charles Davis  2011-10-18 16:59:03 CDT ---
Created attachment 36994
  --> http://bugs.winehq.org/attachment.cgi?id=36994
Log from user32:edit with WINEDEBUG=+uniscribe,+edit

Sure, here you are. You'll need something that can understand XZ to decompress
it.

[Bug 28794] user32:edit crashes on Mac

http://bugs.winehq.org/show_bug.cgi?id=28794

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.3.30

[Bug 28794] user32:edit crashes on Mac

http://bugs.winehq.org/show_bug.cgi?id=28794

--- Comment #6 from Aric Stewart  2011-10-19 08:40:13 CDT ---
Created attachment 37009
  --> http://bugs.winehq.org/attachment.cgi?id=37009
fix

I found an error in the string fitting that was resulting in string lengths not
shorting as needed.

I believe this is the source of your issue.  I have submitted this patch (it is
correct and needed regardless) but if you want to test with the patch that
would be great.

[Bug 28794] user32:edit crashes on Mac

http://bugs.winehq.org/show_bug.cgi?id=28794

--- Comment #7 from Charles Davis  2011-10-19 13:22:59 CDT ---
Yep, your patch fixes it, thanks!

[Bug 28794] user32:edit crashes on Mac

http://bugs.winehq.org/show_bug.cgi?id=28794

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |67196377b5b2fd28e7ef3d8bbb6
                   |                            |74740ddfe0508
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Austin English  2011-10-19 14:26:34 CDT ---
(In reply to comment #7)
> Yep, your patch fixes it, thanks!

http://source.winehq.org/git/wine.git/commitdiff/67196377b5b2fd28e7ef3d8bbb6...

[Bug 28794] user32:edit crashes on Mac

http://bugs.winehq.org/show_bug.cgi?id=28794

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2011-10-21 13:50:33 CDT ---
Closing bugs fixed in 1.3.31.