http://bugs.winehq.org/show_bug.cgi?id=8095
Rotem Zach rotemz@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rotemz@gmail.com
--- Comment #13 from Rotem Zach rotemz@gmail.com 2008-09-15 07:39:06 --- --- Fixing the "general date format"/"else if (*pFormat == 'c' || *pFormat == 'C')" part isnt enough. The VarTokenizeFormatString() tokenizer has a general problem: the actual variant type isnt taken into account (which could serve as hint). ---
Why not just fix this part?
As said by Damjan above, we can't alter VarTokenizeFormatString(). Why not fix "if (*pFormat == 'c' || *pFormat == 'C')" to be "if ((*pFormat == 'c' || *pFormat == 'C') && COULD_BE(FMT_TYPE_DATE))".
This doesn't break anything, is used by several other cases, fixes the bug (which affects atleast two apps) and only uses the format string.