[Bug 30146] New: Xmlhttp sample app doesn't work anymore

http://bugs.winehq.org/show_bug.cgi?id=30146

Bug #: 30146
           Summary: Xmlhttp sample app doesn't work anymore
           Product: Wine
           Version: 1.4
          Platform: x86
               URL: http://netikka.net/dev/delete.exe
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: urlmon
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified
   Regression SHA1: bb06ec7789367ac2a2465b6b5dca12a2e18c781b

Sample from bug 27613 doesn't work in current git

Terminal:

fixme:urlmon:CopyStgMedium Unimplemented tymed 1

Regression test:

bb06ec7789367ac2a2465b6b5dca12a2e18c781b is the first bad commit
commit bb06ec7789367ac2a2465b6b5dca12a2e18c781b
Author: Piotr Caban 
Date:   Thu Mar 8 13:45:51 2012 +0100

urlmon: Use CopyBindInfo in InternetBindInfo_GetBindInfo.

:040000 040000 888ba9dfe3a4ac0df3077786e4fd2e2b6391d6a9
eae8a1e17643c052f09d3766a3b2274d59c7475b M    dlls

git show bb06ec7789367ac2a2465b6b5dca12a2e18c781b | patch -p1 -R

Fixes the problem.

[Bug 30146] Xmlhttp sample app doesn't work anymore

http://bugs.winehq.org/show_bug.cgi?id=30146

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 30146] Xmlhttp sample app doesn't work anymore

http://bugs.winehq.org/show_bug.cgi?id=30146

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 30146] Xmlhttp sample app doesn't work anymore

http://bugs.winehq.org/show_bug.cgi?id=30146

--- Comment #1 from Nikolay Sivov  2012-03-12 01:57:43 CDT ---
Regression test looks right actually, the problem seems to be in custom verb
part:

---
    size = FIELD_OFFSET(BINDINFO, szCustomVerb)+sizeof(void*);
    if(pcbiSrc->cbSize>=size && pcbiDest->cbSize>=size &&
pcbiSrc->szCustomVerb) {
        size = (strlenW(pcbiSrc->szCustomVerb)+1)*sizeof(WCHAR);
        pcbiDest->szCustomVerb = CoTaskMemAlloc(size);
        if(!pcbiDest->szCustomVerb) {
            CoTaskMemFree(pcbiDest->szExtraInfo);
            ReleaseStgMedium(&pcbiDest->stgmedData);
            return E_OUTOFMEMORY;
        }
    }
---

it's never copied here, it worked before cause it was just a pointer copy.

[Bug 30146] Xmlhttp sample app doesn't work anymore

http://bugs.winehq.org/show_bug.cgi?id=30146

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Piotr Caban  2012-03-12 09:03:42 CDT ---
I've sent a patch that should fix it:
http://source.winehq.org/patches/data/84384

[Bug 30146] Xmlhttp sample app doesn't work anymore

http://bugs.winehq.org/show_bug.cgi?id=30146

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |c9bd71f32fdf7f5036a2430f6fc
                   |                            |021d0bbdf6c9b
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Nikolay Sivov  2012-03-13 14:17:17 CDT ---
This should be fixed now after c9bd71f32fdf7f5036a2430f6fc021d0bbdf6c9b.

[Bug 30146] Xmlhttp sample app doesn't work anymore

http://bugs.winehq.org/show_bug.cgi?id=30146

--- Comment #4 from Alexandre Julliard  2012-03-16 14:09:07 CDT ---
Closing bugs fixed in 1.5.0.

[Bug 30146] Xmlhttp sample app doesn't work anymore

http://bugs.winehq.org/show_bug.cgi?id=30146

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  2012-03-16 17:11:33 CDT ---
Really closing bugs fixed in 1.5.0.