[Bug 48642] New: kernel32:process contains a race condition in test_WaitForJobObject()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48642

Bug ID: 48642
           Summary: kernel32:process contains a race condition in
                    test_WaitForJobObject()
           Product: Wine
           Version: unspecified
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: kernel32
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 66499
  --> https://bugs.winehq.org/attachment.cgi?id=66499
Patch to reproduce and diagnose rare kernel32:process failures

The last test of test_WaitForJobObject() contains a race condition:

create_process("exit", &pi);
    // -> Starts a child process which exits almost immediately

ret = pAssignProcessToJobObject(job, pi.hProcess);
    // -> If the child has already exited this call fails

This rarely happens (~1% failure rate) but happened on the w864 and w1064v1709
64 bit tests in this job:
https://testbot.winehq.org/JobDetails.pl?Key=65660

[Bug 48642] kernel32:process contains a race condition in test_WaitForJobObject()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48642

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |7984fb9fbe881b596d58c6dfa10
                   |                            |d853ab0d06b6a
           Keywords|                            |source, testcase
                 OS|Linux                       |Windows

[Bug 48642] kernel32:process contains a race condition in test_WaitForJobObject()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48642

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 48642] kernel32:process contains a race condition in test_WaitForJobObject()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48642

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |5a66e3e0d82ee55b78095be1a86
                   |                            |68639107e6bb5

--- Comment #1 from François Gouget  ---
This is fixed.

commit 5a66e3e0d82ee55b78095be1a8668639107e6bb5
Author: Francois Gouget 
Date:   Wed Mar 11 09:28:44 2020 +0100

kernel32/tests: Fix a race condition in test_WaitForJobObject().

Synchronize with the child process to ensure it does not exit before
    being added to the test job.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48642
    Signed-off-by: Francois Gouget 
    Signed-off-by: Alexandre Julliard

[Bug 48642] kernel32:process contains a race condition in test_WaitForJobObject()

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=48642

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Alexandre Julliard  ---
Closing bugs fixed in 5.5.