[Bug 27387] New: Lexware installers need some IXMLDOMParseError properties implemented (srcText, line, linepos)
http://bugs.winehq.org/show_bug.cgi?id=27387
Summary: Lexware installers need some IXMLDOMParseError properties implemented (srcText, line, linepos) Product: Wine Version: 1.3.21 Platform: x86 OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: msxml3 AssignedTo: wine-bugs@winehq.org ReportedBy: focht@gmx.net
Hello,
Lexware installers currently need native msxml3 override due to incomplete XML ParseError implementation. Unlike other apps where the parse error is queried _after_ something bad happened, the installer also queries parse error on successful load of XML document which breaks the installer.
--- snip --- 0025:Call KERNEL32.CreateFileA(00840610 "C:\users\focht\Local Settings\Application Data\Lexware\LxSetupTemp\LxSetupConfig.xml",80000000,00000001,00000000,00000003,00000080,00000000) ret=0048fcb1 0025:Ret KERNEL32.CreateFileA() retval=0000000c ret=0048fcb1 ... 0025:trace:msxml:DOMClassFactory_CreateInstance (nil) {00000000-0000-0000-c000-000000000046} 0x32f76c 0025:trace:msxml:DOMDocument_create ({2933bf90-7b36-11d2-b20e-00c04f983e60}, (nil), 0x32f628) ... 0025:Ret ole32.CoCreateInstance() retval=00000000 ret=00478580 0025:Call ole32.OleRun(001578d4) ret=0047858f 0025:trace:msxml:domdoc_QueryInterface (0x1578b8)->({00000126-0000-0000-c000-000000000046} 0x32f6cc) 0025:trace:msxml:domdoc_QueryInterface interface {00000126-0000-0000-c000-000000000046} not implemented 0025:Ret ole32.OleRun() retval=00000000 ret=0047858f 0025:trace:msxml:domdoc_QueryInterface (0x1578b8)->({2933bf81-7b36-11d2-b20e-00c04f983e60} 0x32f79c) 0025:trace:msxml:domdoc_AddRef (0x1578b8)->(2) 0025:trace:msxml:domdoc_Release (0x1578b8)->(1) 0025:trace:msxml:domdoc_AddRef (0x1578b8)->(2) 0025:trace:msxml:domdoc_Release (0x1578b8)->(1) 0025:trace:msxml:domdoc_put_async (0x1578b8)->(0) 0025:trace:msxml:domdoc_put_validateOnParse (0x1578b8)->(0) 0025:trace:msxml:domdoc_put_resolveExternals (0x1578b8)->(0) 0025:trace:msxml:domdoc_AddRef (0x1578b8)->(2) 0025:trace:msxml:domdoc_Release (0x1578b8)->(1) 0025:Call ole32.CreateStreamOnHGlobal(00000000,00000001,0032f7c4) ret=00478803 ... 0025:Ret ole32.CreateStreamOnHGlobal() retval=00000000 ret=00478803 ... 0025:trace:msxml:domdoc_load (0x1578b8)->({VT_UNKNOWN: 0x157868}) 0025:trace:msxml:domdoc_QueryInterface (0x1578b8)->({00000109-0000-0000-c000-000000000046} 0x32f6f8) 0025:trace:msxml:domdoc_AddRef (0x1578b8)->(2) 0025:trace:msxml:domdoc_IPersistStreamInit_Load (0x1578b8)->(0x157868) 0025:Call ole32.CreateStreamOnHGlobal(00000000,00000001,00157904) ret=44744a9c ... 0025:Ret ole32.CreateStreamOnHGlobal() retval=00000000 ret=44744a9c ... 0025:Call ole32.GetHGlobalFromStream(0015a9e0,0032e66c) ret=44744bd6 0025:Ret ole32.GetHGlobalFromStream() retval=00000000 ret=44744bd6 ... 0025:trace:msxml:xmldoc_release (0x7df571b0)->(0) 0025:trace:msxml:xmldoc_release freeing docptr 0x7df571b0 ... 0025:trace:msxml:xmldoc_add_ref (0x7df575b8)->(1) 0025:trace:msxml:domdoc_load Using IStream to load Document 0025:Call oleaut32.VariantClear(0032f7a4) ret=004788d7 0025:Ret oleaut32.VariantClear() retval=00000000 ret=004788d7 0025:fixme:msxml:domdoc_get_parseError (0x1578d4)->(0x32f734): creating a dummy parseError 0025:Call ntdll.RtlAllocateHeap(00110000,00000000,00000024) ret=4475fed2 0025:Ret ntdll.RtlAllocateHeap() retval=0015da80 ret=4475fed2 0025:fixme:msxml:parseError_get_srcText (0x15da80)->(0x32f734) 0025:trace:msxml:parseError_QueryInterface (0x15da80)->({df0b3d60-548f-101b-8e65-08002b2bd119} 0x32f728) 0025:fixme:msxml:parseError_QueryInterface interface {df0b3d60-548f-101b-8e65-08002b2bd119} not implemented 0025:Call KERNEL32.RaiseException(e06d7363,00000001,00000003,0032f6e4) ret=004a35e2 0025:trace:seh:raise_exception code=e06d7363 flags=1 addr=0x7b838b9b ip=7b838b9b tid=0025 0025:trace:seh:raise_exception info[0]=19930520 0025:trace:seh:raise_exception info[1]=0032f700 0025:trace:seh:raise_exception info[2]=004e46b4 0025:trace:seh:raise_exception eax=7b825f1d ebx=7b891ff4 ecx=19930520 edx=0032f5f4 esi=0032f6d0 edi=0032f650 0025:trace:seh:raise_exception ebp=0032f638 esp=0032f5d4 cs=0073 ds=007b es=007b fs=0033 gs=003b flags=00000203 ... --- snip ---
Current stubs:
http://source.winehq.org/git/wine.git/blob/HEAD:/dlls/msxml3/parseerror.c#l2...
With parse error implemented, the installer succeeds:
--- snip --- 0021:trace:msxml:domdoc_load Using IStream to load Document 0021:Call oleaut32.VariantClear(0032f7a4) ret=004788d7 0021:Ret oleaut32.VariantClear() retval=00000000 ret=004788d7 0021:fixme:msxml:domdoc_get_parseError (0x1578d4)->(0x32f734): creating a dummy parseError ... 0021:fixme:msxml:parseError_get_srcText (0x15da80)->(0x32f734) ... 0021:trace:msxml:parseError_get_reason (0x15da80)->(0x32f734) ... 0021:fixme:msxml:parseError_get_linepos (0x15da80)->(0x32f754) 0021:fixme:msxml:parseError_get_line (0x15da80)->(0x32f758) 0021:trace:msxml:parseError_get_errorCode (0x15da80)->(0x32f75c) 0021:trace:msxml:parseError_get_errorCode (0x15da80)->(0x32f760) ... 0021:trace:msxml:parseError_Release (0x15da80) ref now 0 ... 0021:trace:msxml:domdoc_get_xml (0x1578b8)->(0x32f864) 0021:trace:msxml:domdoc_get_xml 0, len=12087 0021:Call KERNEL32.MultiByteToWideChar(0000fde9,00000000,7d19d4d0 "<?xml version=\"1.0\" encoding=\"iso-8859-1\"?>\n<!-- edited with XML Spy v4.1 U (http://www.xmlspy.com) by m (Lexware GmbH & Co, KG) -->\n<lxsetup currentmode="" currentpage="welcome" serialnumber="" product="office" workingdirectory="" tempdirectory="" setuptype="" licenseaccepted="f"...,ffffffff,00000000,00000000) ret=20051675 ... ---
The snippet shows the following stubs need implementation:
parseError_get_srcText parseError_get_line parseError_get_linepos
Might help other apps too ...
Regards
http://bugs.winehq.org/show_bug.cgi?id=27387
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Installer
--- Comment #1 from Anastasius Focht focht@gmx.net 2011-06-04 05:27:07 CDT --- Hello,
adding keyword
Regards
http://bugs.winehq.org/show_bug.cgi?id=27387
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|wine-bugs@winehq.org |bunglehead@gmail.com
--- Comment #2 from Nikolay Sivov bunglehead@gmail.com 2011-11-04 14:52:08 CDT --- Ok, I'll do that.
http://bugs.winehq.org/show_bug.cgi?id=27387
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com 2011-11-09 12:21:14 CST --- Should be fixed with 945dccb7d60afd636bca380e80e14f7aa3f107c1 and 9397fb2ad76f4ea581313f3b28e90dc7eb5eb909.
Please retest.
http://bugs.winehq.org/show_bug.cgi?id=27387
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |945dccb7d60afd636bca380e80e | |14f7aa3f107c1 Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #4 from Anastasius Focht focht@gmx.net 2011-11-09 16:12:49 CST --- Hello Nikolay,
--- quote --- Should be fixed with 945dccb7d60afd636bca380e80e14f7aa3f107c1 and 9397fb2ad76f4ea581313f3b28e90dc7eb5eb909.
Please retest. --- quote ---
Yes, the parseError properties part is fixed, no C++ exception anymore.
--- snip --- 0024:fixme:msxml:domdoc_get_parseError (0x15b07c)->(0x32f714): creating a dummy parseError ... 0024:trace:msxml:parseError_get_srcText (0x161198)->(0x32f714) ... 0024:trace:msxml:parseError_get_reason (0x161198)->(0x32f714) ... 0024:trace:msxml:parseError_get_linepos (0x161198)->(0x32f734) 0024:trace:msxml:parseError_get_line (0x161198)->(0x32f738): stub 0024:trace:msxml:parseError_get_errorCode (0x161198)->(0x32f73c) 0024:trace:msxml:parseError_get_errorCode (0x161198)->(0x32f740) ... 0024:trace:msxml:parseError_Release (0x161198)->(0) --- snip ---
Though the installer suffers from regression on other part ... blank dialog window :|
$ wine --version wine-1.3.32-122-g2e5f73e
Regards
http://bugs.winehq.org/show_bug.cgi?id=27387
--- Comment #5 from Nikolay Sivov bunglehead@gmail.com 2011-11-09 20:37:04 CST --- (In reply to comment #4)
Though the installer suffers from regression on other part ... blank dialog window :|
It's not a msxml regression I suppose?
http://bugs.winehq.org/show_bug.cgi?id=27387
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org 2011-11-18 13:04:07 CST --- Closing bugs fixed in 1.3.33.
https://bugs.winehq.org/show_bug.cgi?id=27387
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|bunglehead@gmail.com |wine-bugs@winehq.org
-
wine-bugs＠winehq.org